search for: send_directory

...iority: P5 Component: core Assignee: wayned at samba.org Reporter: alguien at respiranto.de QA Contact: rsync-qa at samba.org Created attachment 14205 --> https://bugzilla.samba.org/attachment.cgi?id=14205&action=edit Patch to handle ENOTDIR in flist.c:send_directory() If rsync is called with doubled --fuzzy flag and --link-dest (or --compare-dest, --copy-dest), it fails in a situation as described below. The problem appears in both version 3.1.3 and the current development version 3.1.4dev. Let there be the following directory structure $PWD/ `- src/ `-...

I'm compiling rsync 3.0.9pre1 using Microsoft Visual Studio 2010 on my windows XP system. I get a compilation failure in flist.c, function send_directory: flist.c(1653) : error C2143: syntax error : missing ';' before 'type' flist.c(1654) : error C2065: 'name_len' : undeclared identifier flist.c(1654) : warning C4018: '>=' : signed/unsigned mismatch flist.c(1660) : error C2065: 'name_len' : undeclared iden...

https://bugzilla.samba.org/show_bug.cgi?id=3430 Summary: Error with ACL-patch and -x on mountpoint Product: rsync Version: 2.6.6 Platform: Other OS/Version: FreeBSD Status: NEW Severity: minor Priority: P3 Component: core AssignedTo: wayned@samba.org ReportedBy: samba-bugs@digital-trauma.de

...send_file_entry(file, f, base_flags); } - - if (S_ISDIR(file->mode) && recursive) { + if (S_ISDIR(file->mode) && recursive ) { struct exclude_struct **last_exclude_list = local_exclude_list; - - send_directory(f, flist, f_name(file)); - - local_exclude_list = last_exclude_list; + + if ( recurse_level>1 || !recurse_level) { + if (recurse_level) + recurse_level--; + + send_directory(f, flist, f_name(fil...

...6: malloc (vg_replace_malloc.c:195) by 0x41DFD7: _realloc_array (util.c:1438) by 0x41EC36: expand_item_list (util.c:1690) by 0x43C3DE: rsync_xal_get (xattrs.c:268) by 0x43C602: get_xattr (xattrs.c:309) by 0x4076EF: send_file_name (flist.c:1433) by 0x40817D: send_directory (flist.c:1673) by 0x408991: send1extra (flist.c:1827) by 0x408D23: send_extra_file_list (flist.c:1899) by 0x417345: send_files (sender.c:184) by 0x42110A: client_run (main.c:1039) by 0x421B9B: start_client (main.c:1287) - There is another unrelated leak at much...

Thought my troubles were fixed, but files disappeared again and reappeared after a few dozen rsync cycles. I am mapping a Win2K directory to Linux with Samba. That mounted directory is then Rsynced to another Linux box on a schedule (Linux to Linux, because I can't run rsync on the windows machine). For some unknown reason, several thousand files are periodically (after several days) deleted

I just received this bug report on Debian's rsync package. I've verified it. The entry from the manpage: -C [...] Finally, any file is ignored if it is in the same directory as a .cvsignore file and matches one of the patterns listed therein. Here the patterns of a .cvsignore file is apparently used to exclude file outside the directory where the .cvsignore file is found. Any

...use rsync it reported: rsync: readdir("/Volumes/KidD/."): Input/output error (5) And then proceeded to delete every file and directory on the remote volume. It appears that rsync is not handling this error properly, and that it's treating it as an empty directory. The problem is in send_directory() in flist.c. opendir() apparently worked on my bad volume but readdir() failed. I don't grok the code well enough to suggest a patch, but I see that errno gets reported at the bottom of the function but it doesn't short-circuit the remainder of the code, in the way the error handling on op...

...tedBy: grarpamp at gmail.com QAContact: rsync-qa at samba.org platform: i386 os: FreeBSD 4.11-STABLE gcc: 2.95.4 why: This is a compile failure regression against 3.0.7. from 3.0.8 (fails): gcc -I. -I. -g -O2 -DHAVE_CONFIG_H -Wall -W -I./popt -c flist.c -o flist.o flist.c: In function `send_directory': flist.c:1653: syntax error before `unsigned' flist.c:1654: `name_len' undeclared (first use in this function) flist.c:1654: (Each undeclared identifier is reported only once flist.c:1654: for each function it appears in.) Other notes: from 3.0.8 (using flist.c from 3.0.7 for conven...

Hi! This problem gave me quite a headache tonight... I more or less have this source directory: hop@krautesel:/var/tmp$ ls -laR from/ from/: total 12 drwxrwxr-x 3 hop hop 4096 Feb 8 03:34 . drwxrwxrwt 6 root root 4096 Feb 8 03:34 .. drwxrwxr-x 2 hop hop 4096 Feb 8 03:18 CVS -rw-rw-r-- 1 hop hop 0 Feb 8

...evel)) return NULL; @@ -825,6 +794,8 @@ void send_file_name(int f, struct file_l } if (S_ISDIR(file->mode) && recursive) { + if (one_file_system && file->dev != filesystem_dev) + return; struct exclude_struct **last_exclude_list = local_exclude_list; send_directory(f, flist, f_name(file));

...r_local_exclude_list, st)) { + return 1; + } return 0; } @@ -799,8 +804,11 @@ if (S_ISDIR(file->mode) && recursive) { struct exclude_struct **last_exclude_list = local_exclude_list; + struct exclude_struct **recur_last_exclude_list = + recur_local_exclude_list; send_directory(f, flist, f_name(file)); local_exclude_list = last_exclude_list; + recur_local_exclude_list = recur_last_exclude_list; return; } } @@ -840,6 +848,29 @@ local_exclude_list = NULL; + if (rsync_exclude) { + if (strlen(fname) + strlen(".rsync-") <= MAXPATHLEN - 1) { + st...

Hey everyone, I am a final semester MCA student. I've chosen rsync as the subject of my project for my graduation. Hence I would appreciate it if someone could guide me with some ideas on how I can contribute to rsync. I will work hard to implement whatever suggestions that you can all give me. I would definitely like to know what are some of the issues concerning rsync. May be I can then

https://bugzilla.samba.org/show_bug.cgi?id=7057 Summary: Buffer overflow when sending a file with long name Product: rsync Version: 3.0.7 Platform: All URL: https://bugzilla.redhat.com/show_bug.cgi?id=557916 OS/Version: Linux Status: NEW Severity: normal Priority: P3 Component: core

...flist, char *fname, int recursive, unsigned base_flags) @@ -800,8 +828,11 @@ if (S_ISDIR(file->mode) && recursive) { struct exclude_struct **last_exclude_list = local_exclude_list; + struct exclude_struct **recur_last_exclude_list = + recur_local_exclude_list; send_directory(f, flist, f_name(file)); local_exclude_list = last_exclude_list; + recur_local_exclude_list = recur_last_exclude_list; return; } } @@ -840,6 +871,7 @@ p = fname + strlen(fname); local_exclude_list = NULL; + recur_local_exclude_list = copy_exclude_list(recur_local_exclude_list);...

....c:593 #92 0x0805a2f5 in send_file_name (f=3, flist=0x0, fname=0x0, recursive=1422892226, base_flags=0) at flist.c:920 #93 0x0805a3bc in send_file_name (f=3, flist=0x273, fname=0x1999dd8a <Address 0x1999dd8a out of bounds>, recursive=627, base_flags=21711) at flist.c:932 #94 0x0805a43c in send_directory (f=707678303, flist=0x54cf9cc2, dir=0x277 <Address 0x277 out of bounds>) at flist.c:946 #95 0x08059e25 in make_file (fname=0x0, flist=0x0, exclude_level=4) at flist.c:819 #96 0x08059e71 in make_file (fname=0x0, flist=0x0, exclude_level=143314120) at flist.c:823 #97 0x0804d5f3 in recv_files (f...

...corrupt(conn, "Unknown error %i (%s)", error, strerror(error)); - return send_reply(conn, XS_ERROR, xsd_errors[i].errstring, + send_reply(conn, XS_ERROR, xsd_errors[i].errstring, strlen(xsd_errors[i].errstring) + 1); } @@ -797,7 +795,7 @@ return false; } -static bool send_directory(struct connection *conn, const char *node) +static void send_directory(struct connection *conn, const char *node) { char *path, *reply = talloc_strdup(node, ""); unsigned int reply_len = 0; @@ -805,13 +803,17 @@ struct dirent *dirent; node = canonicalize(conn, node); - if (!che...

https://bugzilla.samba.org/show_bug.cgi?id=3825 Summary: rsync won't delete directory with excluded files Product: rsync Version: 2.6.8 Platform: x86 OS/Version: Linux Status: NEW Severity: normal Priority: P3 Component: core AssignedTo: wayned@samba.org ReportedBy: vanes002@umn.edu

...t, int f) @@ -925,8 +961,11 @@ if (recursive && S_ISDIR(file->mode) && !(file->flags & FLAG_MOUNT_POINT)) { struct exclude_struct **last_exclude_list = local_exclude_list; + struct exclude_struct **recur_last_exclude_list = + recur_local_exclude_list; send_directory(f, flist, f_name_to(file, fbuf)); local_exclude_list = last_exclude_list; + recur_local_exclude_list = recur_last_exclude_list; return; } } @@ -963,6 +1002,7 @@ } local_exclude_list = NULL; + recur_local_exclude_list = copy_exclude_list(recur_local_exclude_list); if (cvs_exclud...

...ame_dst, "%s%s", + file->basename,suffix); + } + + /* rprintf(FERROR,"darDEBUG: %s,%s to %s,%s\n", + file_rf->dirname,file_rf->basename, + file_rf->dirname_dst,file_rf->basename_dst); */ + return file_rf; + } + } + return NULL; +} static void send_directory(int f, struct file_list *flist, char *dir) @@ -1409,3 +1481,35 @@ return p; } + +char *f_name_dst(struct file_struct *f) +{ + static char names[10][MAXPATHLEN]; + static int n; + char *p = names[n]; + char *dname, *bname; + + if (!f || !f->basename) + return NULL; + + dname=f->dirname;...