search for: secoffset

I was using a GELI partition for /usr/home on 7.0, so it attaches and mounts on boot. The problem is it stopped working after the system was upgraded to RELENG_7/7.1-PRERELEASE. Here's how it goes: I have the following /etc/fstab: /dev/ad0s1b none swap sw 0 0 /dev/ad0s1a / ufs rw 1 1 /dev/ad0s1d

...t one. >> DwarfDebug.cpp: >> computeSizeAndOffsets: >> I believe this produces the wrong offset for the 3rd CU and >> onwards. computeSizeAndOffset returns the EndOffset which is absolute, not >> relative to the Offset passed in, so it should be assigned to SecOffset, >> not added to it. (eg: if you have CUs at 0, 42, and 57 - the first pass >> through SecOffset will be zero, then it'll be 0 + 42, then on the 3rd it'll >> be (0 + 42) + 57 which isn't right, it should just be 57). Please add more >> test coverage while fixing...

...: >>>> computeSizeAndOffsets: >>>> I believe this produces the wrong offset for the 3rd CU and >>>> onwards. computeSizeAndOffset returns the EndOffset which is absolute, not >>>> relative to the Offset passed in, so it should be assigned to SecOffset, >>>> not added to it. (eg: if you have CUs at 0, 42, and 57 - the first pass >>>> through SecOffset will be zero, then it'll be 0 + 42, then on the 3rd it'll >>>> be (0 + 42) + 57 which isn't right, it should just be 57). Please add more >>>...

...reviewing this first one. > DwarfDebug.cpp: > computeSizeAndOffsets: > I believe this produces the wrong offset for the 3rd CU and onwards. > computeSizeAndOffset returns the EndOffset which is absolute, not relative > to the Offset passed in, so it should be assigned to SecOffset, not added > to it. (eg: if you have CUs at 0, 42, and 57 - the first pass through > SecOffset will be zero, then it'll be 0 + 42, then on the 3rd it'll be (0 + > 42) + 57 which isn't right, it should just be 57). Please add more test > coverage while fixing this issue. >...

...DwarfDebug.cpp: >>> computeSizeAndOffsets: >>> I believe this produces the wrong offset for the 3rd CU and >>> onwards. computeSizeAndOffset returns the EndOffset which is absolute, not >>> relative to the Offset passed in, so it should be assigned to SecOffset, >>> not added to it. (eg: if you have CUs at 0, 42, and 57 - the first pass >>> through SecOffset will be zero, then it'll be 0 + 42, then on the 3rd it'll >>> be (0 + 42) + 57 which isn't right, it should just be 57). Please add more >>> test covera...

...er to the second patch in reviewing this first one. DwarfDebug.cpp: computeSizeAndOffsets: I believe this produces the wrong offset for the 3rd CU and onwards. computeSizeAndOffset returns the EndOffset which is absolute, not relative to the Offset passed in, so it should be assigned to SecOffset, not added to it. (eg: if you have CUs at 0, 42, and 57 - the first pass through SecOffset will be zero, then it'll be 0 + 42, then on the 3rd it'll be (0 + 42) + 57 which isn't right, it should just be 57). Please add more test coverage while fixing this issue. Eric/Manman: rough desi...

...omputeSizeAndOffsets: >>>>>> I believe this produces the wrong offset for the 3rd CU and >>>>>> onwards. computeSizeAndOffset returns the EndOffset which is absolute, not >>>>>> relative to the Offset passed in, so it should be assigned to SecOffset, >>>>>> not added to it. (eg: if you have CUs at 0, 42, and 57 - the first pass >>>>>> through SecOffset will be zero, then it'll be 0 + 42, then on the 3rd it'll >>>>>> be (0 + 42) + 57 which isn't right, it should just be 57). Plea...

I have a GPT formatted disk where I recently expanded the size of a partition. I used "gpart resize -i 6 ada1" first to expand the partition to use the remaining free space and then growfs to modify the FFS file system to use the full partition. This was all done in single-user mode, of course, but when I enter "exit" to bring the system up, it failed to mount /usr. This was

...t;> computeSizeAndOffsets: >>>>> I believe this produces the wrong offset for the 3rd CU and >>>>> onwards. computeSizeAndOffset returns the EndOffset which is absolute, not >>>>> relative to the Offset passed in, so it should be assigned to SecOffset, >>>>> not added to it. (eg: if you have CUs at 0, 42, and 57 - the first pass >>>>> through SecOffset will be zero, then it'll be 0 + 42, then on the 3rd it'll >>>>> be (0 + 42) + 57 which isn't right, it should just be 57). Please add more...

...: >>>> computeSizeAndOffsets: >>>> I believe this produces the wrong offset for the 3rd CU and >>>> onwards. computeSizeAndOffset returns the EndOffset which is absolute, not >>>> relative to the Offset passed in, so it should be assigned to SecOffset, >>>> not added to it. (eg: if you have CUs at 0, 42, and 57 - the first pass >>>> through SecOffset will be zero, then it'll be 0 + 42, then on the 3rd it'll >>>> be (0 + 42) + 57 which isn't right, it should just be 57). Please add more >>>...

...DwarfDebug.cpp: >>> computeSizeAndOffsets: >>> I believe this produces the wrong offset for the 3rd CU and >>> onwards. computeSizeAndOffset returns the EndOffset which is absolute, not >>> relative to the Offset passed in, so it should be assigned to SecOffset, >>> not added to it. (eg: if you have CUs at 0, 42, and 57 - the first pass >>> through SecOffset will be zero, then it'll be 0 + 42, then on the 3rd it'll >>> be (0 + 42) + 57 which isn't right, it should just be 57). Please add more >>> test covera...

...dOffsets: >>>>>>> I believe this produces the wrong offset for the 3rd CU and >>>>>>> onwards. computeSizeAndOffset returns the EndOffset which is absolute, not >>>>>>> relative to the Offset passed in, so it should be assigned to SecOffset, >>>>>>> not added to it. (eg: if you have CUs at 0, 42, and 57 - the first pass >>>>>>> through SecOffset will be zero, then it'll be 0 + 42, then on the 3rd it'll >>>>>>> be (0 + 42) + 57 which isn't right, it should just...

...t;>>>>>>> I believe this produces the wrong offset for the 3rd CU and >>>>>>>> onwards. computeSizeAndOffset returns the EndOffset which is absolute, not >>>>>>>> relative to the Offset passed in, so it should be assigned to SecOffset, not >>>>>>>> added to it. (eg: if you have CUs at 0, 42, and 57 - the first pass through >>>>>>>> SecOffset will be zero, then it'll be 0 + 42, then on the 3rd it'll be (0 + >>>>>>>> 42) + 57 which isn't right, it...

...dOffsets: >>>>>>> I believe this produces the wrong offset for the 3rd CU and >>>>>>> onwards. computeSizeAndOffset returns the EndOffset which is absolute, not >>>>>>> relative to the Offset passed in, so it should be assigned to SecOffset, >>>>>>> not added to it. (eg: if you have CUs at 0, 42, and 57 - the first pass >>>>>>> through SecOffset will be zero, then it'll be 0 + 42, then on the 3rd it'll >>>>>>> be (0 + 42) + 57 which isn't right, it should just...

...t;>>>>>>> I believe this produces the wrong offset for the 3rd CU and >>>>>>>> onwards. computeSizeAndOffset returns the EndOffset which is absolute, not >>>>>>>> relative to the Offset passed in, so it should be assigned to SecOffset, >>>>>>>> not added to it. (eg: if you have CUs at 0, 42, and 57 - the first pass >>>>>>>> through SecOffset will be zero, then it'll be 0 + 42, then on the 3rd it'll >>>>>>>> be (0 + 42) + 57 which isn't right, it...

...t;>>>>> I believe this produces the wrong offset for the 3rd CU and >>>>>>>>> onwards. computeSizeAndOffset returns the EndOffset which is absolute, not >>>>>>>>> relative to the Offset passed in, so it should be assigned to SecOffset, >>>>>>>>> not added to it. (eg: if you have CUs at 0, 42, and 57 - the first pass >>>>>>>>> through SecOffset will be zero, then it'll be 0 + 42, then on the 3rd it'll >>>>>>>>> be (0 + 42) + 57 which isn'...

...t;>>> I believe this produces the wrong offset for the 3rd CU and >>>>>>>>>> onwards. computeSizeAndOffset returns the EndOffset which is absolute, not >>>>>>>>>> relative to the Offset passed in, so it should be assigned to SecOffset, >>>>>>>>>> not added to it. (eg: if you have CUs at 0, 42, and 57 - the first pass >>>>>>>>>> through SecOffset will be zero, then it'll be 0 + 42, then on the 3rd it'll >>>>>>>>>> be (0 + 42) + 57 wh...

...g offset for the 3rd CU >>>>>>>>>>> and onwards. computeSizeAndOffset returns the EndOffset which is absolute, >>>>>>>>>>> not relative to the Offset passed in, so it should be assigned to >>>>>>>>>>> SecOffset, not added to it. (eg: if you have CUs at 0, 42, and 57 - the >>>>>>>>>>> first pass through SecOffset will be zero, then it'll be 0 + 42, then on >>>>>>>>>>> the 3rd it'll be (0 + 42) + 57 which isn't right, it should ju...

...g offset for the 3rd CU >>>>>>>>>>> and onwards. computeSizeAndOffset returns the EndOffset which is absolute, >>>>>>>>>>> not relative to the Offset passed in, so it should be assigned to >>>>>>>>>>> SecOffset, not added to it. (eg: if you have CUs at 0, 42, and 57 - the >>>>>>>>>>> first pass through SecOffset will be zero, then it'll be 0 + 42, then on >>>>>>>>>>> the 3rd it'll be (0 + 42) + 57 which isn't right, it should ju...

...the 3rd CU >>>>>>>>>>>> and onwards. computeSizeAndOffset returns the EndOffset which is absolute, >>>>>>>>>>>> not relative to the Offset passed in, so it should be assigned to >>>>>>>>>>>> SecOffset, not added to it. (eg: if you have CUs at 0, 42, and 57 - the >>>>>>>>>>>> first pass through SecOffset will be zero, then it'll be 0 + 42, then on >>>>>>>>>>>> the 3rd it'll be (0 + 42) + 57 which isn't right, it s...