Displaying 3 results from an estimated 3 matches for "search_appliance".
2018 May 04
2
[PATCH] appliance: initialize the appliance_files struct
Some compilers do not manage to figure out that the members of it are
set only when search_appliance() in the end returns 1, which is already
checked. Help them a bit by resetting the appliance_files struct on our
own, so they will not report that 'appliance.kernel', and the others are
used as uninitialized.
---
lib/appliance.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/lib/ap...
2017 May 04
0
Re: [PATCH v1 1/2] appliance: search all types of appliances for each path separately
...h);
> + return 1;
This is copied from the existing code, and isn't wrong, but you might
as well simplify it by using safe_asprintf, ie:
appliance->kernel = safe_asprintf (g, "%s/kernel", path);
There are some further cases of the same thing below.
> +static int
> +search_appliance (guestfs_h *g, appliance_files *appliance)
> +{
> + const char *pelem = g->path;
> +
> + /* Note that if g->path is an empty string, we want to check the
> + * current directory (for backwards compatibility with
> + * libguestfs < 1.5.4).
> + */
> + do {
&g...
2017 May 05
2
Re: [PATCH v2 1/2] appliance: search all types of appliances for each path separately
...pbutsykin@virtuozzo.com>
> ---
> lib/appliance.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/lib/appliance.c b/lib/appliance.c
> index 66f91cb0a..42591e7d7 100644
> --- a/lib/appliance.c
> +++ b/lib/appliance.c
> @@ -222,7 +222,7 @@ search_appliance (guestfs_h *g, struct appliance_files *appliance)
> static int
> contains_old_style_appliance (guestfs_h *g, const char *path, void *data)
> {
> - return dir_contains_files (g, path, kernel_name, initrd_name, NULL);
> + return dir_contains_files (g, path, kernel_name, initrd_nam...