search for: seago

I've rebased the patch series to the current next branch and am sending them again.

We already had the validation rule in place, but the way the betternestedset API sets the parent_id the rules were being bypassed. Signed-off-by: Scott Seago <sseago at redhat.com> --- src/app/models/pool.rb | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/src/app/models/pool.rb b/src/app/models/pool.rb index 2979fcb..0a63723 100644 --- a/src/app/models/pool.rb +++ b/src/app/models/pool.rb @@ -65,6 +65,9 @@ class Pool &l...

Signed-off-by: Scott Seago <sseago at redhat.com> --- src/app/views/task/_show.rhtml | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/src/app/views/task/_show.rhtml b/src/app/views/task/_show.rhtml index f4e001d..ff7d434 100644 --- a/src/app/views/task/_show.rhtml +++ b/src/app/views/task/_s...

There were two javascript functions with the same name, and the wrong one was being called. I renamed one to avoid conflicts. Signed-off-by: Scott Seago <sseago at redhat.com> --- src/app/views/vm/add_to_smart_pool.rhtml | 3 ++- src/public/javascripts/ovirt.js | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/app/views/vm/add_to_smart_pool.rhtml b/src/app/views/vm/add_to_smart_pool.rhtml index cdfe92d...

Signed-off-by: Scott Seago <sseago at redhat.com> --- src/app/controllers/storage_volume_controller.rb | 6 ++- src/app/services/storage_volume_service.rb | 60 ++++++++++++--------- 2 files changed, 39 insertions(+), 27 deletions(-) diff --git a/src/app/controllers/storage_volume_controller.rb b/src/app/c...

Added column title and made it sortable. Signed-off-by: Scott Seago <sseago at redhat.com> --- src/app/models/pool.rb | 4 +++- src/app/views/user/_grid.rhtml | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/app/models/pool.rb b/src/app/models/pool.rb index 0a63723..3c95684 100644 --- a/src/app/models/pool.rb +++ b/src...

In addition, removed unnecessary 'rescue' clauses and fixed a bug in a prior fix for this problem for the Permission and Network controllers. Signed-off-by: Scott Seago <sseago at redhat.com> --- src/app/controllers/application.rb | 2 +- src/app/controllers/network_controller.rb | 2 +- src/app/controllers/permission_controller.rb | 6 ++---- src/app/controllers/resources_controller.rb | 5 ++--- src/app/controllers/storage_contro...

Signed-off-by: Scott Seago <sseago at redhat.com> --- src/app/services/vm_service.rb | 25 ++++++++++++++++--------- 1 files changed, 16 insertions(+), 9 deletions(-) diff --git a/src/app/services/vm_service.rb b/src/app/services/vm_service.rb index 4c29bcf..47ac5f5 100644 --- a/src/app/services/vm_service.rb +++ b...

The recent refactoring didn't work properly for new smart pools, so I've cleaned jup the parameter handling for the various pool 'create' actions. Signed-off-by: Scott Seago <sseago at redhat.com> --- src/app/controllers/hardware_controller.rb | 5 +---- src/app/controllers/pool_controller.rb | 6 ++++-- src/app/controllers/resources_controller.rb | 6 ------ src/app/services/hardware_pool_service.rb | 4 ++-- src/app/services/smart_pool_...

...l/permission_controller_test.rb b/src/test/functional/permission_controller_test.rb index 0885890..49bf1ef 100644 --- a/src/test/functional/permission_controller_test.rb +++ b/src/test/functional/permission_controller_test.rb @@ -1,6 +1,7 @@ # Copyright (C) 2008 Red Hat, Inc. -# Written by Scott Seago <sseago at redhat.com> +# Written by Scott Seago <sseago at redhat.com>, +# Jason Guiditta <jguiditt at redhat.com> # # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by @@ -23,...

Hi, When I click on "Edit Network" on my managed node in the hosts tab of the oVirt UI I only see one NIC. My managed node has 2 NICs, one on the guest network and one on the admin network. The NIC on the admin network is not listed in the network editor. Is this normal? I'm trying to create a VM and boot the cobbler profile I created for Fedora 10 but I can only boot the VM

This isn't yet functional, but I'm submitting the patch so Ian can continue work on it. Signed-off-by: Scott Seago <sseago at redhat.com> --- .../lib/ovirt/controllers/network_controller.rb | 26 ++++++++++++++++++++ .../physical_network_impl_controller.rb | 10 +++++++ .../lib/ovirt/controllers/vlan_impl_controller.rb | 9 +++++++ src/ovirt-agent/ovirt_api.xml...

...bject('stop_vm', vms(:production_httpd_vm).id)) + end +end diff --git a/src/test/unit/vm_test.rb b/src/test/unit/vm_test.rb index 5e03715..a5d6b3d 100644 --- a/src/test/unit/vm_test.rb +++ b/src/test/unit/vm_test.rb @@ -1,6 +1,7 @@ # # Copyright (C) 2008 Red Hat, Inc. -# Written by Scott Seago <sseago at redhat.com> +# Written by Scott Seago <sseago at redhat.com>, +# Jason Guiditta <jguiditt at redhat.com> # # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by @@ -19,...

This revised version of the patch incorporates jguidditta's sorting fix as well as some other changes required to make this work fully on the cloud UI side. --- src/app/controllers/pool_controller.rb | 2 +- src/app/controllers/resources_controller.rb | 4 +++- src/app/controllers/smart_pools_controller.rb | 5 ++--- src/app/helpers/application_helper.rb | 14

This revised version of the patch incorporates jguiditta's sorting fix as well as some other changes required to make this work fully on the cloud UI side. --- src/app/controllers/pool_controller.rb | 2 +- src/app/controllers/resources_controller.rb | 4 +++- src/app/controllers/smart_pools_controller.rb | 7 +++---- src/app/helpers/application_helper.rb | 14

There's still a problem with this working on the cloud side, but that can be resolved in a subsequent commit. --- src/app/controllers/pool_controller.rb | 2 +- src/app/controllers/resources_controller.rb | 7 ++++++- src/app/controllers/smart_pools_controller.rb | 5 ++--- src/app/helpers/application_helper.rb | 14 ++++++++++++++ src/app/models/vm.rb

This resend includes the rebase, but fixes a problem I just noticed with nil/empty checks.

This is a resend of the 2-patch series from a week or so ago, needed to be rebased due to some commits on next

The following two patches should be applied in the order: * [PATCH server] Add svc_vm_actions method to VmService. * [PATCH server] Cloud UI layer to initiate actions on vms. The service layer patch should work fine on its own (and not break anything), but cloud patch relies on service being there.

...room for additional refactoring as we may want to eventually split out nic, bonding, and ip address manipulation into their own controller/svc module, but that would be a much more extensive redesign than we want to deal with for the overall service layer creation refactoring. Signed-off-by: Scott Seago <sseago at redhat.com> --- src/app/controllers/network_controller.rb | 521 ++++++----------------------- src/app/models/ip_address.rb | 11 + src/app/models/network.rb | 12 + src/app/models/physical_network.rb | 4 + src/app/models/vlan.rb...