search for: scsi_request

Hi all, this series builds on my previous changes in Jens' for-4.11/rq-refactor branch that split out the BLOCK_PC fields from struct request into a new struct scsi_request, and makes support for struct scsi_request and the SCSI passthrough ioctls optional. It is now only enabled by drivers that need it. In addition I've made SCSI passthrough support in the virtio_blk driver an optional compile time feature, as it's not actually needed for most common setups...

Hi all, this series builds on my previous changes in Jens' for-4.11/rq-refactor branch that split out the BLOCK_PC fields from struct request into a new struct scsi_request, and makes support for struct scsi_request and the SCSI passthrough ioctls optional. It is now only enabled by drivers that need it. In addition I've made SCSI passthrough support in the virtio_blk driver an optional compile time feature, as it's not actually needed for most common setups...

On 09/15/2017 10:37 AM, Christoph Hellwig wrote: > On Fri, Sep 15, 2017 at 09:54:08AM -0700, Laura Abbott wrote: >> Hi, >> >> Fedora got a bug report on an early version of 4.13.2 >> https://paste.fedoraproject.org/paste/t-Yx23LN5QwJ7oPZLj3zrg > > Can you check if the issue goes away when you disable > CONFIG_VIRTIO_BLK_SCSI? > Yes, the issue goes away

On 09/15/2017 10:37 AM, Christoph Hellwig wrote: > On Fri, Sep 15, 2017 at 09:54:08AM -0700, Laura Abbott wrote: >> Hi, >> >> Fedora got a bug report on an early version of 4.13.2 >> https://paste.fedoraproject.org/paste/t-Yx23LN5QwJ7oPZLj3zrg > > Can you check if the issue goes away when you disable > CONFIG_VIRTIO_BLK_SCSI? > Yes, the issue goes away

...-432,16 +432,6 @@ config VIRTIO_BLK This is the virtual block driver for virtio. It can be used with QEMU based VMMs (like KVM or Xen). Say Y or M. -config VIRTIO_BLK_SCSI - bool "SCSI passthrough request for the Virtio block driver" - depends on VIRTIO_BLK - select BLK_SCSI_REQUEST - ---help--- - Enable support for SCSI passthrough (e.g. the SG_IO ioctl) on - virtio-blk devices. This is only supported for the legacy - virtio protocol and not enabled by default by any hypervisor. - You probably want to use virtio-scsi instead. - config BLK_DEV_RBD tristate "Ra...

...csi.h --- /dev/null Thu Jan 01 00:00:00 1970 +0000 +++ b/xen/include/public/io/scsi.h Wed Aug 02 15:14:15 2006 +0900 @@ -0,0 +1,41 @@ +#ifndef __XEN__PUBLIC_IO_SCSI_H__ +#define __XEN__PUBLIC_IO_SCSI_H__ + +#include "ring.h" + +#define SRP_MAX_IU_LEN 256 +#define SRP_CAN_QUEUE 8 + +struct scsi_request { + char buf[SRP_MAX_IU_LEN]; +}; + +struct scsi_response { + char buf[sizeof(struct srp_rsp)]; +}; + +DEFINE_RING_TYPES(scsi, struct scsi_request, struct scsi_response); + +#define SRP_MAX_INDIRECT ((SRP_MAX_IU_LEN - \ + sizeof (struct srp_cmd) - \ + sizeof (struct srp_indirect_buf))...

On Sat, Sep 16, 2017 at 04:16:06PM -0700, Laura Abbott wrote: > Yes, the issue goes away when CONFIG_VIRTIO_BLK_SCSI is > disabled. Ok, so it's probably related to follow ups to the scsi_request split. That being said, I would highly recommend turning off CONFIG_VIRTIO_BLK_SCSI in fedora. The feature has caused more trouble than it helped with, and should never have been added (saying that as the person who added it). It was never supported with virtio 1.0 devices and has been disabled i...

...alculate_bounce_limit); + +-struct request_queue *scsi_alloc_queue(struct scsi_device *sdev) ++struct request_queue *__scsi_alloc_queue(struct Scsi_Host *shost, ++ request_fn_proc *request_fn) + { +- struct Scsi_Host *shost = sdev->host; + struct request_queue *q; + +- q = blk_init_queue(scsi_request_fn, NULL); ++ q = blk_init_queue(request_fn, NULL); + if (!q) + return NULL; + +- blk_queue_prep_rq(q, scsi_prep_fn); +- + blk_queue_max_hw_segments(q, shost->sg_tablesize); + blk_queue_max_phys_segments(q, SCSI_MAX_PHYS_SEGMENTS); + blk_queue_max_sectors(q, shost->max_sectors); + blk...