search for: scripts_done

...Roman Kagan wrote: > On Fri, May 13, 2016 at 09:17:40AM +0200, Cedric Bosdonnat wrote: > > On Thu, 2016-05-12 at 17:24 +0300, Roman Kagan wrote: > > > On Thu, May 12, 2016 at 03:29:11PM +0200, Cédric Bosdonnat wrote: > > > > @@ -244,15 +244,14 @@ if not exist \"%%scripts_done%%\" ( > > > > > > > > for %%%%f in (\"%%scripts%%\"\\*.bat) do ( > > > > echo running \"%%%%f\" > > > > - call \"%%%%f\" > > > > - set elvl=!errorlevel! > > > > - echo .... exit code...

...+------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/customize/firstboot.ml b/customize/firstboot.ml index aa5b694..83bd808 100644 --- a/customize/firstboot.ml +++ b/customize/firstboot.ml @@ -232,7 +232,7 @@ set log=%%firstboot%%\\log.txt set scripts=%%firstboot%%\\scripts set scripts_done=%%firstboot%%\\scripts-done -call :main > \"%%log%%\" 2>&1 +call :main >> \"%%log%%\" 2>&1 exit /b :main @@ -244,15 +244,14 @@ if not exist \"%%scripts_done%%\" ( for %%%%f in (\"%%scripts%%\"\\*.bat) do ( echo running \&quo...

...iff --git a/customize/firstboot.ml b/customize/firstboot.ml > > index aa5b694..83bd808 100644 > > --- a/customize/firstboot.ml > > +++ b/customize/firstboot.ml > > @@ -232,7 +232,7 @@ set log=%%firstboot%%\\log.txt > > set scripts=%%firstboot%%\\scripts > > set scripts_done=%%firstboot%%\\scripts-done > > > > -call :main > \"%%log%%\" 2>&1 > > +call :main >> \"%%log%%\" 2>&1 > > exit /b > > > > :main > > @@ -244,15 +244,14 @@ if not exist \"%%scripts_done%%\" ( > &g...

...+++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/customize/firstboot.ml b/customize/firstboot.ml index d9c012f..1f4a940 100644 --- a/customize/firstboot.ml +++ b/customize/firstboot.ml @@ -238,7 +238,7 @@ set log=%%firstboot%%\\log.txt set scripts=%%firstboot%%\\scripts set scripts_done=%%firstboot%%\\scripts-done -call :main > \"%%log%%\" 2>&1 +call :main >> \"%%log%%\" 2>&1 exit /b :main @@ -250,12 +250,12 @@ if not exist \"%%scripts_done%%\" ( for %%%%f in (\"%%scripts%%\"\\*.bat) do ( echo running \&quo...

Hi there! I know it's been a while since I posted my first version of some patches. But here I have rebased them on top of Roman's work and added a few other ones. Cédric Bosdonnat (11): v2v: also search for windows virtio drivers in symlinks Update packagelist for SLES customize: fix windows firstboot script customize: change windows firstboot path customize: add support for

...= sprintf "\ @echo off -echo starting firstboot service >>log.txt +setlocal EnableDelayedExpansion +set firstboot=%s +set log=%%firstboot%%\\log.txt -for /f %%f in ('dir /b scripts') do call \"scripts\\%%f\" >>log.txt +set scripts=%%firstboot%%\\scripts +set scripts_done=%%firstboot%%\\scripts-done -echo uninstalling firstboot service >>log.txt -rhsrvany.exe -s firstboot uninstall >>log.txt -" in +call :main > \"%%log%%\" 2>&1 +exit /b + +:main +echo starting firstboot service + +if not exist \"%%scripts_done%%\" ( +...

...+0300, Roman Kagan wrote: > IMO deleting anything is a bad idea, in particular, because a > succefully > completed script may cause the following ones to fail. Well, I guess most of the users won't be aware of it and scripts will probably stay there for ever. > The whole point of scripts_done is to preserve all the steps but move > them out of the way. > > I think the only controversial item is whether to move them to > scripts_done on success only or regardless of the status: there are > pros > and cons either way. The goal of moving the script to scripts_done BEFOR...

When firstboot is used from virt-v2v the scripts, if not fast enough, can get killed by Windows. After windows installs virtio drivers injected by virt-v2v it performs some internall reboot, stopping all the running services and killing any running firstboot script. This is problem mostly for MSI installs (like qemu-ga that was added recently) that can take several seconds to finish. This change

...1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/mlcustomize/firstboot.ml b/mlcustomize/firstboot.ml index c3ebfd9..b4ca181 100644 --- a/mlcustomize/firstboot.ml +++ b/mlcustomize/firstboot.ml @@ -286,10 +286,18 @@ set log=%%firstboot%%\\log.txt set scripts=%%firstboot%%\\scripts set scripts_done=%%firstboot%%\\scripts-done -call :main >> \"%%log%%\" 2>&1 +call :main %%1 >> \"%%log%%\" 2>&1 exit /b :main + +if not '%%1' == 'real' ( + REM schedule delayed task + schtasks.exe /Delete /TN Firstboot /F + powershell.exe...

This patchset attempts to address a number of shortcomings in the firstboot infrastructure I came across while working with v2v conversion of various Windows VMs. Roman Kagan (4): firstboot: consolidate line ending conversion firstboot: enhance firstboot driver script for Windows firstboot: make script naming descriptive convert_windows: split firstboot into steps

Hi there, Here is v3 of the remaining patches. Diff to v2: * Removed the patch related to QXL * Fixed the firstboot script with Roman's comments * Fixed ova with subfolders test * Handle MF-relative path in ova files * Fixed now unneeded match case as per Richard's comment Cédric Bosdonnat (3): customize: fix windows firstboot script v2v: add support for SUSE VMDP drivers v2v:

Hi all, v2 includes all comments from Pino and Richard. I also removed the mkdir /run/lvm in the init since it only failed in one case and couldn't reproduce it anymore. Cédric Bosdonnat (11): v2v: also search for windows virtio drivers in symlinks Update packagelist for SLES and openSUSE customize: fix windows firstboot script customize: change windows firstboot path customize:

...tion(-) > > diff --git a/mlcustomize/firstboot.ml b/mlcustomize/firstboot.ml > index c3ebfd9..b4ca181 100644 > --- a/mlcustomize/firstboot.ml > +++ b/mlcustomize/firstboot.ml > @@ -286,10 +286,18 @@ set log=%%firstboot%%\\log.txt > set scripts=%%firstboot%%\\scripts > set scripts_done=%%firstboot%%\\scripts-done > > -call :main >> \"%%log%%\" 2>&1 > +call :main %%1 >> \"%%log%%\" 2>&1 > exit /b > > :main > + > +if not '%%1' == 'real' ( > + REM schedule delayed task > + schtask...

...a/mlcustomize/firstboot.ml b/mlcustomize/firstboot.ml > > index c3ebfd9..b4ca181 100644 > > --- a/mlcustomize/firstboot.ml > > +++ b/mlcustomize/firstboot.ml > > @@ -286,10 +286,18 @@ set log=%%firstboot%%\\log.txt > > set scripts=%%firstboot%%\\scripts > > set scripts_done=%%firstboot%%\\scripts-done > > > > -call :main >> \"%%log%%\" 2>&1 > > +call :main %%1 >> \"%%log%%\" 2>&1 > > exit /b > > > > :main > > + > > +if not '%%1' == 'real' ( > > +...

...oot_dir // srvany); (* Write a firstboot.bat control script which just runs the other * scripts in the directory. Note we need to use CRLF line endings @@ -252,8 +260,8 @@ for %%%%f in (\"%%scripts%%\"\\*.bat) do ( echo uninstalling firstboot service rmdir /S /Q \"%%scripts_done%%\" -rhsrvany.exe -s firstboot uninstall -" firstboot_dir_win in +%s -s firstboot uninstall +" firstboot_dir_win srvany in g#write (firstboot_dir // "firstboot.bat") (unix2dos firstboot_script); @@ -282,7 +290,7 @@ rhsrvany.exe -s firstboot uninstall &quot...

...oot_dir // srvany); (* Write a firstboot.bat control script which just runs the other * scripts in the directory. Note we need to use CRLF line endings @@ -252,8 +258,8 @@ for %%%%f in (\"%%scripts%%\"\\*.bat) do ( echo uninstalling firstboot service rmdir /S /Q \"%%scripts_done%%\" -rhsrvany.exe -s firstboot uninstall -" firstboot_dir_win in +%s -s firstboot uninstall +" firstboot_dir_win srvany in g#write (firstboot_dir // "firstboot.bat") (unix2dos firstboot_script); @@ -282,7 +288,7 @@ rhsrvany.exe -s firstboot uninstall &quot...