search for: sc_prohibit_empty_lines_at_eof

...015169eee Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering at redhat.com> Date: Mon, 17 Sep 2012 11:49:34 +0200 Subject: [PATCH libguestfs] maint: remove a subsumed syntax-check rule * cfg.mk (sc_prohibit_trailing_blank_lines): Remove rule. It is now subsumed by the much more efficient sc_prohibit_empty_lines_at_EOF rule in gnulib's maint.mk. --- cfg.mk | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/cfg.mk b/cfg.mk index e619f0a..3b0b45e 100644 --- a/cfg.mk +++ b/cfg.mk @@ -1,5 +1,5 @@ # Customize Makefile.maint. -*- makefile -*- -# Copyright (C...

...++++++++++------------ 2 files changed, 17 insertions(+), 14 deletions(-) diff --git a/cfg.mk b/cfg.mk index c1334fe..528f722 100644 --- a/cfg.mk +++ b/cfg.mk @@ -14,8 +14,11 @@ gnulib_dir = .gnulib exclude_file_name_regexp--sc_trailing_blank = \ ^sh/hivexsh\.pod$$ -exclude_file_name_regexp--sc_prohibit_empty_lines_at_EOF = \ - ^images/minimal$$ +_img_regexp = ^images/(minimal|rlenvalue_test_hive)$$ +exclude_file_name_regexp--sc_prohibit_empty_lines_at_EOF = $(_img_regexp) +exclude_file_name_regexp--sc_trailing_blank = $(_img_regexp) exclude_file_name_regexp--sc_useless_cpp_parens = \ ^lib/gettext\.h$$ + +conf...

From: Jim Meyering <meyering at redhat.com> * lib/hivex.c (hivex_node_set_value): Remove unnecessary test-before-free. --- lib/hivex.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/lib/hivex.c b/lib/hivex.c index d042f4f..a72fa77 100644 --- a/lib/hivex.c +++ b/lib/hivex.c @@ -2748,8 +2748,7 @@ hivex_node_set_value (hive_h *h, hive_node_h node, leave_partial:

...a/mbr-ext2-empty.img.gz > tests/guests/guest-aux/debian-packages > tests/guests/guest-aux/minimal-hive > tests/guests/guest-aux/windows-software > tests/guests/guest-aux/windows-system > tests/regressions/rhbz576879.sh > maint.mk: empty line(s) or no newline at EOF > make: *** [sc_prohibit_empty_lines_at_EOF] Error 1 One problem with this test is it's matching binaries. > prohibit_magic_number_exit > po-docs/ja.po:59861:"might be called indirectly from L<exit(3)>, which can cause unexpected " > po-docs/libguestfs-docs.pot:50902:"might be called indirectly from L<e...

This patch series moves some files and directories around but is only code motion (or supposed to be). A new directory, common/, is created for all of the common code which is currently shared in random ways between parts of the project. And src/ becomes lib/ (the largest change, but mostly mechanical). In full this series makes the following changes: src/libprotocol -> common/protocol

Previous patch series was posted here: https://www.redhat.com/archives/libguestfs/2017-January/msg00059.html v2 simply extends this patch series to cover the extra directories common/edit, common/progress, common/windows and common/parallel. The only remaining item is to consider whether we should rename mllib to something else, mlcommon was my suggestion. Rich.