search for: sc_avoid_ctype_macro

The first c-set cleans up the list of excluded syntax-checks. The second enables the sc_avoid_ctype_macros test and changes each use of a ctype macro like isspace to c_isspace. This makes it so such tests (often parsing-related) is locale-independent. Otherwise, in some odd corner cases (combination of non-C locale and perverted inputs), I suspect that libguestfs tools would mistakenly accept surprisin...

...0644 index 0000000..d4a4f31 --- /dev/null +++ b/.x-sc_trailing_blank @@ -0,0 +1 @@ +images/bin-win64.exe diff --git a/cfg.mk b/cfg.mk index 7130cea..c672e4d 100644 --- a/cfg.mk +++ b/cfg.mk @@ -70,8 +70,7 @@ disable_temporarily = \ sc_m4_quote_check \ sc_prohibit_trailing_blank_lines \ sc_avoid_ctype_macros \ - sc_avoid_write \ - sc_trailing_blank + sc_avoid_write # Avoid uses of write(2). Either switch to streams (fwrite), or use # the safewrite wrapper. diff --git a/regressions/test-cancellation-download-librarycancels.sh b/regressions/test-cancellation-download-librarycancels.sh index 9...

...b/') && \ + { echo '$(ME): found TAB(s) used for indentation in C sources;'\ + 'use spaces' 1>&2; exit 1; } || : + +ctype_re = isalnum|isalpha|isascii|isblank|iscntrl|isdigit|isgraph|islower\ +|isprint|ispunct|isspace|isupper|isxdigit|tolower|toupper + +sc_avoid_ctype_macros: + @grep -E '\b($(ctype_re)) *\(' /dev/null \ + $$($(VC_LIST_EXCEPT)) && \ + { echo "$(ME): don't use ctype macros (use c-ctype.h)" \ + 1>&2; exit 1; } || : + +sc_prohibit_virBufferAdd_with_string_literal: + @re='\<virBufferAdd *\([^,]+, *&...