search for: sbobroff

From: Sam Bobroff <sbobroff at linux.ibm.com> [ Upstream commit 3c6b8625dde82600fd03ad1fcba223f1303ee535 ] When unloading the bochs-drm driver, a warning message is printed by drm_mode_config_cleanup() because a reference is still held to one of the drm_connector structs. Correct this by calling drm_atomic_helper_shutdo...

From: Sam Bobroff <sbobroff at linux.ibm.com> [ Upstream commit 3c6b8625dde82600fd03ad1fcba223f1303ee535 ] When unloading the bochs-drm driver, a warning message is printed by drm_mode_config_cleanup() because a reference is still held to one of the drm_connector structs. Correct this by calling drm_atomic_helper_shutdo...

It's not a core function, and the matching atomic functions are also not in the core. Plus the suspend/resume helper is also already there. Needs a tiny bit of open-coding, but less midlayer beats that I think. Cc: Sam Bobroff <sbobroff at linux.ibm.com> Signed-off-by: Daniel Vetter <daniel.vetter at intel.com> Cc: Maarten Lankhorst <maarten.lankhorst at linux.intel.com> Cc: Maxime Ripard <maxime.ripard at bootlin.com> Cc: Sean Paul <sean at poorly.run> Cc: David Airlie <airlied at linux.ie> Cc: Be...

...> > > It's not a core function, and the matching atomic functions are also > > not in the core. Plus the suspend/resume helper is also already there. > > > > Needs a tiny bit of open-coding, but less midlayer beats that I think. > > > > Cc: Sam Bobroff <sbobroff at linux.ibm.com> > > Signed-off-by: Daniel Vetter <daniel.vetter at intel.com> > > Cc: Maarten Lankhorst <maarten.lankhorst at linux.intel.com> > > Cc: Maxime Ripard <maxime.ripard at bootlin.com> > > Cc: Sean Paul <sean at poorly.run> > > C...

...previous commits. Both together are required to cause it: Fixes: 846c7dfc1193 ("drm/atomic: Try to preserve the crtc enabled state in drm_atomic_remove_fb, v2.") Fixes: 6579c39594ae ("drm/bochs: atomic: switch planes to atomic, wire up helpers.") Signed-off-by: Sam Bobroff <sbobroff at linux.ibm.com> --- Hello, This seems to be similar to an issue I recently fixed for the AST driver: 1e613f3c630c ("drm/ast: Fix connector leak during driver unload") Which is similar to at least one other recent fix: 192b4af6cd28 ("drm/tegra: Shutdown on driver unbind")...

...previous commits. Both together are required to cause it: Fixes: 846c7dfc1193 ("drm/atomic: Try to preserve the crtc enabled state in drm_atomic_remove_fb, v2.") Fixes: 6579c39594ae ("drm/bochs: atomic: switch planes to atomic, wire up helpers.") Signed-off-by: Sam Bobroff <sbobroff at linux.ibm.com> --- Hello, This seems to be similar to an issue I recently fixed for the AST driver: 1e613f3c630c ("drm/ast: Fix connector leak during driver unload") Which is similar to at least one other recent fix: 192b4af6cd28 ("drm/tegra: Shutdown on driver unbind")...

...vetter at ffwll.ch> wrote: > > It's not a core function, and the matching atomic functions are also > not in the core. Plus the suspend/resume helper is also already there. > > Needs a tiny bit of open-coding, but less midlayer beats that I think. > > Cc: Sam Bobroff <sbobroff at linux.ibm.com> > Signed-off-by: Daniel Vetter <daniel.vetter at intel.com> > Cc: Maarten Lankhorst <maarten.lankhorst at linux.intel.com> > Cc: Maxime Ripard <maxime.ripard at bootlin.com> > Cc: Sean Paul <sean at poorly.run> > Cc: David Airlie <airli...

It's not a core function, and the matching atomic functions are also not in the core. Plus the suspend/resume helper is also already there. Needs a tiny bit of open-coding, but less midlayer beats that I think. v2: Rebase onto ast (which gained a new user). Cc: Sam Bobroff <sbobroff at linux.ibm.com> Reviewed-by: Alex Deucher <alexander.deucher at amd.com> Reviewed-by: Sean Paul <sean at poorly.run> Signed-off-by: Daniel Vetter <daniel.vetter at intel.com> Cc: Maarten Lankhorst <maarten.lankhorst at linux.intel.com> Cc: Maxime Ripard <maxime.ripar...

On Tue, May 21, 2019 at 10:10:29AM +0200, Gerd Hoffmann wrote: > Hi, > > The bug is in the driver, so ... > > > Bisecting the issue for commits to drivers/gpu/drm/bochs/ points to: > > 6579c39594ae ("drm/bochs: atomic: switch planes to atomic, wire up helpers.") > > ... but the issue also seems to be due to a change in the generic drm code > > ...