search for: sberdevices

...s small optimization for tx path: instead of allocating single >skbuff on every call to transport, allocate multiple skbuff's until >credit space allows, thus trying to send as much as possible data without >return to af_vsock.c. > >Signed-off-by: Arseniy Krasnov <AVKrasnov at sberdevices.ru> >--- > Link to v1: > https://lore.kernel.org/netdev/2c52aa26-8181-d37a-bccd-a86bd3cbc6e1 at sberdevices.ru/ > Link to v2: > https://lore.kernel.org/netdev/ea5725eb-6cb5-cf15-2938-34e335a442fa at sberdevices.ru/ > Link to v3: > https://lore.kernel.org/netdev/f33ef593-982e...

...s small optimization for tx path: instead of allocating single >skbuff on every call to transport, allocate multiple skbuff's until >credit space allows, thus trying to send as much as possible data without >return to af_vsock.c. > >Signed-off-by: Arseniy Krasnov <AVKrasnov at sberdevices.ru> >--- > Link to v1: > https://lore.kernel.org/netdev/2c52aa26-8181-d37a-bccd-a86bd3cbc6e1 at sberdevices.ru/ > Link to v2: > https://lore.kernel.org/netdev/ea5725eb-6cb5-cf15-2938-34e335a442fa at sberdevices.ru/ > > Changelog: > v1 -> v2: > - If sent something, r...

> On Mar 30, 2023, at 1:18 PM, Arseniy Krasnov <AVKrasnov at sberdevices.ru> wrote: > > !! External Email > > On 30.03.2023 23:13, Arseniy Krasnov wrote: >> This adds conversion of VMCI specific error code to general -ENOMEM. It >> is needed, because af_vsock.c passes error value returned from transport >> to the user, which does not e...

...urn data, because skbuff >>> must not be dropped, but for SOCK_SEQPACKET skbuff will be dropped by >>> kernel, and 'recv()' will return EAGAIN. >>> >>> Link to v1 on lore: >>> https://lore.kernel.org/netdev/c2d3e204-89d9-88e9-8a15-3fe027e56b4b at sberdevices.ru/ >>> >>> Link to v2 on lore: >>> https://lore.kernel.org/netdev/a7ab414b-5e41-c7b6-250b-e8401f335859 at sberdevices.ru/ >>> >>> Change log: >>> >>> v1 -> v2: >>> - For SOCK_SEQPACKET call 'skb_pull()' also in case...

...allocating single >>> skbuff on every call to transport, allocate multiple skbuff's until >>> credit space allows, thus trying to send as much as possible data without >>> return to af_vsock.c. >>> >>> Signed-off-by: Arseniy Krasnov <AVKrasnov at sberdevices.ru> >>> --- >>> Link to v1: >>> https://lore.kernel.org/netdev/2c52aa26-8181-d37a-bccd-a86bd3cbc6e1 at sberdevices.ru/ >>> >>> Changelog: >>> v1 -> v2: >>> - If sent something, return number of bytes sent (even in >>> ? c...

...n review becomes difficult because one has to look at all the patches to understand what the previous ones are for. I know it's boring, but it's very useful for those who review and even then if we have to bisect ;-) Thanks, Stefano > >Signed-off-by: Arseniy Krasnov <AVKrasnov at sberdevices.ru> >--- > include/linux/socket.h | 1 + > net/vmw_vsock/af_vsock.c | 26 ++++++++++++++++++++++++++ > 2 files changed, 27 insertions(+) > >diff --git a/include/linux/socket.h b/include/linux/socket.h >index 13c3a237b9c9..19a6f39fa014 100644 >--- a/include/linux/socket.h...

On Mon, Feb 06, 2023 at 06:58:24AM +0000, Arseniy Krasnov wrote: >Use pages of non-linear skb as buffers in virtio tx queue. > >Signed-off-by: Arseniy Krasnov <AVKrasnov at sberdevices.ru> >--- > net/vmw_vsock/virtio_transport.c | 31 +++++++++++++++++++++++++------ > 1 file changed, 25 insertions(+), 6 deletions(-) > >diff --git a/net/vmw_vsock/virtio_transport.c b/net/vmw_vsock/virtio_transport.c >index 28b5a8e8e094..b8a7d6dc9f46 100644 >--- a/net/vmw_vso...

...n we drop > skbuff here, we must account rest of it's data in 'rx_bytes'. >2) Free skbuff which was removed from socket's queue. > >Fixes: 71dc9ec9ac7d ("virtio/vsock: replace virtio_vsock_pkt with sk_buff") >Signed-off-by: Arseniy Krasnov <AVKrasnov at sberdevices.ru> >--- > net/vmw_vsock/virtio_transport_common.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > >diff --git a/net/vmw_vsock/virtio_transport_common.c b/net/vmw_vsock/virtio_transport_common.c >index 30b0539990ba..ffb1af4f2b52 100644 >--- a/net/vmw_vsock/virt...

...t like whole >>>>> sk_buff is read - so call 'skb_pull()' for the whole buffer. >>>>> >>>>> Fixes: 71dc9ec9ac7d ("virtio/vsock: replace virtio_vsock_pkt with sk_buff") >>>>> Signed-off-by: Arseniy Krasnov <AVKrasnov at sberdevices.ru> >>>>> --- >>>>> net/vmw_vsock/virtio_transport_common.c | 2 +- >>>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> Maybe we could avoid this patch if we directly use pkt_len as I >>>> suggested in the...

...; to update credit, there is no sense >to update skbuff state, because it is used only once after dequeue to >copy data and then will be released. > >Fixes: 71dc9ec9ac7d ("virtio/vsock: replace virtio_vsock_pkt with sk_buff") >Signed-off-by: Arseniy Krasnov <AVKrasnov at sberdevices.ru> >--- > net/vmw_vsock/virtio_transport_common.c | 1 - > 1 file changed, 1 deletion(-) Reviewed-by: Stefano Garzarella <sgarzare at redhat.com> > >diff --git a/net/vmw_vsock/virtio_transport_common.c b/net/vmw_vsock/virtio_transport_common.c >index 618680fd9906..9a411...

On Wed, Mar 22, 2023 at 09:36:24PM +0300, Arseniy Krasnov wrote: >Both of these functions have no effect when input argument is 0, so to >avoid useless spinlock access, check argument before it. > >Signed-off-by: Arseniy Krasnov <AVKrasnov at sberdevices.ru> >--- > net/vmw_vsock/virtio_transport_common.c | 6 ++++++ > 1 file changed, 6 insertions(+) Reviewed-by: Stefano Garzarella <sgarzare at redhat.com> > >diff --git a/net/vmw_vsock/virtio_transport_common.c b/net/vmw_vsock/virtio_transport_common.c >index 9e87c7d4d7cf...

...ENOMEM. It >is needed, because af_vsock.c passes error value returned from transport >to the user, which does not expect to get VMCI_ERROR_* values. > >Fixes: c43170b7e157 ("vsock: return errors other than -ENOMEM to socket") >Signed-off-by: Arseniy Krasnov <AVKrasnov at sberdevices.ru> >--- > net/vmw_vsock/vmci_transport.c | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) The patch LGTM, but I suggest to extract this patch from the series and send it directly to the net tree, while other patches can be sent to net-next. Reviewed-by: Stefano Garzarell...

...k_bh()'. >There is no need to disable interrupts in the loopback transport as >there is no access to the queue with skbs from interrupt context. Both >virtio and vhost transports work in the same way. Yep, this is a good point! > >Signed-off-by: Arseniy Krasnov <AVKrasnov at sberdevices.ru> >--- > net/vmw_vsock/vsock_loopback.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) LGTM! (net-next material) Reviewed-by: Stefano Garzarella <sgarzare at redhat.com> Thanks, Stefano > >diff --git a/net/vmw_vsock/vsock_loopback.c b/net/vmw_vsock/vsock_loop...

...()' function. > >Test is also added. > >Head for this patchset is: >https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/commit/?id=b38460bc463c54e0c15ff3b37e81f7e2059bb9bb > >Link to v1: >https://lore.kernel.org/netdev/20230801141727.481156-1-AVKrasnov at sberdevices.ru/ > >Changelog: >v1 -> v2: > * 0001 stills the same - SIGPIPE is sent only for SOCK_STREAM as discussed in v1 > with Stefano Garzarella <sgarzare at redhat.com>. > * 0002 - use 'sig_atomic_t' instead of 'bool' for flag variables updated from > sig...

...pdate 'data_len' also on each read from this skb. It looks like the above sentence is a left-over from previous version as, as this patch does not touch data_len. And I think it contradicts the previous one, so it's a bit confusing. > Signed-off-by: Arseniy Krasnov <AVKrasnov at sberdevices.ru> > --- > Changelog: > v5(big patchset) -> v1: > * Merge 'virtio_transport_common.c' and 'vhost/vsock.c' patches into > this single patch. > * Commit message update: grammar fix and remark that this patch is > MSG_ZEROCOPY preparation. >...

On Mon, Feb 06, 2023 at 06:57:16AM +0000, Arseniy Krasnov wrote: >This adds copying to guest's virtio buffers from non-linear skbs. Such >skbs are created by protocol layer when MSG_ZEROCOPY flags is used. > >Signed-off-by: Arseniy Krasnov <AVKrasnov at sberdevices.ru> >--- > drivers/vhost/vsock.c | 56 ++++++++++++++++++++++++++++++++---- > include/linux/virtio_vsock.h | 12 ++++++++ > 2 files changed, 63 insertions(+), 5 deletions(-) > >diff --git a/drivers/vhost/vsock.c b/drivers/vhost/vsock.c >index 1f3b89c885cc..60b9cafa3e31...

...Tue, 2023-08-15 at 00:27 +0300, Arseniy Krasnov wrote: > For non-linear skb use its pages from fragment array as buffers in > virtio tx queue. These pages are already pinned by 'get_user_pages()' > during such skb creation. > > Signed-off-by: Arseniy Krasnov <AVKrasnov at sberdevices.ru> > Reviewed-by: Stefano Garzarella <sgarzare at redhat.com> > --- > Changelog: > v2 -> v3: > * Comment about 'page_to_virt()' is updated. I don't remove R-b, > as this change is quiet small I guess. > > net/vmw_vsock/virtio_transport.c |...

On Mon, Feb 06, 2023 at 06:59:21AM +0000, Arseniy Krasnov wrote: >For TAP device new skb is created and data from the current skb is >copied to it. This adds copying data from non-linear skb to new >the skb. > >Signed-off-by: Arseniy Krasnov <AVKrasnov at sberdevices.ru> >--- > net/vmw_vsock/virtio_transport_common.c | 43 +++++++++++++++++++++++-- > 1 file changed, 40 insertions(+), 3 deletions(-) > >diff --git a/net/vmw_vsock/virtio_transport_common.c b/net/vmw_vsock/virtio_transport_common.c >index a1581c77cf84..05ce97b967ad 100644 >--...

...19, 2023 at 09:53:54PM +0300, Arseniy Krasnov wrote: >This adds test which checks case when data of newly received skbuff is >appended to the last skbuff in the socket's queue. > >This test is actual only for virtio transport. > >Signed-off-by: Arseniy Krasnov <AVKrasnov at sberdevices.ru> >--- > tools/testing/vsock/vsock_test.c | 81 ++++++++++++++++++++++++++++++++ > 1 file changed, 81 insertions(+) > >diff --git a/tools/testing/vsock/vsock_test.c b/tools/testing/vsock/vsock_test.c >index 3de10dbb50f5..00216c52d8b6 100644 >--- a/tools/testing/vsock/vsock_...

...ers, e.g. it is number of bytes returned >to user (of course accounting size of header). 'skb->len' is number of >bytes rest in buffer. > >Fixes: 71dc9ec9ac7d ("virtio/vsock: replace virtio_vsock_pkt with sk_buff") >Signed-off-by: Arseniy Krasnov <AVKrasnov at sberdevices.ru> >--- > net/vmw_vsock/virtio_transport_common.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/net/vmw_vsock/virtio_transport_common.c b/net/vmw_vsock/virtio_transport_common.c >index a1581c77cf84..2e2a773df5c1 100644 >--- a/net/vmw_vsock/virtio_tr...