search for: savelastvalue

...yself. >>> >>> I think you want isSafeToSpeculativelyExecute rather than >>> mayHaveSideEffects. Otherwise, looks fine. >> >> With isSafeToSpeculativelyExecute "make check" fails on some tests, >> i.e: >> test/Transforms/LoopIndexSplit/SaveLastValue-2007-08-17.ll >> because of PHI (isSafeToSpeculativelyExecute == false). > > isSafeToSpeculativelyExecute returns false for PHI nodes because it > isn't really clear what to do in that case... here, it's safe, so > isSafeToSpeculativelyExecute || isa<PHINode> is prob...

...you want isSafeToSpeculativelyExecute rather than >>>>> mayHaveSideEffects. Otherwise, looks fine. >>>> >>>> With isSafeToSpeculativelyExecute "make check" fails on some >>>> tests, i.e: >>>> test/Transforms/LoopIndexSplit/SaveLastValue-2007-08-17.ll >>>> because of PHI (isSafeToSpeculativelyExecute == false). >>> >>> isSafeToSpeculativelyExecute returns false for PHI nodes because it >>> isn't really clear what to do in that case... here, it's safe, so >>> isSafeToSpeculativ...

...t;>>> mayHaveSideEffects. Otherwise, looks fine. >>>>>> >>>>>> With isSafeToSpeculativelyExecute "make check" fails on some >>>>>> tests, >>>>>> i.e: >>>>>> test/Transforms/LoopIndexSplit/SaveLastValue-2007-08-17.ll >>>>>> because of PHI (isSafeToSpeculativelyExecute == false). >>>>> >>>>> isSafeToSpeculativelyExecute returns false for PHI nodes because >>>>> it >>>>> isn't really clear what to do in that case......

...t;>> >>>> I think you want isSafeToSpeculativelyExecute rather than >>>> mayHaveSideEffects.  Otherwise, looks fine. >>> >>> With isSafeToSpeculativelyExecute "make check" fails on some tests, i.e: >>> test/Transforms/LoopIndexSplit/SaveLastValue-2007-08-17.ll >>> because of PHI (isSafeToSpeculativelyExecute == false). >> >> isSafeToSpeculativelyExecute returns false for PHI nodes because it >> isn't really clear what to do in that case... here, it's safe, so >> isSafeToSpeculativelyExecute || isa&lt...

...SpeculativelyExecute rather than >>>>>> mayHaveSideEffects.  Otherwise, looks fine. >>>>> >>>>> With isSafeToSpeculativelyExecute "make check" fails on some tests, >>>>> i.e: >>>>> test/Transforms/LoopIndexSplit/SaveLastValue-2007-08-17.ll >>>>> because of PHI (isSafeToSpeculativelyExecute == false). >>>> >>>> isSafeToSpeculativelyExecute returns false for PHI nodes because it >>>> isn't really clear what to do in that case... here, it's safe, so >>>&gt...

Hello, This patch fixes PR4174. Two test-cases included: original one from bugzilla and a little bit complicated made be myself. It seems that LoopIndexSplit doesn't handle some cases, I'll try to send some patch this week. Regards -- Jakub Staszak -------------- next part -------------- A non-text attachment was scrubbed... Name: pr4174.patch Type: application/octet-stream Size:

...;>>>>>> mayHaveSideEffects.  Otherwise, looks fine. >>>>>>> >>>>>>> With isSafeToSpeculativelyExecute "make check" fails on some tests, >>>>>>> i.e: >>>>>>> test/Transforms/LoopIndexSplit/SaveLastValue-2007-08-17.ll >>>>>>> because of PHI (isSafeToSpeculativelyExecute == false). >>>>>> >>>>>> isSafeToSpeculativelyExecute returns false for PHI nodes because it >>>>>> isn't really clear what to do in that case... here, i...

...> bugzilla >> and a little bit complicated made be myself. > > I think you want isSafeToSpeculativelyExecute rather than > mayHaveSideEffects. Otherwise, looks fine. With isSafeToSpeculativelyExecute "make check" fails on some tests, i.e: test/Transforms/LoopIndexSplit/SaveLastValue-2007-08-17.ll because of PHI (isSafeToSpeculativelyExecute == false). >> It seems that LoopIndexSplit doesn't handle some cases, I'll try to >> send >> some patch this week. > > You mean like PR3913? Or are you referring to something else? 3913 is a bug. I mean...