Displaying 2 results from an estimated 2 matches for "saved_locale".
2013 Apr 11
0
[PATCH 1/2] Use C locale when reading ReplayGain tag
...e_double_(const FLAC__StreamMetadata_VorbisComment_Entry *
FLAC__bool grabbag__replaygain_load_from_vorbiscomment(const FLAC__StreamMetadata *block, FLAC__bool album_mode, FLAC__bool strict, double *reference, double *gain, double *peak)
{
int reference_offset, gain_offset, peak_offset;
+ char *saved_locale;
+ FLAC__bool res = true;
FLAC__ASSERT(0 != block);
FLAC__ASSERT(0 != reference);
@@ -618,20 +620,36 @@ FLAC__bool grabbag__replaygain_load_from_vorbiscomment(const FLAC__StreamMetadat
*/
*reference = ReplayGainReferenceLoudness;
+ /*
+ * We need to save the old locale and switch to &...
2014 Apr 30
2
make fullcheck fails: strtod/atof and locale
...allowed in cuesheets
2) local__parse_timecode_() have strspn(s, "1234567890.,") so comma is allowed in --skip and --until options
3) grabbag__replaygain_load_from_vorbiscomment() uses the following sequence:
setlocale(LC_ALL, "C"); use printf/strtod; setlocale(LC_ALL, saved_locale);
so RG tags always have decimal point
4) flac and metaflac: main() calls setlocale(LC_ALL, "") which sets default system locale
5) Probably it's better to use local version of strtod() that accepts both comma and point
as separators (just as FLAC uses local_strdup or flac_snprint...