Displaying 4 results from an estimated 4 matches for "saved_guest".
2008 Mar 31
4
[04/17] [PATCH] Add kvm arch-specific core code for kvm/ia64.-V8
...ugs in this one.
> +#include <linux/module.h>
> +#include <linux/vmalloc.h>
Don't think you need vmalloc.h here.
> +int kvm_arch_vcpu_ioctl_set_regs(struct kvm_vcpu *vcpu, struct kvm_regs
> *regs)
> +{
[snip]
> + copy_from_user(&vcpu->arch.guest, regs->saved_guest,
> + sizeof(union context));
> + copy_from_user(vcpu + 1, regs->saved_stack + sizeof(struct
> kvm_vcpu),
> + IA64_STK_OFFSET - sizeof(struct kvm_vcpu));
You need to check the return values from copy_from_user() here and
deal with possible failure.
> + vcpu->arch.apic =...
2008 Mar 31
4
[04/17] [PATCH] Add kvm arch-specific core code for kvm/ia64.-V8
...ugs in this one.
> +#include <linux/module.h>
> +#include <linux/vmalloc.h>
Don't think you need vmalloc.h here.
> +int kvm_arch_vcpu_ioctl_set_regs(struct kvm_vcpu *vcpu, struct kvm_regs
> *regs)
> +{
[snip]
> + copy_from_user(&vcpu->arch.guest, regs->saved_guest,
> + sizeof(union context));
> + copy_from_user(vcpu + 1, regs->saved_stack + sizeof(struct
> kvm_vcpu),
> + IA64_STK_OFFSET - sizeof(struct kvm_vcpu));
You need to check the return values from copy_from_user() here and
deal with possible failure.
> + vcpu->arch.apic =...
2008 Mar 31
1
[03/15][PATCH] kvm/ia64: Add header files for kvm/ia64. V8
Hi Xiantao,
Some more nit-picking, though some of this is a bit more important
to fixup.
Cheers,
Jes
> +typedef struct thash_data {
Urgh! argh! Please avoid typedefs unless you really need them, see
Chapter 5 of Documentation/CodingStyle for details.
> diff --git a/include/asm-ia64/kvm_host.h b/include/asm-ia64/kvm_host.h
> new file mode 100644
> index 0000000..522bde0
> ---
2008 Mar 31
1
[03/15][PATCH] kvm/ia64: Add header files for kvm/ia64. V8
Hi Xiantao,
Some more nit-picking, though some of this is a bit more important
to fixup.
Cheers,
Jes
> +typedef struct thash_data {
Urgh! argh! Please avoid typedefs unless you really need them, see
Chapter 5 of Documentation/CodingStyle for details.
> diff --git a/include/asm-ia64/kvm_host.h b/include/asm-ia64/kvm_host.h
> new file mode 100644
> index 0000000..522bde0
> ---