search for: save_cflag

...UTE([packed]) > +AX_GCC_FUNC_ATTRIBUTE([visibility]) > > AM_CONDITIONAL([GEN_ASM_OFFSETS], test "x$GEN_ASM_OFFSETS" = xyes) > > @@ -245,17 +246,13 @@ if test "x$GCC" = xyes; then > AC_MSG_RESULT([yes]), > [CFLAGS="$save_CFLAGS -Wmissing-prototypes"; > AC_MSG_RESULT([no])]); > + CFLAGS=$save_CFLAGS > > # Enable -fvisibility=hidden if using a gcc that supports it Can you restore this comment with a general pointer to "...compiler that support it". BTW, what is the c...

...t; AX_GCC_FUNC_ATTRIBUTE([packed]) > +AX_GCC_FUNC_ATTRIBUTE([visibility]) > > AM_CONDITIONAL([GEN_ASM_OFFSETS], test "x$GEN_ASM_OFFSETS" = xyes) > > @@ -245,17 +246,13 @@ if test "x$GCC" = xyes; then > AC_MSG_RESULT([yes]), > [CFLAGS="$save_CFLAGS -Wmissing-prototypes"; > AC_MSG_RESULT([no])]); > + CFLAGS=$save_CFLAGS > I'm not sure we want/need this one ? > # Enable -fvisibility=hidden if using a gcc that supports it As spotted by Sedat, please update the comment. > - save_CFLAGS="$CFLAGS&...

Patch 1 adds a check for the compilers visibility macro to configure.ac. Patch 2 avoids redefined symbol errors in clang of the tls entry points. Based on a suggestion from Rafael Ávila de Espíndola <rafael.espindola at gmail.com> in http://llvm.org/bugs/show_bug.cgi?id=19778. Tested with gcc 4.9 and clang 3.6(rc) Marc Dietrich (2): configure: add visibility macro detection to configure

...s propagating CFLAGS to all generated makefiles. The right thing > to do is > probably to prepend to CFLAGS instead of replacing it, so the user's > settings > will come later on the command line and override the defaults. OK, I checked in a fix... does this snippet look alright? SAVE_CFLAGS="$CFLAGS" CFLAGS='-I./include -I $(top_srcdir)/include -Wall -W' if test x$debug = xtrue; then CFLAGS="$CFLAGS -g -O0 -DDEBUG" else CFLAGS="$CFLAGS -O3 -DNDEBUG" if test x$GCC = xyes; then CFLAGS="$CFLAGS -fomit-frame-pointer -funroll-...

...6,26 @@ AC_ARG_WITH([kernel-source], > [kernel_source="$with_kernel_source"]) > AC_SUBST(kernel_source) > > +dnl Add flags for gcc and g++ > +if test "x$GCC" = xyes; then > + # Enable -fvisibility=hidden if using a gcc that supports it > + save_CFLAGS="$CFLAGS" > + AC_MSG_CHECKING([whether $CC supports -fvisibility=hidden]) > + VISIBILITY_CFLAGS="-fvisibility=hidden" > + CFLAGS="$CFLAGS $VISIBILITY_CFLAGS" > + AC_LINK_IFELSE([AC_LANG_PROGRAM()], AC_MSG_RESULT([yes]), > +...

...-enable-intrinsics switch currently used by x86. OK, will do. > >> + >> + AS_IF([test x"$enable_arm_neon_intrinsics" = x"yes"], >> + [ >> + AC_MSG_CHECKING(if compiler supports arm neon intrinsics) >> + save_CFLAGS="$CFLAGS" >> + save_CFLAGS="$CFLAGS"; CFLAGS="-mfpu=neon $CFLAGS" >> + AC_COMPILE_IFELSE( >> + [AC_LANG_PROGRAM([[#include <arm_neon.h>]], [])], >> + [ >> +...

On 30/07/14 11:16, Christian K?nig wrote: > [CCing Emil as well] > > Am 30.07.2014 um 11:38 schrieb Maarten Lankhorst: >> Using -export-symbols-regex all private symbols are hidden, resulting in the >> following changes: > > Wasn't "-export-symbols-regex" exactly that stuff we are trying to avoid in mesa? > IMHO we should try to pick up Thierry

...;No ASM for your platform, please send patches" > + inline_optimization="No in-line ASM for your platform, please send patches" "inline" is one word. > + AC_MSG_CHECKING(if compiler supports arm neon intrinsics) Capitalize ARM and NEON, please. > + save_CFLAGS="$CFLAGS"; CFLAGS="-mfpu=neon $CFLAGS" > + AC_COMPILE_IFELSE( Can we use AC_LINK_IFELSE? We had a problem where sometimes if SSE/AVX was not available, but the headers existed, the #include would succeed but no functions would get defined. My arm_neon.h seems to be w...

...-intrinsics.m4 b/m4/opus-intrinsics.m4 index b93ddd3..a262ca1 100644 --- a/m4/opus-intrinsics.m4 +++ b/m4/opus-intrinsics.m4 @@ -15,7 +15,7 @@ AC_DEFUN([OPUS_CHECK_INTRINSICS], $4=0 AC_MSG_RESULT([no]) AC_MSG_CHECKING([if compiler supports $1 intrinsics with $2]) - save_CFLAGS="$CFLAGS"; CFLAGS="$2 $CFLAGS" + save_CFLAGS="$CFLAGS"; CFLAGS="$CFLAGS $2" AC_LINK_IFELSE([AC_LANG_PROGRAM($5, $6)], [ AC_MSG_RESULT([yes]) -- 2.7.4 (Apple Git-66)

...ure.ac +++ b/configure.ac @@ -366,6 +366,26 @@ AC_ARG_WITH([kernel-source], [kernel_source="$with_kernel_source"]) AC_SUBST(kernel_source) +dnl Add flags for gcc and g++ +if test "x$GCC" = xyes; then + # Enable -fvisibility=hidden if using a gcc that supports it + save_CFLAGS="$CFLAGS" + AC_MSG_CHECKING([whether $CC supports -fvisibility=hidden]) + VISIBILITY_CFLAGS="-fvisibility=hidden" + CFLAGS="$CFLAGS $VISIBILITY_CFLAGS" + AC_LINK_IFELSE([AC_LANG_PROGRAM()], AC_MSG_RESULT([yes]), + [VISIBILITY_CFLAGS=&quot...

...source], >> [kernel_source="$with_kernel_source"]) >> AC_SUBST(kernel_source) >> >> +dnl Add flags for gcc and g++ >> +if test "x$GCC" = xyes; then >> + # Enable -fvisibility=hidden if using a gcc that supports it >> + save_CFLAGS="$CFLAGS" >> + AC_MSG_CHECKING([whether $CC supports -fvisibility=hidden]) >> + VISIBILITY_CFLAGS="-fvisibility=hidden" >> + CFLAGS="$CFLAGS $VISIBILITY_CFLAGS" >> + AC_LINK_IFELSE([AC_LANG_PROGRAM()], AC_MSG_RESULT([yes]), >>...

Hello, I received feedback from engineers working on NE10 [1] that it would be better to use NE10 [1] for FFT optimizations for opus use cases. However, these FFT patches are currently in review and haven't been integrated into NE10 yet. While the FFT functions in NE10 are getting baked, I wanted to optimize the celt_pitch_xcorr (floating point only) and use it to introduce ARM NEON

--- configure.ac | 30 +++++++++++++++++++++--------- 1 file changed, 21 insertions(+), 9 deletions(-) diff --git a/configure.ac b/configure.ac index a67aa37..c722556 100644 --- a/configure.ac +++ b/configure.ac @@ -472,6 +472,7 @@ AS_IF([test x"$enable_intrinsics" = x"yes"],[ [[ static float32x4_t A0, A1, SUMM; SUMM = vmlaq_f32(SUMM, A0,

hello guys first i would like to say that I'm very happy that there is true open source lossless audio compression software available from you guys. i'm contemplating archiving my cd collection and i would never even consider encoding important stuff with proprietary code. i might just as well throw my music away! flac's goals and features coincide with mine as a user, and it

...ARG_ENABLE([arm-neon-intrinsics], + AS_HELP_STRING([--enable-arm-neon-intrinsics], [Enable NEON optimisations on ARM CPUs that support it])) + + AS_IF([test x"$enable_arm_neon_intrinsics" = x"yes"], + [ + AC_MSG_CHECKING(if compiler supports arm neon intrinsics) + save_CFLAGS="$CFLAGS" + save_CFLAGS="$CFLAGS"; CFLAGS="-mfpu=neon $CFLAGS" + AC_COMPILE_IFELSE( + [AC_LANG_PROGRAM([[#include <arm_neon.h>]], [])], + [ + OPUS_ARM_NEON_INTR=1 + OPUS_ARM_NEON_INTR_CPPFLAGS="-mfpu=neon -O3" + AC_SUBST(OPUS_ARM_NEON...

> > > The functions themselves, as far as I can tell, only reference > > > data on the > > > stack as you say. It is the entry points which are not > > > position-independent (though they are relocatable). > > > > > > I confess to not quite being a wizard at this (yet), but as I > > > understand > > > it, shared library code

Hi, Optimizes celt_pitch_xcorr for floating point. Changes from RFCv1: - Rebased on top of commit aad281878: Fix celt_pitch_xcorr_c signature. which got rid of ugly code around CELT_PITCH_XCORR_IMPL passing of "arch" parameter. - Unified with --enable-intrinsics used by x86 - Modified algorithm to be more in-line with algorithm in celt_pitch_xcorr_arm.s Viswanath Puttagunta

...However, I really think this switch should be unified with the --enable-intrinsics switch currently used by x86. > + > + AS_IF([test x"$enable_arm_neon_intrinsics" = x"yes"], > + [ > + AC_MSG_CHECKING(if compiler supports arm neon intrinsics) > + save_CFLAGS="$CFLAGS" > + save_CFLAGS="$CFLAGS"; CFLAGS="-mfpu=neon $CFLAGS" > + AC_COMPILE_IFELSE( > + [AC_LANG_PROGRAM([[#include <arm_neon.h>]], [])], > + [ > + OPUS_ARM_NEON_INTR=1 > + OPUS_ARM_NEON_INTR_CPPFLAGS="-mfpu=neon -O3&qu...

...+AC_MSG_CHECKING(for NEON in current arch/CFLAGS) +AC_LINK_IFELSE([ +AC_LANG_PROGRAM([[ +#include <arm_neon.h> +int32x4_t testfunc(int16_t *a, int16_t *b) { + return vmull_s16(vld1_s16(a), vld1_s16(b)); +} +]])], +[ +has_neon=yes +], +[ +has_neon=no +] +) +AC_MSG_RESULT($has_neon) + SAVE_CFLAGS="$CFLAGS" CFLAGS="$CFLAGS -fvisibility=hidden" AC_MSG_CHECKING(for ELF visibility) @@ -148,6 +165,15 @@ has_sse=no fi ]) +AC_ARG_ENABLE(neon, [ --enable-neon Enable NEON support], [ +if test "x$enableval" != xno; then +has_neon=yes +CFLAGS="$CFLA...

...04 2007 +0100 make second and third arguments to AS_COMPILER_FLAG optional diff --git a/m4/as-compiler-flag.m4 b/m4/as-compiler-flag.m4 index f706196..76cf4cd 100644 --- a/m4/as-compiler-flag.m4 +++ b/m4/as-compiler-flag.m4 @@ -28,10 +28,10 @@ int main (int argc, char **argv) CFLAGS="$save_CFLAGS" if test "X$flag_ok" = Xyes ; then - $2 + m4_ifvaln([$2],[$2]) true else - $3 + m4_ifvaln([$3],[$3]) true fi AC_MSG_RESULT([$flag_ok])