search for: sanitize_features

Buggy host may advertised buggy host features (a usual case is that host advertise a feature whose dependencies were missed). In this case, driver should detect and disable the buggy features by itself. This patch introduces driver specific sanitize_features() method which is called just before features finalizing to detect and disable buggy features advertised by host. Virtio-net will be the first user. Cc: Rusty Russell <rusty at rustcorp.com.au> Cc: Michael S. Tsirkin <mst at redhat.com> Cc: Cornelia Huck <cornelia.huck at de.ibm.co...

Buggy host may advertised buggy host features (a usual case is that host advertise a feature whose dependencies were missed). In this case, driver should detect and disable the buggy features by itself. This patch introduces driver specific sanitize_features() method which is called just before features finalizing to detect and disable buggy features advertised by host. Virtio-net will be the first user. Cc: Rusty Russell <rusty at rustcorp.com.au> Cc: Michael S. Tsirkin <mst at redhat.com> Cc: Cornelia Huck <cornelia.huck at de.ibm.co...

...17:17PM +0800, Jason Wang wrote: > Buggy host may advertised buggy host features (a usual case is that host > advertise a feature whose dependencies were missed). In this case, driver > should detect and disable the buggy features by itself. > > This patch introduces driver specific sanitize_features() method which is > called just before features finalizing to detect and disable buggy features > advertised by host. > > Virtio-net will be the first user. > > Cc: Rusty Russell <rusty at rustcorp.com.au> > Cc: Michael S. Tsirkin <mst at redhat.com> > Cc: Corn...

This patch tries to detect the possible buggy features advertised by host and sanitize them. One example is booting virtio-net with only ctrl_vq disabled, qemu may still advertise many features which depends on it. This will trigger several BUG()s in virtnet_send_command(). This patch utilizes the sanitize_features() method, and disables all features that depends on ctrl_vq if it was not advertised. This fixes the crash when booting with ctrl_vq=off using qemu. Cc: Rusty Russell <rusty at rustcorp.com.au> Cc: Michael S. Tsirkin <mst at redhat.com> Cc: Cornelia Huck <cornelia.huck at de.ibm.co...

This patch tries to detect the possible buggy features advertised by host and sanitize them. One example is booting virtio-net with only ctrl_vq disabled, qemu may still advertise many features which depends on it. This will trigger several BUG()s in virtnet_send_command(). This patch utilizes the sanitize_features() method, and disables all features that depends on ctrl_vq if it was not advertised. This fixes the crash when booting with ctrl_vq=off using qemu. Cc: Rusty Russell <rusty at rustcorp.com.au> Cc: Michael S. Tsirkin <mst at redhat.com> Cc: Cornelia Huck <cornelia.huck at de.ibm.co...

...wrote: > > Buggy host may advertised buggy host features (a usual case is that host > > advertise a feature whose dependencies were missed). In this case, driver > > should detect and disable the buggy features by itself. > > > > This patch introduces driver specific sanitize_features() method which is > > called just before features finalizing to detect and disable buggy features > > advertised by host. > > > > Virtio-net will be the first user. > > > > Cc: Rusty Russell <rusty at rustcorp.com.au> > > Cc: Michael S. Tsirkin <...

...wrote: > > Buggy host may advertised buggy host features (a usual case is that host > > advertise a feature whose dependencies were missed). In this case, driver > > should detect and disable the buggy features by itself. > > > > This patch introduces driver specific sanitize_features() method which is > > called just before features finalizing to detect and disable buggy features > > advertised by host. > > > > Virtio-net will be the first user. > > > > Cc: Rusty Russell <rusty at rustcorp.com.au> > > Cc: Michael S. Tsirkin <...

...y features advertised by host >> and sanitize them. One example is booting virtio-net with only ctrl_vq >> disabled, qemu may still advertise many features which depends on it. This >> will trigger several BUG()s in virtnet_send_command(). >> >> This patch utilizes the sanitize_features() method, and disables all >> features that depends on ctrl_vq if it was not advertised. >> >> This fixes the crash when booting with ctrl_vq=off using qemu. >> >> Cc: Rusty Russell <rusty at rustcorp.com.au> >> Cc: Michael S. Tsirkin <mst at redhat.com&...

...y features advertised by host >> and sanitize them. One example is booting virtio-net with only ctrl_vq >> disabled, qemu may still advertise many features which depends on it. This >> will trigger several BUG()s in virtnet_send_command(). >> >> This patch utilizes the sanitize_features() method, and disables all >> features that depends on ctrl_vq if it was not advertised. >> >> This fixes the crash when booting with ctrl_vq=off using qemu. >> >> Cc: Rusty Russell <rusty at rustcorp.com.au> >> Cc: Michael S. Tsirkin <mst at redhat.com&...

...sed buggy host features (a usual case is that host > > > > advertise a feature whose dependencies were missed). In this case, driver > > > > should detect and disable the buggy features by itself. > > > > > > > > This patch introduces driver specific sanitize_features() method which is > > > > called just before features finalizing to detect and disable buggy features > > > > advertised by host. > > > > > > > > Virtio-net will be the first user. > > > > > > > > Cc: Rusty Russell <rusty...

...sed buggy host features (a usual case is that host > > > > advertise a feature whose dependencies were missed). In this case, driver > > > > should detect and disable the buggy features by itself. > > > > > > > > This patch introduces driver specific sanitize_features() method which is > > > > called just before features finalizing to detect and disable buggy features > > > > advertised by host. > > > > > > > > Virtio-net will be the first user. > > > > > > > > Cc: Rusty Russell <rusty...

...t may advertised buggy host features (a usual case is that host >>>> advertise a feature whose dependencies were missed). In this case, driver >>>> should detect and disable the buggy features by itself. >>>> >>>> This patch introduces driver specific sanitize_features() method which is >>>> called just before features finalizing to detect and disable buggy features >>>> advertised by host. >>>> >>>> Virtio-net will be the first user. >>>> >>>> Cc: Rusty Russell <rusty at rustcorp.com.au&g...

...t may advertised buggy host features (a usual case is that host >>>> advertise a feature whose dependencies were missed). In this case, driver >>>> should detect and disable the buggy features by itself. >>>> >>>> This patch introduces driver specific sanitize_features() method which is >>>> called just before features finalizing to detect and disable buggy features >>>> advertised by host. >>>> >>>> Virtio-net will be the first user. >>>> >>>> Cc: Rusty Russell <rusty at rustcorp.com.au&g...

...t the possible buggy features advertised by host > and sanitize them. One example is booting virtio-net with only ctrl_vq > disabled, qemu may still advertise many features which depends on it. This > will trigger several BUG()s in virtnet_send_command(). > > This patch utilizes the sanitize_features() method, and disables all > features that depends on ctrl_vq if it was not advertised. > > This fixes the crash when booting with ctrl_vq=off using qemu. > > Cc: Rusty Russell <rusty at rustcorp.com.au> > Cc: Michael S. Tsirkin <mst at redhat.com> > Cc: Cornelia...

...0 @@ static int virtio_dev_probe(struct device *_d) > if (device_features & (1 << i)) > set_bit(i, dev->features); > > + /* Fix buggy features advertised by host */ > + if (drv->fix_features) > + drv->fix_features(dev); I'd probably call this "sanitize_features" instead. > + > dev->config->finalize_features(dev); > > err = drv->probe(dev); > diff --git a/include/linux/virtio_config.h b/include/linux/virtio_config.h > index 7f4ef66..7bd89ea 100644 > --- a/include/linux/virtio_config.h > +++ b/include/linux/virti...

...ggy host may advertised buggy host features (a usual case is that host > > > advertise a feature whose dependencies were missed). In this case, driver > > > should detect and disable the buggy features by itself. > > > > > > This patch introduces driver specific sanitize_features() method which is > > > called just before features finalizing to detect and disable buggy features > > > advertised by host. > > > > > > Virtio-net will be the first user. > > > > > > Cc: Rusty Russell <rusty at rustcorp.com.au> > &g...

...res (a usual case is that host > > > > > advertise a feature whose dependencies were missed). In this case, driver > > > > > should detect and disable the buggy features by itself. > > > > > > > > > > This patch introduces driver specific sanitize_features() method which is > > > > > called just before features finalizing to detect and disable buggy features > > > > > advertised by host. > > > > > > > > > > Virtio-net will be the first user. > > > > > > > > > &gt...

...gy host features (a usual case is that host > >>>> advertise a feature whose dependencies were missed). In this case, driver > >>>> should detect and disable the buggy features by itself. > >>>> > >>>> This patch introduces driver specific sanitize_features() method which is > >>>> called just before features finalizing to detect and disable buggy features > >>>> advertised by host. > >>>> > >>>> Virtio-net will be the first user. > >>>> > >>>> Cc: Rusty Russell...

Buggy host may advertised buggy host features (a usual case is that host advertise a feature whose dependencies were missed). In this case, driver should detect and disable the buggy features by itself. This patch introduces driver specific fix_features() method which is called just before features finalizing to detect and disable buggy features advertised by host. Virtio-net will be the first

Buggy host may advertised buggy host features (a usual case is that host advertise a feature whose dependencies were missed). In this case, driver should detect and disable the buggy features by itself. This patch introduces driver specific fix_features() method which is called just before features finalizing to detect and disable buggy features advertised by host. Virtio-net will be the first