search for: samples_decoded

Hi, i'm using xmms-plugin from flac-0.9, i found following problems. Back-seeking cause, that .flac is not played all. It's caused by StreamDecoderPrivate variable samples_decoded and function stream_decoder_frame_sync_, which compare it against whole length of stream. I don't know what is meaning of this varible (samples decoded from last reset or for whole life of decoder). So i samples_decoded set to 0 in stream_decoder_reset. Against stream_decoder.c 205a206,207 &gt...

Thanks for the info, feedback below... --- Miroslav Lichvar <mirator@upcase.inf.upol.cz> wrote: > i'm using xmms-plugin from flac-0.9, i found following problems. > > Back-seeking cause, that .flac is not played all. It's caused by > StreamDecoderPrivate variable samples_decoded and function > stream_decoder_frame_sync_, which compare it against whole length of > stream. ok, I made the fix, plus there was another place that variable was being set incorrectly. both fixes are in CVS now. > Second problem: Visual plugins are slow. It's caused by > flac_ip.a...

...e == last_frame_sample && pos < last_pos) { - /* our last move backwards wasn't big enough, double it */ - pos -= (last_pos - pos); - needs_seek = true; + this_frame_sample = decoder->private_->last_frame.header.number.sample_number; + + if (!decoder->private_->samples_decoded || (this_frame_sample + decoder->private_->last_frame.header.blocksize >= upper_bound_sample && !first_seek)) { + if (pos == (FLAC__int64)lower_bound || !needs_seek) { + decoder->protected_->state = FLAC__STREAM_DECODER_SEEK_ERROR; + return false; } - else { -...

Ok, the patch from 2003 about improving seeking still didn't make it to CVS, so here is another try. I made some benchmarking with the test_seeking utility from flac sources to show how bad the current seeking is, especially without seektable. Track used for the experiment had about 50 minutes. In the following table is average number of seeks and number of decoded frames required for one