Displaying 5 results from an estimated 5 matches for "sampler2darray".
2013 Nov 29
1
texelFetch sampler1/2DArray on nv50 gallium
Hi Christoph/nouveau folks,
I've noticed that the piglit test "texelFetch" fails on my nv98 for
sampler1DArray and sampler2DArray. I nuked the logic in
nv50_ir_lowering_nv50.cpp:604 that does the f32 -> u32 conversion, and
it seems to be passing now. TBH, I have no clue how the parameters are
passed around and what that a[] is, but it seems like it's a u32 to
begin with? (Or that it's the same format that texfetch...
2015 Jan 11
2
[PATCH] nv50/ir: Handle OP_CVT when folding constant expressions
...or S32. That said, i
> kept the assert() there on purpose for now to actually make sure we are no
> hitting such a case. Do i misread you now? :)
>From my read of the code, we'd hit that case now with TXF on a
2D_ARRAY with a constant as the array element. i.e. a piglit with
uniform sampler2DArray foo;
texelFetch(foo, ivec3(1, 2, 3));
-ilia
2015 Jan 11
2
[PATCH] nv50/ir: Handle OP_CVT when folding constant expressions
...for now to actually make sure we are
>>> no
>>> hitting such a case. Do i misread you now? :)
>>
>> From my read of the code, we'd hit that case now with TXF on a
>> 2D_ARRAY with a constant as the array element. i.e. a piglit with
>>
>> uniform sampler2DArray foo;
>> texelFetch(foo, ivec3(1, 2, 3));
>
> Tested this (hope i did the right thing) and the assert did not get
> triggered, but i am still uncertain of this.
> -> move the assert into the F32 case for U32/S32 just to make sure...
> switch (i->sType)
> case TYPE_F32:...
2015 Jan 11
0
[PATCH] nv50/ir: Handle OP_CVT when folding constant expressions
...gt;> kept the assert() there on purpose for now to actually make sure we are no
>> hitting such a case. Do i misread you now? :)
> From my read of the code, we'd hit that case now with TXF on a
> 2D_ARRAY with a constant as the array element. i.e. a piglit with
>
> uniform sampler2DArray foo;
> texelFetch(foo, ivec3(1, 2, 3));
Tested this (hope i did the right thing) and the assert did not get
triggered, but i am still uncertain of this.
-> move the assert into the F32 case for U32/S32 just to make sure...
switch (i->sType)
case TYPE_F32:
assert(...)
...
other than t...
2015 Jan 11
2
[PATCH] nv50/ir: Handle OP_CVT when folding constant expressions
On Sun, Jan 11, 2015 at 4:40 PM, Tobias Klausmann
<tobias.johannes.klausmann at mni.thm.de> wrote:
> Folding for conversions: F32->(U{16/32}, S{16/32}) and (U{16/32}, {S16/32})->F32
>
> Signed-off-by: Tobias Klausmann <tobias.johannes.klausmann at mni.thm.de>
> ---
> V2: Split out F64 parts
> V3: remove handling of saturate for (U/S)32,
>
>