search for: samitolvanen

...to be explicitly specified: > > <inline asm>:1:7: error: invalid operand for instruction > inl (%dx) > ^ > LLVM ERROR: Error parsing inline asm > > Use the full form of the instruction to fix the build. > > Signed-off-by: Sami Tolvanen <samitolvanen at google.com> Acked-by: Thomas Hellstrom <thellstrom at vmware.com> > --- > arch/x86/kernel/cpu/vmware.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/x86/kernel/cpu/vmware.c b/arch/x86/kernel/cpu/vmware.c > index 9735139cfdf8..46d73269...

...to be explicitly specified: > > <inline asm>:1:7: error: invalid operand for instruction > inl (%dx) > ^ > LLVM ERROR: Error parsing inline asm > > Use the full form of the instruction to fix the build. > > Signed-off-by: Sami Tolvanen <samitolvanen at google.com> Thanks Sami, this looks like it addresses: Link: https://github.com/ClangBuiltLinux/linux/issues/734 Looks like GAS' testsuite has some cases where the second operand is indeed implicitly %eax if unspecified. (This should still be fixed in Clang). Just to triple check that th...

...be explicitly specified: > > <inline asm>:1:7: error: invalid operand for instruction > inl (%dx) > ^ > LLVM ERROR: Error parsing inline asm > > Use the full form of the instruction to fix the build. > > Signed-off-by: Sami Tolvanen <samitolvanen at google.com> Reviewed-by: Kees Cook <keescook at chromium.org> -Kees > --- > arch/x86/kernel/cpu/vmware.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/x86/kernel/cpu/vmware.c b/arch/x86/kernel/cpu/vmware.c > index 9735139cfdf8..46d7...

...ng happening at build time, and perhaps even prevent it with compiler options or annotations, but none of that is close to being available and I'm keen to progress the LTO patches in the meantime because they are a requirement for CFI. Will [1] https://lore.kernel.org/r/20200624203200.78870-1-samitolvanen at google.com

...he patches with his Ack have not changed materially in my opinion. I will drop them if anybody objects. In terms of merging this, my preference would be a stable branch in the arm64 tree, which others can pull in as they need it. Cheers, Will [1] https://lore.kernel.org/r/20200624203200.78870-1-samitolvanen at google.com Cc: Sami Tolvanen <samitolvanen at google.com> Cc: Nick Desaulniers <ndesaulniers at google.com> Cc: Kees Cook <keescook at chromium.org> Cc: Marco Elver <elver at google.com> Cc: "Paul E. McKenney" <paulmck at kernel.org> Cc: Josh Triplett &lt...

...he patches with his Ack have not changed materially in my opinion. I will drop them if anybody objects. In terms of merging this, my preference would be a stable branch in the arm64 tree, which others can pull in as they need it. Cheers, Will [1] https://lore.kernel.org/r/20200624203200.78870-1-samitolvanen at google.com Cc: Sami Tolvanen <samitolvanen at google.com> Cc: Nick Desaulniers <ndesaulniers at google.com> Cc: Kees Cook <keescook at chromium.org> Cc: Marco Elver <elver at google.com> Cc: "Paul E. McKenney" <paulmck at kernel.org> Cc: Josh Triplett &lt...

...lnoconfig, defconfig and allmodcofig - alpha defconfig, defconfig+CONFIG_SMP=y - riscv64 defconfig - powerpc64 defconfig - s390 defconfig - sparc32 defconfig, defconfig+CONFIG_SMP=y - sparc64 defconfig Cheers, Will Cc: Joel Fernandes <joelaf at google.com> Cc: Sami Tolvanen <samitolvanen at google.com> Cc: Nick Desaulniers <ndesaulniers at google.com> Cc: Kees Cook <keescook at chromium.org> Cc: Marco Elver <elver at google.com> Cc: "Paul E. McKenney" <paulmck at kernel.org> Cc: Matt Turner <mattst88 at gmail.com> Cc: Ivan Kokshaysky <i...