search for: sameid

...e "replace" error handler: https://docs.python.org/3/library/codecs.html#error-handlers For example, this will decode PackageKit's description on SLES4 the following way: Backend: pisi S.�a&#287;lar Onur <caglar@pardus.org.tr> Signed-off-by: Sam Eiderman <sameid@google.com> --- python/handle.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/python/handle.c b/python/handle.c index 2fb8c18f0..427424707 100644 --- a/python/handle.c +++ b/python/handle.c @@ -387,7 +387,7 @@ guestfs_int_py_fromstring (const char *str) #if PY_MAJOR_V...

...in1"]: try: return decode(b, codec) except: pass return decode(b, "utf8", errors="replace") (Pseudocode, will be implemented in c) On Thu, Apr 23, 2020, 21:34 Nir Soffer <nsoffer@redhat.com> wrote: > On Mon, Apr 20, 2020 at 3:38 PM Sam Eiderman <sameid@google.com> wrote: > > > > The python3 bindings create unicode objects from application strings > > on the guest (i.e. installed rpm, deb packages). > > It is documented that rpm package fields such as description should be > > utf8 encoded - however in some cases t...

...dows fses) we change the > > iteration order of the disks. > > This causes inspect_os() to fail since Parted returns a Unix_error if > > the device does not contain any partitions - fix this by handling this > > Unix_error. > > > > Signed-off-by: Sam Eiderman <sameid@google.com> > > --- > > daemon/inspect_fs_windows.ml | 11 ++++++++--- > > 1 file changed, 8 insertions(+), 3 deletions(-) > > > > diff --git a/daemon/inspect_fs_windows.ml b/daemon/inspect_fs_windows.ml > > index c4a05bc38..bc6b98b60 100644 > > --- a/d...

...omstringsize() to fallback to latin1 decoding if utf-8 decoding fails. Using the "strict" error handler doesn't matter in the case of latin1 and has the same effect of "replace": https://docs.python.org/3/library/codecs.html#error-handlers Signed-off-by: Sam Eiderman <sameid@google.com> --- python/handle.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/python/handle.c b/python/handle.c index 2fb8c18f0..fe89dc58a 100644 --- a/python/handle.c +++ b/python/handle.c @@ -387,7 +387,7 @@ guestfs_int_py_fromstring (const char *str) #if PY_MA...

...sk of the vm (i.e. /dev/sda, /dev/sdb{1,2} contains the windows fses) we change the iteration order of the disks. This causes inspect_os() to fail since Parted returns a Unix_error if the device does not contain any partitions - fix this by handling this Unix_error. Signed-off-by: Sam Eiderman <sameid@google.com> --- daemon/inspect_fs_windows.ml | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/daemon/inspect_fs_windows.ml b/daemon/inspect_fs_windows.ml index c4a05bc38..bc6b98b60 100644 --- a/daemon/inspect_fs_windows.ml +++ b/daemon/inspect_fs_windows.ml @@ -36...

...ors3 libtelepathy-glib0 m4 opensc opensc-32bit permissions pinentry poppler-tools python-gtksourceview splashy syslog-ng tar tightvnc xorg-x11 xorg-x11-xauth yast2-mouse This is a surgical fix for inspect_list_applications2()'s description field. Signed-off-by: Sam Eiderman <sameid@google.com> --- generator/python.ml | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/generator/python.ml b/generator/python.ml index f0d6b5d96..7394a943a 100644 --- a/generator/python.ml +++ b/generator/python.ml @@ -170,6 +170,14 @@ and generate_python_structs () = function...

...ls. > > > > Using the "strict" error handler doesn't matter in the case of latin1 > > and has the same effect of "replace": > > > > https://docs.python.org/3/library/codecs.html#error-handlers > > > > Signed-off-by: Sam Eiderman <sameid@google.com> > > --- > > python/handle.c | 9 +++++++-- > > 1 file changed, 7 insertions(+), 2 deletions(-) > > > > diff --git a/python/handle.c b/python/handle.c > > index 2fb8c18f0..fe89dc58a 100644 > > --- a/python/handle.c > > +++ b/python/hand...

On Mon, Apr 20, 2020 at 3:38 PM Sam Eiderman <sameid@google.com> wrote: > > The python3 bindings create unicode objects from application strings > on the guest (i.e. installed rpm, deb packages). > It is documented that rpm package fields such as description should be > utf8 encoded - however in some cases they are not a valid unico...

gentle ping On Wed, Jun 3, 2020 at 2:52 PM Sam Eiderman <sameid@google.com> wrote: > On Wed, May 13, 2020 at 10:06 PM Richard W.M. Jones <rjones@redhat.com> > wrote: > > > > On Sun, Apr 26, 2020 at 09:14:03PM +0300, Sam Eiderman wrote: > > > The python3 bindings create PyUnicode objects from application strings > > &gt...

Since support for python2 is dropped we can use the new python3 syntax for type hints. Signed-off-by: Sam Eiderman <sameid@google.com> --- generator/python.ml | 39 +++++++++++++++++++++++++++++++++++---- 1 file changed, 35 insertions(+), 4 deletions(-) diff --git a/generator/python.ml b/generator/python.ml index f0d6b5d96..3640ee39a 100644 --- a/generator/python.ml +++ b/generator/python.ml @@ -685,6 +685,7 @@ lo...

Hello all, Definitely congrats on the 1.0.0 release! Anyway, I'm having a problem, that may or may not be related to Dovecot. Specifically, duplicate (and sometimes triplicate) emails are appearing. These emails have exactly the same queue ID, so its not that they were sent multiple times. These dup emails do not show up to me ever. Postfix is being used as the SMTP, and it hands it

All Py_* functions should be protected by the GIL. Otherwise internal python data structures can get corrupted. Move PyGILState_Ensure to the beginning of the block and PyGILState_Release to the bottom. Signed-off-by: Sam Eiderman <sameid@google.com> --- python/handle.c | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/python/handle.c b/python/handle.c index ffd0794d8..659bb5b06 100644 --- a/python/handle.c +++ b/python/handle.c @@ -112,13 +112,17 @@ guestfs_int_py_event_callback_wrapper (guestf...

...ors3 libtelepathy-glib0 m4 opensc opensc-32bit permissions pinentry poppler-tools python-gtksourceview splashy syslog-ng tar tightvnc xorg-x11 xorg-x11-xauth yast2-mouse This is a surgical fix for inspect_list_applications2()'s description field. Signed-off-by: Sam Eiderman <sameid@google.com> --- generator/python.ml | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/generator/python.ml b/generator/python.ml index f0d6b5d96..7394a943a 100644 --- a/generator/python.ml +++ b/generator/python.ml @@ -170,6 +170,14 @@ and generate_python_structs () = function...

...try > poppler-tools > python-gtksourceview > splashy > syslog-ng > tar > tightvnc > xorg-x11 > xorg-x11-xauth > yast2-mouse > > This is a surgical fix for inspect_list_applications2()'s description > field. > > Signed-off-by: Sam Eiderman <sameid@google.com> > --- > generator/python.ml | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/generator/python.ml b/generator/python.ml > index f0d6b5d96..7394a943a 100644 > --- a/generator/python.ml > +++ b/generator/python.ml > @@ -170,6 +170,14 @@ and g...

...ttps://docs.python.org/3/library/codecs.html#error-handlers > > For example, this will decode PackageKit's description on SLES4 the > following way: > > Backend: pisi > S.�a&#287;lar Onur <caglar@pardus.org.tr> > > Signed-off-by: Sam Eiderman <sameid@google.com> > --- > python/handle.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/python/handle.c b/python/handle.c > index 2fb8c18f0..427424707 100644 > --- a/python/handle.c > +++ b/python/handle.c > @@ -387,7 +387,7 @@ guestfs_int_py...

...oding if > utf-8 decoding fails. > > Using the "strict" error handler doesn't matter in the case of latin1 > and has the same effect of "replace": > > https://docs.python.org/3/library/codecs.html#error-handlers > > Signed-off-by: Sam Eiderman <sameid@google.com> > --- > python/handle.c | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/python/handle.c b/python/handle.c > index 2fb8c18f0..fe89dc58a 100644 > --- a/python/handle.c > +++ b/python/handle.c > @@ -387,7 +387,7 @@ guestfs_i...

...dev/sdb{1,2} contains the windows fses) we change the > iteration order of the disks. > This causes inspect_os() to fail since Parted returns a Unix_error if > the device does not contain any partitions - fix this by handling this > Unix_error. > > Signed-off-by: Sam Eiderman <sameid@google.com> > --- > daemon/inspect_fs_windows.ml | 11 ++++++++--- > 1 file changed, 8 insertions(+), 3 deletions(-) > > diff --git a/daemon/inspect_fs_windows.ml b/daemon/inspect_fs_windows.ml > index c4a05bc38..bc6b98b60 100644 > --- a/daemon/inspect_fs_windows.ml > +...

...n3 syntax > for type hints. Interesting - didn't know about this. I have pushed this, and another patch to update the published minimum version of Python to 3.6. I don't test anything earlier, although in theory it could work for 3.5 still. Rich. > Signed-off-by: Sam Eiderman <sameid@google.com> > --- > generator/python.ml | 39 +++++++++++++++++++++++++++++++++++---- > 1 file changed, 35 insertions(+), 4 deletions(-) > > diff --git a/generator/python.ml b/generator/python.ml > index f0d6b5d96..3640ee39a 100644 > --- a/generator/python.ml > +++ b/ge...

I see, thanks for the clarification. On Thu, Aug 27, 2020 at 12:05 PM Richard W.M. Jones <rjones@redhat.com> wrote: > > On Thu, Aug 27, 2020 at 11:24:57AM +0300, Sam Eiderman wrote: > > Yes, I understand that, I am just surprised to know that we bind /sys > > for g.sh() commands. > > > > However, "g.command([self.mkconfig, '-o', self.config])"

Hey Pino, Can you search for the previous patches I submitted? I had some discussions regarding this with Daniel and Nir. Thanks! On Tue, Jun 30, 2020 at 11:43 AM Pino Toscano <ptoscano@redhat.com> wrote: > On Sunday, 26 April 2020 20:14:03 CEST Sam Eiderman wrote: > > The python3 bindings create PyUnicode objects from application strings > > on the guest (i.e. installed