search for: rx_length_errors

...;> + { "tx_packets", VIRTNET_NETDEV_STAT(tx_packets) }, >> + { "rx_bytes", VIRTNET_NETDEV_STAT(rx_bytes) }, >> + { "tx_bytes", VIRTNET_NETDEV_STAT(tx_bytes) }, >> + { "rx_dropped", VIRTNET_NETDEV_STAT(rx_dropped) }, >> + { "rx_length_errors", VIRTNET_NETDEV_STAT(rx_length_errors) }, >> + { "rx_frame_errors", VIRTNET_NETDEV_STAT(rx_frame_errors) }, >> + { "tx_dropped", VIRTNET_NETDEV_STAT(tx_dropped) }, >> + { "tx_fifo_errors", VIRTNET_NETDEV_STAT(tx_fifo_errors) }, >> +}; &gt...

...;> + { "tx_packets", VIRTNET_NETDEV_STAT(tx_packets) }, >> + { "rx_bytes", VIRTNET_NETDEV_STAT(rx_bytes) }, >> + { "tx_bytes", VIRTNET_NETDEV_STAT(tx_bytes) }, >> + { "rx_dropped", VIRTNET_NETDEV_STAT(rx_dropped) }, >> + { "rx_length_errors", VIRTNET_NETDEV_STAT(rx_length_errors) }, >> + { "rx_frame_errors", VIRTNET_NETDEV_STAT(rx_frame_errors) }, >> + { "tx_dropped", VIRTNET_NETDEV_STAT(tx_dropped) }, >> + { "tx_fifo_errors", VIRTNET_NETDEV_STAT(tx_fifo_errors) }, >> +}; &gt...

...rpose of this patch is adding a way of checking per-queue stats. It's useful to debug performance problems on multiqueue environment. $ ethtool -S ens10 NIC statistics: rx_packets: 4172939 tx_packets: 5855538 rx_bytes: 6317757408 tx_bytes: 8865151846 rx_dropped: 0 rx_length_errors: 0 rx_frame_errors: 0 tx_dropped: 0 tx_fifo_errors: 0 rx_queue_0_packets: 2090408 rx_queue_0_bytes: 3164825094 rx_queue_1_packets: 2082531 rx_queue_1_bytes: 3152932314 tx_queue_0_packets: 2770841 tx_queue_0_bytes: 4194955474 tx_queue_1_packets: 3084...

...rpose of this patch is adding a way of checking per-queue stats. It's useful to debug performance problems on multiqueue environment. $ ethtool -S ens10 NIC statistics: rx_packets: 4172939 tx_packets: 5855538 rx_bytes: 6317757408 tx_bytes: 8865151846 rx_dropped: 0 rx_length_errors: 0 rx_frame_errors: 0 tx_dropped: 0 tx_fifo_errors: 0 rx_queue_0_packets: 2090408 rx_queue_0_bytes: 3164825094 rx_queue_1_packets: 2082531 rx_queue_1_bytes: 3152932314 tx_queue_0_packets: 2770841 tx_queue_0_bytes: 4194955474 tx_queue_1_packets: 3084...

...(shake it! shake it!) */ bool mergeable_rx_bufs; + /* Active statistics */ + struct virtnet_stats __percpu *stats; + /* Work struct for refilling if we run low on memory. */ struct delayed_work refill; @@ -209,7 +221,6 @@ static int receive_mergeable(struct virt skb->dev->stats.rx_length_errors++; return -EINVAL; } - page = virtqueue_get_buf(vi->rvq, &len); if (!page) { pr_debug("%s: rx error: %d buffers missing\n", @@ -217,6 +228,7 @@ static int receive_mergeable(struct virt skb->dev->stats.rx_length_errors++; return -EINVAL; } + if (...

...(shake it! shake it!) */ bool mergeable_rx_bufs; + /* Active statistics */ + struct virtnet_stats __percpu *stats; + /* Work struct for refilling if we run low on memory. */ struct delayed_work refill; @@ -209,7 +221,6 @@ static int receive_mergeable(struct virt skb->dev->stats.rx_length_errors++; return -EINVAL; } - page = virtqueue_get_buf(vi->rvq, &len); if (!page) { pr_debug("%s: rx error: %d buffers missing\n", @@ -217,6 +228,7 @@ static int receive_mergeable(struct virt skb->dev->stats.rx_length_errors++; return -EINVAL; } + if (...

...T(rx_packets) }, > + { "tx_packets", VIRTNET_NETDEV_STAT(tx_packets) }, > + { "rx_bytes", VIRTNET_NETDEV_STAT(rx_bytes) }, > + { "tx_bytes", VIRTNET_NETDEV_STAT(tx_bytes) }, > + { "rx_dropped", VIRTNET_NETDEV_STAT(rx_dropped) }, > + { "rx_length_errors", VIRTNET_NETDEV_STAT(rx_length_errors) }, > + { "rx_frame_errors", VIRTNET_NETDEV_STAT(rx_frame_errors) }, > + { "tx_dropped", VIRTNET_NETDEV_STAT(tx_dropped) }, > + { "tx_fifo_errors", VIRTNET_NETDEV_STAT(tx_fifo_errors) }, > +}; > + Please do n...

..., VIRTNET_NETDEV_STAT(tx_packets) }, >>>> + { "rx_bytes", VIRTNET_NETDEV_STAT(rx_bytes) }, >>>> + { "tx_bytes", VIRTNET_NETDEV_STAT(tx_bytes) }, >>>> + { "rx_dropped", VIRTNET_NETDEV_STAT(rx_dropped) }, >>>> + { "rx_length_errors", VIRTNET_NETDEV_STAT(rx_length_errors) }, >>>> + { "rx_frame_errors", VIRTNET_NETDEV_STAT(rx_frame_errors) }, >>>> + { "tx_dropped", VIRTNET_NETDEV_STAT(tx_dropped) }, >>>> + { "tx_fifo_errors", VIRTNET_NETDEV_STAT(tx_fifo_err...

...tx_packets", VIRTNET_NETDEV_STAT(tx_packets) }, >>> + { "rx_bytes", VIRTNET_NETDEV_STAT(rx_bytes) }, >>> + { "tx_bytes", VIRTNET_NETDEV_STAT(tx_bytes) }, >>> + { "rx_dropped", VIRTNET_NETDEV_STAT(rx_dropped) }, >>> + { "rx_length_errors", VIRTNET_NETDEV_STAT(rx_length_errors) }, >>> + { "rx_frame_errors", VIRTNET_NETDEV_STAT(rx_frame_errors) }, >>> + { "tx_dropped", VIRTNET_NETDEV_STAT(tx_dropped) }, >>> + { "tx_fifo_errors", VIRTNET_NETDEV_STAT(tx_fifo_errors) }, >...

...: rx_packets: 6071960 tx_packets: 6189424 rx_bytes: 1244435132 tx_bytes: 2117335817 rx_broadcast: 293751 tx_broadcast: 193 rx_multicast: 29827 tx_multicast: 0 rx_errors: 0 tx_errors: 0 tx_dropped: 0 multicast: 29827 collisions: 0 rx_length_errors: 0 rx_over_errors: 0 rx_crc_errors: 0 rx_frame_errors: 0 rx_no_buffer_count: 0 rx_missed_errors: 0 tx_aborted_errors: 0 tx_carrier_errors: 0 tx_fifo_errors: 0 tx_heartbeat_errors: 0 tx_window_errors: 0 tx_abort_late_coll: 0 tx_deferred_ok:...

...*dev, struct rtnl_link_stats64 *tot) { struct virtnet_info *vi = netdev_priv(dev); + struct virtnet_vf_pcpu_stats vf_stats; int cpu; unsigned int start; @@ -1490,6 +1574,13 @@ static void virtnet_stats(struct net_device *dev, tot->rx_dropped = dev->stats.rx_dropped; tot->rx_length_errors = dev->stats.rx_length_errors; tot->rx_frame_errors = dev->stats.rx_frame_errors; + + virtnet_get_vf_stats(dev, &vf_stats); + tot->rx_packets += vf_stats.rx_packets; + tot->tx_packets += vf_stats.tx_packets; + tot->rx_bytes += vf_stats.rx_bytes; + tot->tx_bytes += vf_stat...

...*dev, struct rtnl_link_stats64 *tot) { struct virtnet_info *vi = netdev_priv(dev); + struct virtnet_vf_pcpu_stats vf_stats; int cpu; unsigned int start; @@ -1490,6 +1574,13 @@ static void virtnet_stats(struct net_device *dev, tot->rx_dropped = dev->stats.rx_dropped; tot->rx_length_errors = dev->stats.rx_length_errors; tot->rx_frame_errors = dev->stats.rx_frame_errors; + + virtnet_get_vf_stats(dev, &vf_stats); + tot->rx_packets += vf_stats.rx_packets; + tot->tx_packets += vf_stats.tx_packets; + tot->rx_bytes += vf_stats.rx_bytes; + tot->tx_bytes += vf_stat...

...*dev, struct rtnl_link_stats64 *tot) { struct virtnet_info *vi = netdev_priv(dev); + struct virtnet_vf_pcpu_stats vf_stats; int cpu; unsigned int start; @@ -1504,6 +1587,13 @@ static void virtnet_stats(struct net_device *dev, tot->rx_dropped = dev->stats.rx_dropped; tot->rx_length_errors = dev->stats.rx_length_errors; tot->rx_frame_errors = dev->stats.rx_frame_errors; + + virtnet_get_vf_stats(dev, &vf_stats); + tot->rx_packets += vf_stats.rx_packets; + tot->tx_packets += vf_stats.tx_packets; + tot->rx_bytes += vf_stats.rx_bytes; + tot->tx_bytes += vf_stat...

...ue stats. > It's useful to debug performance problems on multiqueue environment. > > $ ethtool -S ens10 > NIC statistics: > rx_packets: 4172939 > tx_packets: 5855538 > rx_bytes: 6317757408 > tx_bytes: 8865151846 > rx_dropped: 0 > rx_length_errors: 0 > rx_frame_errors: 0 > tx_dropped: 0 > tx_fifo_errors: 0 > rx_queue_0_packets: 2090408 > rx_queue_0_bytes: 3164825094 > rx_queue_1_packets: 2082531 > rx_queue_1_bytes: 3152932314 > tx_queue_0_packets: 2770841 > tx_q...

...t; { > struct virtnet_info *vi = netdev_priv(dev); > + struct virtnet_vf_pcpu_stats vf_stats; > int cpu; > unsigned int start; > > @@ -1490,6 +1574,13 @@ static void virtnet_stats(struct net_device *dev, > tot->rx_dropped = dev->stats.rx_dropped; > tot->rx_length_errors = dev->stats.rx_length_errors; > tot->rx_frame_errors = dev->stats.rx_frame_errors; > + > + virtnet_get_vf_stats(dev, &vf_stats); > + tot->rx_packets += vf_stats.rx_packets; > + tot->tx_packets += vf_stats.tx_packets; > + tot->rx_bytes += vf_stats.rx_bytes;...

...4_get_port_stats_offset(adapter, p->tx_chan, &stats, &p->stats_base); @@ -2417,7 +2417,6 @@ static struct rtnl_link_stats64 *cxgb_get_stats(struct net_device *dev, ns->tx_errors = stats.tx_error_frames; ns->rx_errors = stats.rx_symbol_err + stats.rx_fcs_err + ns->rx_length_errors + stats.rx_len_err + ns->rx_fifo_errors; - return ns; } static int cxgb_ioctl(struct net_device *dev, struct ifreq *req, int cmd) diff --git a/drivers/net/ethernet/cisco/enic/enic_main.c b/drivers/net/ethernet/cisco/enic/enic_main.c index cdd7a1a59aa7..c5842c525eed 100644 --- a/drivers/net/e...

...4_get_port_stats_offset(adapter, p->tx_chan, &stats, &p->stats_base); @@ -2417,7 +2417,6 @@ static struct rtnl_link_stats64 *cxgb_get_stats(struct net_device *dev, ns->tx_errors = stats.tx_error_frames; ns->rx_errors = stats.rx_symbol_err + stats.rx_fcs_err + ns->rx_length_errors + stats.rx_len_err + ns->rx_fifo_errors; - return ns; } static int cxgb_ioctl(struct net_device *dev, struct ifreq *req, int cmd) diff --git a/drivers/net/ethernet/cisco/enic/enic_main.c b/drivers/net/ethernet/cisco/enic/enic_main.c index cdd7a1a59aa7..c5842c525eed 100644 --- a/drivers/net/e...

This patch series extends virtio_net to take over VF datapath by simulating a transparent bond without creating any additional netdev. I understand that there are some comments suggesting an alternate model that is based on 3 driver model(virtio_net, VF driver, a new driver virt_bond that acts as a master to virtio_net and VF). Would like to get some feedback on the right way to solve the live

...->nr_frags; > + int num_skb_frags; > + > buf = virtqueue_get_buf(rq->vq, &len); > if (unlikely(!buf)) { > - pr_debug("%s: rx error: %d buffers missing\n", > - head_skb->dev->name, hdr->mhdr.num_buffers); > - head_skb->dev->stats.rx_length_errors++; > - return -EINVAL; > + pr_debug("%s: rx error: %d buffers out of %d missing\n", > + dev->name, num_buf, hdr->mhdr.num_buffers); > + dev->stats.rx_length_errors++; > + goto err_buf; Not sure it's correct here. Since the we break immediately if b...

This patch series enables virtio to switch over to a VF datapath when a VF netdev is present with the same MAC address. It allows live migration of a VM with a direct attached VF without the need to setup a bond/team between a VF and virtio net device in the guest. The hypervisor needs to unplug the VF device from the guest on the source host and reset the MAC filter of the VF to initiate