search for: rx_format

On 2017?01?21? 00:45, Michael S. Tsirkin wrote: > On Fri, Jan 20, 2017 at 02:32:42PM +0800, Jason Wang wrote: >> Commit 501db511397f ("virtio: don't set VIRTIO_NET_HDR_F_DATA_VALID on >> xmit") in fact disables VIRTIO_HDR_F_DATA_VALID on receiving path too, >> fixing this by adding a hint (has_data_valid) and set it only on the >> receiving path. >>

On 2017?01?21? 00:45, Michael S. Tsirkin wrote: > On Fri, Jan 20, 2017 at 02:32:42PM +0800, Jason Wang wrote: >> Commit 501db511397f ("virtio: don't set VIRTIO_NET_HDR_F_DATA_VALID on >> xmit") in fact disables VIRTIO_HDR_F_DATA_VALID on receiving path too, >> fixing this by adding a hint (has_data_valid) and set it only on the >> receiving path. >>

...we are trying to fix > > here is that tx and tx headers are slightly different. > > > > Actually, I've considered something like this, but the problem is: > > - tun use this on xmit, so is_rx = true may cause some confusion here tun is generally weird, yes. how about rx_format? > - I believe we may want to support DATA_VALID (like xen-netback) on tx > (probably with a feature) in the future. > > Thanks We'll put that knowledge within virtio_net_hdr_from_skb not in the callers I think. -- MST