search for: rx_dropped

...;> + { "rx_packets", VIRTNET_NETDEV_STAT(rx_packets) }, >> + { "tx_packets", VIRTNET_NETDEV_STAT(tx_packets) }, >> + { "rx_bytes", VIRTNET_NETDEV_STAT(rx_bytes) }, >> + { "tx_bytes", VIRTNET_NETDEV_STAT(tx_bytes) }, >> + { "rx_dropped", VIRTNET_NETDEV_STAT(rx_dropped) }, >> + { "rx_length_errors", VIRTNET_NETDEV_STAT(rx_length_errors) }, >> + { "rx_frame_errors", VIRTNET_NETDEV_STAT(rx_frame_errors) }, >> + { "tx_dropped", VIRTNET_NETDEV_STAT(tx_dropped) }, >> + { &quo...

...;> + { "rx_packets", VIRTNET_NETDEV_STAT(rx_packets) }, >> + { "tx_packets", VIRTNET_NETDEV_STAT(tx_packets) }, >> + { "rx_bytes", VIRTNET_NETDEV_STAT(rx_bytes) }, >> + { "tx_bytes", VIRTNET_NETDEV_STAT(tx_bytes) }, >> + { "rx_dropped", VIRTNET_NETDEV_STAT(rx_dropped) }, >> + { "rx_length_errors", VIRTNET_NETDEV_STAT(rx_length_errors) }, >> + { "rx_frame_errors", VIRTNET_NETDEV_STAT(rx_frame_errors) }, >> + { "tx_dropped", VIRTNET_NETDEV_STAT(tx_dropped) }, >> + { &quo...

The main purpose of this patch is adding a way of checking per-queue stats. It's useful to debug performance problems on multiqueue environment. $ ethtool -S ens10 NIC statistics: rx_packets: 4172939 tx_packets: 5855538 rx_bytes: 6317757408 tx_bytes: 8865151846 rx_dropped: 0 rx_length_errors: 0 rx_frame_errors: 0 tx_dropped: 0 tx_fifo_errors: 0 rx_queue_0_packets: 2090408 rx_queue_0_bytes: 3164825094 rx_queue_1_packets: 2082531 rx_queue_1_bytes: 3152932314 tx_queue_0_packets: 2770841 tx_queue_0_bytes: 4194955474...

The main purpose of this patch is adding a way of checking per-queue stats. It's useful to debug performance problems on multiqueue environment. $ ethtool -S ens10 NIC statistics: rx_packets: 4172939 tx_packets: 5855538 rx_bytes: 6317757408 tx_bytes: 8865151846 rx_dropped: 0 rx_length_errors: 0 rx_frame_errors: 0 tx_dropped: 0 tx_fifo_errors: 0 rx_queue_0_packets: 2090408 rx_queue_0_bytes: 3164825094 rx_queue_1_packets: 2082531 rx_queue_1_bytes: 3152932314 tx_queue_0_packets: 2770841 tx_queue_0_bytes: 4194955474...

...->tx.tx_frames_ok; net_stats->tx_bytes = stats->tx.tx_bytes_ok; @@ -707,8 +707,6 @@ static struct rtnl_link_stats64 *enic_get_stats(struct net_device *netdev, net_stats->rx_over_errors = enic->rq_truncated_pkts; net_stats->rx_crc_errors = enic->rq_bad_fcs; net_stats->rx_dropped = stats->rx.rx_no_bufs + stats->rx.rx_drop; - - return net_stats; } static int enic_mc_sync(struct net_device *netdev, const u8 *mc_addr) diff --git a/drivers/net/ethernet/ec_bhf.c b/drivers/net/ethernet/ec_bhf.c index 7bf78a0d322c..278f139f2a22 100644 --- a/drivers/net/ethernet/ec_bhf.c...

...->tx.tx_frames_ok; net_stats->tx_bytes = stats->tx.tx_bytes_ok; @@ -707,8 +707,6 @@ static struct rtnl_link_stats64 *enic_get_stats(struct net_device *netdev, net_stats->rx_over_errors = enic->rq_truncated_pkts; net_stats->rx_crc_errors = enic->rq_bad_fcs; net_stats->rx_dropped = stats->rx.rx_no_bufs + stats->rx.rx_drop; - - return net_stats; } static int enic_mc_sync(struct net_device *netdev, const u8 *mc_addr) diff --git a/drivers/net/ethernet/ec_bhf.c b/drivers/net/ethernet/ec_bhf.c index 7bf78a0d322c..278f139f2a22 100644 --- a/drivers/net/ethernet/ec_bhf.c...

...; > err_xdp: > + alloc_frag->offset -= buflen; > + put_page(alloc_frag->page); > +out: Out here isn't an error at all, is it? You should not mix return and error handling IMHO. > rcu_read_unlock(); > local_bh_enable(); > - this_cpu_inc(tun->pcpu_stats->rx_dropped); Doesn't this break rx_dropped accounting? > - return NULL; > + return skb; > } > > /* Get packet from user space buffer */ > -- > 2.17.1

...; > err_xdp: > + alloc_frag->offset -= buflen; > + put_page(alloc_frag->page); > +out: Out here isn't an error at all, is it? You should not mix return and error handling IMHO. > rcu_read_unlock(); > local_bh_enable(); > - this_cpu_inc(tun->pcpu_stats->rx_dropped); Doesn't this break rx_dropped accounting? > - return NULL; > + return skb; > } > > /* Get packet from user space buffer */ > -- > 2.17.1

...rbytes = stats->rx_bytes; + } while (u64_stats_fetch_retry(&stats->syncp, start)); + + tot->rx_packets += rpackets; + tot->tx_packets += tpackets; + tot->rx_bytes += rbytes; + tot->tx_bytes += tbytes; + } + + tot->tx_dropped = dev->stats.tx_dropped; + tot->rx_dropped = dev->stats.rx_dropped; + tot->rx_length_errors = dev->stats.rx_length_errors; + tot->rx_frame_errors = dev->stats.rx_frame_errors; + + return tot; +} + #ifdef CONFIG_NET_POLL_CONTROLLER static void virtnet_netpoll(struct net_device *dev) { @@ -650,6 +705,14 @@ static void virtne...

...rbytes = stats->rx_bytes; + } while (u64_stats_fetch_retry(&stats->syncp, start)); + + tot->rx_packets += rpackets; + tot->tx_packets += tpackets; + tot->rx_bytes += rbytes; + tot->tx_bytes += tbytes; + } + + tot->tx_dropped = dev->stats.tx_dropped; + tot->rx_dropped = dev->stats.rx_dropped; + tot->rx_length_errors = dev->stats.rx_length_errors; + tot->rx_frame_errors = dev->stats.rx_frame_errors; + + return tot; +} + #ifdef CONFIG_NET_POLL_CONTROLLER static void virtnet_netpoll(struct net_device *dev) { @@ -650,6 +705,14 @@ static void virtne...

...ings_stats[] = { > + { "rx_packets", VIRTNET_NETDEV_STAT(rx_packets) }, > + { "tx_packets", VIRTNET_NETDEV_STAT(tx_packets) }, > + { "rx_bytes", VIRTNET_NETDEV_STAT(rx_bytes) }, > + { "tx_bytes", VIRTNET_NETDEV_STAT(tx_bytes) }, > + { "rx_dropped", VIRTNET_NETDEV_STAT(rx_dropped) }, > + { "rx_length_errors", VIRTNET_NETDEV_STAT(rx_length_errors) }, > + { "rx_frame_errors", VIRTNET_NETDEV_STAT(rx_frame_errors) }, > + { "tx_dropped", VIRTNET_NETDEV_STAT(tx_dropped) }, > + { "tx_fifo_errors...

..., VIRTNET_NETDEV_STAT(rx_packets) }, >>>> + { "tx_packets", VIRTNET_NETDEV_STAT(tx_packets) }, >>>> + { "rx_bytes", VIRTNET_NETDEV_STAT(rx_bytes) }, >>>> + { "tx_bytes", VIRTNET_NETDEV_STAT(tx_bytes) }, >>>> + { "rx_dropped", VIRTNET_NETDEV_STAT(rx_dropped) }, >>>> + { "rx_length_errors", VIRTNET_NETDEV_STAT(rx_length_errors) }, >>>> + { "rx_frame_errors", VIRTNET_NETDEV_STAT(rx_frame_errors) }, >>>> + { "tx_dropped", VIRTNET_NETDEV_STAT(tx_dropp...

...rx_packets", VIRTNET_NETDEV_STAT(rx_packets) }, >>> + { "tx_packets", VIRTNET_NETDEV_STAT(tx_packets) }, >>> + { "rx_bytes", VIRTNET_NETDEV_STAT(rx_bytes) }, >>> + { "tx_bytes", VIRTNET_NETDEV_STAT(tx_bytes) }, >>> + { "rx_dropped", VIRTNET_NETDEV_STAT(rx_dropped) }, >>> + { "rx_length_errors", VIRTNET_NETDEV_STAT(rx_length_errors) }, >>> + { "rx_frame_errors", VIRTNET_NETDEV_STAT(rx_frame_errors) }, >>> + { "tx_dropped", VIRTNET_NETDEV_STAT(tx_dropped) }, >&...

David, Not sure if it's too late for 2.6.36 - in case it's not, the following tree includes a last minute bugfix for vhost-net, found by code inspection. It is on top of net-2.6. Thanks! The following changes since commit b0057c51db66c5f0f38059f242c57d61c4741d89: tg3: restore rx_dropped accounting (2010-10-11 16:06:24 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git vhost-net Dan Carpenter (1): vhost: fix return code for log_access_ok() drivers/vhost/vhost.c | 2 +- 1 files changed, 1 insertions(+), 1 deletio...

David, Not sure if it's too late for 2.6.36 - in case it's not, the following tree includes a last minute bugfix for vhost-net, found by code inspection. It is on top of net-2.6. Thanks! The following changes since commit b0057c51db66c5f0f38059f242c57d61c4741d89: tg3: restore rx_dropped accounting (2010-10-11 16:06:24 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git vhost-net Dan Carpenter (1): vhost: fix return code for log_access_ok() drivers/vhost/vhost.c | 2 +- 1 files changed, 1 insertions(+), 1 deletio...

...t: > Out here isn't an error at all, is it? You should not mix return and > error handling IMHO. If you mean the name, I can rename the label to "drop". > > > >> rcu_read_unlock(); >> local_bh_enable(); >> - this_cpu_inc(tun->pcpu_stats->rx_dropped); > Doesn't this break rx_dropped accounting? Let me fix this. Thanks >> - return NULL; >> + return skb; >> } >> >> /* Get packet from user space buffer */ >> -- >> 2.17.1

...); > goto out; > } > > - skb_reserve(skb, pad - delta); > + skb_reserve(skb, pad); > skb_put(skb, len); > > return skb; > > err_xdp: > - alloc_frag->offset -= buflen; > - put_page(alloc_frag->page); > + this_cpu_inc(tun->pcpu_stats->rx_dropped); This fixes bug in previous patch which dropped it. OK :) > out: > rcu_read_unlock(); > local_bh_enable(); > -- > 2.17.1

...); > goto out; > } > > - skb_reserve(skb, pad - delta); > + skb_reserve(skb, pad); > skb_put(skb, len); > > return skb; > > err_xdp: > - alloc_frag->offset -= buflen; > - put_page(alloc_frag->page); > + this_cpu_inc(tun->pcpu_stats->rx_dropped); This fixes bug in previous patch which dropped it. OK :) > out: > rcu_read_unlock(); > local_bh_enable(); > -- > 2.17.1

...tes = sq->stats.bytes; + terrors = sq->stats.tx_timeouts; } while (u64_stats_fetch_retry_irq(&sq->stats.syncp, start)); do { @@ -1743,6 +1749,7 @@ static void virtnet_stats(struct net_device *dev, tot->rx_bytes += rbytes; tot->tx_bytes += tbytes; tot->rx_dropped += rdrops; + tot->tx_errors += terrors; } tot->tx_dropped = dev->stats.tx_dropped; @@ -2578,6 +2585,33 @@ static int virtnet_set_features(struct net_device *dev, return 0; } +static void virtnet_tx_timeout(struct net_device *dev) +{ + struct virtnet_info *vi = netdev_priv(dev)...

...tes = sq->stats.bytes; + terrors = sq->stats.tx_timeouts; } while (u64_stats_fetch_retry_irq(&sq->stats.syncp, start)); do { @@ -1743,6 +1749,7 @@ static void virtnet_stats(struct net_device *dev, tot->rx_bytes += rbytes; tot->tx_bytes += tbytes; tot->rx_dropped += rdrops; + tot->tx_errors += terrors; } tot->tx_dropped = dev->stats.tx_dropped; @@ -2578,6 +2585,33 @@ static int virtnet_set_features(struct net_device *dev, return 0; } +static void virtnet_tx_timeout(struct net_device *dev) +{ + struct virtnet_info *vi = netdev_priv(dev)...