search for: rwrite

Here's a resend of an old patch that is intended to avoid an infinite recursion (ending in a stack overflow) of the rwrite() function getting an error that calls rwrite(), ad naseum. I've only seen this happen when one of the sides dies due to a program error -- in that case, the connection is closed, and when we try to send an error to the other side and it generates an error, the error generates an error, etc....

Rsync 2.5.5; transfer via ssh; sparc-sun-solaris2.5 (Ultra 1); gcc 2.8.1. Every time rsync on this box causes boundary violation. I attached two strange examples. I have a few rsync's corefiles (100MB and above) and I can examine them. I will be grateful for any help. -Mirek <-------------------------------------------------------------------------> received 966761 names done

(problem encountered on Tru64Unix v4.0f with rsync 2.5.5) A failure to write to stdout or stderr in rwrite (log.c:279) will trigger an endless loop as follows: 0 rprintf calls rwrite 1 rwrite calls fwrite 2 fwrite fails 3 rwrite calls _exit_cleanup 4 _exit_cleanup calls log_exit 5 log_exit calls rprintf 6 rprintf calls rwrite 7 rwrite c...

...ll () from /usr/lib/libc.so.4 #1 0x28102b0e in abort () from /usr/lib/libc.so.4 #2 0x8052897 in log_exit (code=13, file=0x80693f9 "log.c", line=279) at log.c:555 #3 0x804c662 in _exit_cleanup (code=13, file=0x80693f9 "log.c", line=279) at cleanup.c:87 #4 0x8052248 in rwrite (code=FERROR, buf=0xbfbfa86c "rsync error: errors with program diagnostics (code 13) at log.c(279)\n", len=69) at log.c:279 #5 0x8052302 in rprintf (code=FERROR, format=0x8069580 "rsync error: %s (code %d) at %s(%d)\n") at log.c:324 #6 0x8052924 in log_exit (code=13,...

...t;Ignore SIGPIPE; we consistently check error codes and will see the EPIPE." The comment is wrong; it does *not* see the SIGPIPE. What happens is that as a result of the SIGPIPE, exit_cleanup gets called. That's a macro which calls _exit_cleanup. That calls log_exit That calls rwrite. Rwrite tries to write an error to stderr, but that fails because of (you guessed it!) SIGPIPE, and so rwrite calls exit_cleanup. Presto, an infinite loop is born. The most straightforward fix I came up with is to modify rwrite so that it doesn't actually try to write the error if th...

...at=0x8069920 "rsync error: %s (code %d) at %s(% d)\n") at log.c:295 #5 0x8052944 in log_exit (code=13, file=0x8069799 "log.c", line=279) at log.c:564 #6 0x804c655 in _exit_cleanup (code=13, file=0x8069799 "log.c", line=279) at cleanup.c:87 #7 0x80522a8 in rwrite (code=FERROR, buf=0xbbc00888 "rsync error: errors with program diagnostics (code 13) at log.c(279)\n", len=69) at log.c:279 #8 0x805236a in rprintf (code=FERROR, format=0x8069920 "rsync error: %s (code %d) at %s(% d)\n") at log.c:324 #9 0x8052944 in log_exit (code=13...

Hello - I am making a first attempt at writing a simple C++ routine to print out R objects (this is a simple proof-of-concept as part of a larger package development). The relevant C++ routine is as follows: void Rwrite(SEXP fd, SEXP msg) { int *ofd = INTEGER(fd); const char * omsg = CHAR(asChar(msg)); printf("[%i] %s",*ofd,omsg); } And the corresponding interface in R is as follows: ptest <- function() { cfd <- as.integer(2); cmsg <- as.character("Hi"); storage.m...

...k is generated by the crash: (gdb) #0 0x0000003ad7e25433 in __gconv_transform_ascii_internal () from /lib64/libc.so.6 #1 0x0000003ad7e20264 in __gconv () from /lib64/libc.so.6 #2 0x0000003ad7e1f83c in iconv () from /lib64/libc.so.6 #3 0x000000000040d252 in iconvbufs () #4 0x0000000000423bce in rwrite () #5 0x0000000000423505 in rprintf () #6 0x000000000042b911 in whine_about_eof () #7 0x000000000042f5e2 in read_buf () #8 0x000000000042fde1 in read_int () #9 0x000000000043055d in setup_protocol () #10 0x000000000041ffb8 in client_run () #11 0x00000000004209c6 in main () Please let us know...

...rsync error: %s (code %d) at %s(%d)\n") at log.c:295 #3 0x080532b5 in log_exit (code=13, file=0x806878f "log.c", line=279) at log.c:564 #4 0x0804c9ad in _exit_cleanup (code=13, file=0x806878f "log.c", line=279) at cleanup.c:87 #5 0x08052c4e in rwrite (code=FERROR, buf=0xb1da4bf0 "rsync error: errors with program diagnostics (code 13) at log.c(279)\n", len=69) at log.c:279 #6 0x08052d12 in rprintf (code=FERROR, format=0x8068a00 "rsync error: %s (code %d) at %s(%d)\n") at log.c:324 #7 0x080532b5 in...

...=all9: (gdb) bt #1 0x0000000000434996 in perform_io (needed=60, flags=4) at ../rsync/io.c:608 #2 0x0000000000435b71 in send_msg (code=MSG_INFO, buf=0x7fffa60c7da0 "[receiver] perform_io(60, msgroom) needs to flush 33\n", len=53, convert=0) at ../rsync/io.c:955 #3 0x0000000000429840 in rwrite (code=FINFO, buf=0x7fffa60c7da0 "[receiver] perform_io(60, msgroom) needs to flush 33\n", len=53, is_utf8=0) at ../rsync/log.c:277 #4 0x0000000000429f37 in rprintf (code=FINFO, format=0x46c8c8 "[%s] perform_io(%ld, msgroom) needs to flush %ld\n") at ../rsync/log.c:433 #5 0x000...

...format=0x8069540 "rsync error: %s (code %d) at %s(%d)\n") at log.c:295 #3 0x80528e0 in log_exit (code=13, file=0x80693b9 "log.c", line=279) at log.c:564 #4 0x804c632 in _exit_cleanup (code=13, file=0x80693b9 "log.c", line=279) at cleanup.c:87 #5 0x8052218 in rwrite (code=FERROR, buf=0xbbc007fc "rsync error: errors with program diagnostics (code 13) at log.c(279)\n", len=69) at log.c:279 #6 0x80522d2 in rprintf (code=FERROR, format=0x8069540 "rsync error: %s (code %d) at %s(%d)\n") at log.c:324 #7 0x80528e0 in log_exit (code=13,...

...ropriate timeout error message would be in the rsyncd log. But now, beyond the initial 'rsync on [module] from [host]' message, there are no further entries in the rsyncd log for this timeout case. There should be an error message to indicate what happened, and when. There was a change to rwrite() that seems to be preventing the error logging. This 2.6.1 code: if (am_server) { /* Pass it to non-server side, perhaps through our sibling. */ if (msg_fd_out >= 0) { send_msg((enum msgcode)code, buf, len);...

seems the behavior of rsync has changed when dealing with output and using both -v and -q at the same time ... for example: $ mkdir test1 $ touch test1/foo $ rsync-2.6.0 -avq test1 test2 $ rm -r test2 $ rsync-2.6.8 -avq test1 test2 test1/ test1/fo $ rm -r test2 $ rsync-cvs -avq test1 test2 building file list ... test1/ test1/fo $ rm -r test2 the new output in 2.6.8 comes from the calls to

...reported in Debian about the tty being screwed up by wierd filenames, see http://bugs.debian.org/bug=242300 On the one hand, find will also do this. On the other hand, ls will replace such chars with a question mark. Upon inspection, it appears to be fairly simple to also do this in rsync (in the rwrite() function). Here's a patch. Opinions? Perhaps don't do it unconditionally, i.e. offer some way to turn it off? Paul Slootman --- log.c.orig 2004-10-04 11:51:37.000000000 +0200 +++ log.c 2004-11-23 17:27:29.000000000 +0100 @@ -180,6 +180,15 @@ buf[len] = 0; + if (code == FIN...

...+#define getpeername Rgetpeername +#define getsockname Rgetsockname +#define read Rread +#define readv Rreadv +#define recv Rrecv +#define recvmsg Rrecvmsg +#define recvfrom Rrecvfrom +#define rresvport Rrresvport +#define send Rsend +#define sendmsg Rsendmsg +#define sendto Rsendto +#define write Rwrite +#define writev Rwritev +int Raccept (int, struct sockaddr *, socklen_t *); +int Rbind (int, const struct sockaddr *, socklen_t); +int Rbindresvport(int , struct sockaddr_in *); +int Rconnect (int, const struct sockaddr *, socklen_t); +struct hostent *Rgethostbyname(const char *); +stru...

Hi guys: First post for me on this list. THE PROBLEM =========== I have several linux servers (ranging from Redhat 7.3 to FC3) that use Rsync (version 2.6.8 and 2.6.7, read on for reasons) to backup their data. A typical rsync backup script looks like this: ------------------------------------------------------------------------------------------ #!/bin/sh RSYNC_PASSWORD=<PASSWORD> rsync

https://bugzilla.samba.org/show_bug.cgi?id=11166 Bug ID: 11166 Summary: running with -vvv causes a hang Product: rsync Version: 3.1.1 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 Component: core Assignee: wayned at samba.org Reporter: pskocik at

...42 #2 0x000000000042b45a in send_msg (code=MSG_LOG, buf=0x7fff8ed87400 "10.126.100.201 682364 tjtx-100-200_20160121_135901/aifang_dw/contract_snapshot_detail_20151103.MYD 682244 2015/12/05-18:53:33 recv 114409 fullbak\n", len=147, convert=0) at io.c:958 #3 0x00000000004218a0 in rwrite (code=FLOG, buf=0x7fff8ed87400 "10.126.100.201 682364 tjtx-100-200_20160121_135901/aifang_dw/contract_snapshot_detail_20151103.MYD 682244 2015/12/05-18:53:33 recv 114409 fullbak\n", len=147, is_utf8=0) at log.c:277 #4 0x000000000042299c in log_formatted (code=FLOG, format=<va...

https://bugzilla.samba.org/show_bug.cgi?id=2790 ------- Comment #5 from mangoo@interia.pl 2006-03-29 04:11 MST ------- I'm just curious. Suppose I have rsyncd running on Windows, and want to copy files from there to a Linux machine. The problem is that some characters (like German umlauts - ü, ö, ä etc.) are changed to ? when saved on the Linux side. Where should I apply this patch?

...ternal () from /lib64/libc.so.6 #4 0x000000000041ff92 in logfile_open () at log.c:153 #5 0x000000000041e8ec in logit (code=FERROR, buf=0x7fff3cfc2060 "rsync error: received SIGINT, SIGTERM, or SIGHUP (code 20) at rsync.c(545) [Receiver=3.0.7]\n", len=92, is_utf8=0) at log.c:116 #6 rwrite (code=FERROR, buf=0x7fff3cfc2060 "rsync error: received SIGINT, SIGTERM, or SIGHUP (code 20) at rsync.c(545) [Receiver=3.0.7]\n", len=92, is_utf8=0) at log.c:285 #7 0x000000000041ede5 in rprintf (code=FERROR, format=0x4471b0 "rsync error: %s (code %d) at %s(%d) [%s=%s]\n&q...