search for: run_extra

Hi, this series start to implement some of the changes needed to support d-i-b 2.0; normal VM distro builds seem to work correctly, ramdisk builds are still broken and require more efforts. Thanks, Pino Toscano (5): dib: implement get_image_element_array stuff dib: export IMAGE_BLOCK_DEVICE_WITHOUT_PART dib: extract get_required_tool out of require_tool dib: require a Python interpreter

...s ~out_name ~root_label ~rootfs_uuid ~image_cache ~arch ~network ~debug - destdir libdir hooksdir tmpdir fakebindir all_elements element_paths = + destdir libdir hooksdir fakebindir all_elements element_paths = let network_string = if network then "" else "1" in let run_extra = sprintf "\ #!/bin/bash set -e %s +mount_dir=$1 +shift target_dir=$1 shift script=$1 @@ -87,7 +89,7 @@ shift export PATH=%s:$PATH # d-i-b variables -export TMP_MOUNT_PATH=%s +export TMP_MOUNT_PATH=\"$mount_dir\" export DIB_OFFLINE=%s export IMAGE_NAME=\"%s\" e...

Move the OCaml binding to C _exit to an own module. Just code motion, adapting v2v in the process. --- docs/C_SOURCE_FILES | 2 +- mllib/Makefile.am | 5 ++++- mllib/exit-c.c | 33 +++++++++++++++++++++++++++++++++ mllib/exit.ml | 19 +++++++++++++++++++ mllib/exit.mli | 20 ++++++++++++++++++++ v2v/Makefile.am | 1 - v2v/changeuid-c.c | 33

...; +let prepare_external ~dib_args ~dib_vars ~out_name ~root_label ~rootfs_uuid > + ~image_cache ~arch ~network ~debug > + destdir libdir hooksdir tmpdir fakebindir all_elements element_paths = > + let network_string = if network then "" else "1" in > + > + let run_extra = sprintf "\ > +#!/bin/bash There are a bunch of embedded bash scripts. Probably they need to use 'set -e'. Quoting seems OK, but if there are any quotes wrong, then it might lead to an appliance exploit, which worried me. Can we do it in any other way apart from using shell scr...

...ON_EXEC=%s elinfo_out=$(<${VIRT_DIB_OURPATH}/elinfo_out) eval \"$elinfo_out\" @@ -158,7 +160,8 @@ $target_dir/$script (quote dib_vars) debug fs_type - checksum_string in + checksum_string + python in write_script (destdir // "run-part-extra.sh") run_extra; let elinfo_out = sprintf "\ function get_image_element_array { @@ -524,6 +527,10 @@ let main () = error (f_"the specified base path is not the diskimage-builder library"); (* Check for required tools. *) + let python = + match cmdline.python with + | None ->...

...dib_args ~dib_vars ~out_name ~root_label ~rootfs_uuid > > + ~image_cache ~arch ~network ~debug > > + destdir libdir hooksdir tmpdir fakebindir all_elements element_paths = > > + let network_string = if network then "" else "1" in > > + > > + let run_extra = sprintf "\ > > +#!/bin/bash > > There are a bunch of embedded bash scripts. Probably they need to use > 'set -e'. Quoting seems OK, but if there are any quotes wrong, then > it might lead to an appliance exploit, which worried me. Can we do it > in any other...

...; + Unix.chmod fn 0o755 + +let prepare_external ~dib_args ~dib_vars ~out_name ~root_label ~rootfs_uuid + ~image_cache ~arch ~network ~debug + destdir libdir hooksdir tmpdir fakebindir all_elements element_paths = + let network_string = if network then "" else "1" in + + let run_extra = sprintf "\ +#!/bin/bash +%s +target_dir=$1 +shift +script=$1 +shift + +export PATH=%s:$PATH + +# d-i-b variables +export TMP_MOUNT_PATH=%s +export DIB_OFFLINE=%s +export IMAGE_NAME=\"%s\" +export DIB_ROOT_LABEL=\"%s\" +export DIB_IMAGE_ROOT_FS_UUID=%s +export DIB_IMAGE_CA...

Hi, this series improves virt-dib, adding some upstream changes, and refactoring the handling of output formats. Thanks, Pino Toscano (6): dib: clear up "already provided" message dib: add --checksum dib: pass custom mkfs options after the filesystem type dib: refactor output formats handling dib: clarify "output:" lines in --machine-readable documentation dib:

...; + Unix.chmod fn 0o755 + +let prepare_external ~dib_args ~dib_vars ~out_name ~root_label ~rootfs_uuid + ~image_cache ~arch ~network ~debug + destdir libdir hooksdir tmpdir fakebindir all_elements element_paths = + let network_string = if network then "" else "1" in + + let run_extra = sprintf "\ +#!/bin/bash +%s +target_dir=$1 +shift +script=$1 +shift + +export PATH=%s:$PATH + +# d-i-b variables +export TMP_MOUNT_PATH=%s +export DIB_OFFLINE=%s +export IMAGE_NAME=\"%s\" +export DIB_ROOT_LABEL=\"%s\" +export DIB_IMAGE_ROOT_FS_UUID=%s +export DIB_IMAGE_CA...

...; + Unix.chmod fn 0o755 + +let prepare_external ~dib_args ~dib_vars ~out_name ~root_label ~rootfs_uuid + ~image_cache ~arch ~network ~debug + destdir libdir hooksdir tmpdir fakebindir all_elements element_paths = + let network_string = if network then "" else "1" in + + let run_extra = sprintf "\ +#!/bin/bash +set -e +%s +target_dir=$1 +shift +script=$1 +shift + +export PATH=%s:$PATH + +# d-i-b variables +export TMP_MOUNT_PATH=%s +export DIB_OFFLINE=%s +export IMAGE_NAME=\"%s\" +export DIB_ROOT_LABEL=\"%s\" +export DIB_IMAGE_ROOT_FS_UUID=%s +export DIB_...

...ut oc; + chmod fn 0o755 + +let prepare_external ~dib_args ~dib_vars ~out_name ~root_label ~rootfs_uuid ~image_cache + ~arch ~network ~debug + destdir libdir hooksdir tmpdir fakebindir all_elements element_paths = + let network_string = if network then "" else "1" in + + let run_extra = sprintf "\ +#!/bin/bash +%s +target_dir=$1 +shift +script=$1 +shift + +export PATH=%s:$PATH + +# d-i-b variables +export TMP_MOUNT_PATH=%s +export DIB_OFFLINE=%s +export IMAGE_NAME=\"%s\" +export DIB_ROOT_LABEL=\"%s\" +export DIB_IMAGE_ROOT_FS_UUID=%s +export DIB_IMAGE_CA...