search for: rsync_xal_l

Hi, I have a crash running rsync-3.0.6 and using the -X flag. The crash was in uncache_tmp_xattrs() when free was called on every xattr_item. However, the rsync_xal_l.items is a buffer, not a list, and so only the whole buffer should be freed, and not every item. Can anyone with git access please fix this? This is the patch: --- rsync-3.0.6/xattrs.c 2009-11-30 14:16:53.501050939 +0200 +++ rsync-3.0.6/xattrs.c.new 2009-11-30 14:40:58.839777618 +0200...

...curr_rsync_xal.count].datum = ptr + len; ++ x->rxas[x->count].name_len = len; ++ x->rxas[x->count].name = ptr; ++ x->rxas[x->count].datum_len = datum_size; ++ x->rxas[x->count].datum = ptr + len; + x->count++; + } + if (x->count > 1) { @@ -656,6 +656,7 @@ + rsync_xal_l.count++; + curr_rsync_xal.count = 0; + curr_rsync_xal.alloc = 0; ++ curr_rsync_xal.rxas = NULL; +} + +/* send the make_xattr()-generated xattr list for this flist entry,

In debian bug #498083 (http://bugs.debian.org/498083) someone is getting segfaults reasonably consistently, however when using -vvvv it doesn't happen... Fortunately Sven was able to get a good backtrace. I can't quite see what's causing the problem; it does seem to be related to xattrs. Please see the bugs report at the url above for the details. Any help much appreciated. Paul

https://bugzilla.samba.org/show_bug.cgi?id=5324 Summary: with option --xattrs the process rsync is more long time Product: rsync Version: 3.0.0 Platform: x86 OS/Version: Other Status: NEW Severity: normal Priority: P3 Component: core AssignedTo: wayned@samba.org ReportedBy: fauthier@free.fr