Displaying 2 results from an estimated 2 matches for "rr_to_rid".
2008 Mar 31
2
[01/17]PATCH Add API for allocating dynamic TR resouce. V8
...spaces so it's a little easier to read, ie:
if (target_mask & 0x1) {
> + p = &__per_cpu_idtrs[cpu][0][0];
> + for (i = IA64_TR_ALLOC_BASE; i <= per_cpu(ia64_tr_used,
> cpu);
> + i++,
> p++) {
> + if (p->pte&0x1)
Same thing here.
> +#define RR_TO_RID(rr) ((rr)<<32>>40)
I would prefer to have this one defined like this:
#define RR_TO_RID(rr) (rr >> 8) & 0xffffff
It should generate the same code, but is more intuitive for the reader.
Otherwise I think this patch is fine - this is really just cosmetics.
Cheers,
Jes
2008 Mar 31
2
[01/17]PATCH Add API for allocating dynamic TR resouce. V8
...spaces so it's a little easier to read, ie:
if (target_mask & 0x1) {
> + p = &__per_cpu_idtrs[cpu][0][0];
> + for (i = IA64_TR_ALLOC_BASE; i <= per_cpu(ia64_tr_used,
> cpu);
> + i++,
> p++) {
> + if (p->pte&0x1)
Same thing here.
> +#define RR_TO_RID(rr) ((rr)<<32>>40)
I would prefer to have this one defined like this:
#define RR_TO_RID(rr) (rr >> 8) & 0xffffff
It should generate the same code, but is more intuitive for the reader.
Otherwise I think this patch is fine - this is really just cosmetics.
Cheers,
Jes