search for: rqs

This patch should fix the bug reported in https://lkml.org/lkml/2014/9/11/249. Test is still pending. David Hildenbrand (1): blk-mq: Avoid race condition with uninitialized requests block/blk-mq.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) -- 1.8.5.5

This patch should fix the bug reported in https://lkml.org/lkml/2014/9/11/249. Test is still pending. David Hildenbrand (1): blk-mq: Avoid race condition with uninitialized requests block/blk-mq.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) -- 1.8.5.5

...subscribe from this list: send the line "unsubscribe kvm" in > > the body of a message to majordomo at vger.kernel.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html > > > Digging through the code, I think I found a possible cause: tags->rqs[..] is not initialized with zeroes (via alloc_pages_node in blk-mq.c:blk_mq_init_rq_map()). When a request is created: 1. __blk_mq_alloc_request() gets a free tag (thus e.g. removing it from bitmap_tags) 2. __blk_mq_alloc_request() initializes is via blk_mq_rq_ctx_init(). The struct is filled wi...

...subscribe from this list: send the line "unsubscribe kvm" in > > the body of a message to majordomo at vger.kernel.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html > > > Digging through the code, I think I found a possible cause: tags->rqs[..] is not initialized with zeroes (via alloc_pages_node in blk-mq.c:blk_mq_init_rq_map()). When a request is created: 1. __blk_mq_alloc_request() gets a free tag (thus e.g. removing it from bitmap_tags) 2. __blk_mq_alloc_request() initializes is via blk_mq_rq_ctx_init(). The struct is filled wi...

...UseMethod("latex") : # no applicable method for 'latex' applied to an object of class "rq" latex(rq_object_summary) # Error in UseMethod("latex") : # no applicable method for 'latex' applied to an object of class "summary.rq" latex.summary.rqs(rq_object_summary) # Error in x$tau : $ operator is invalid for atomic vectors summary.rqs(rq_object) # Error in xi$coefficients[, i] : incorrect number of dimensions summary.rqs(rq_object_summary) # Error in xi$residuals[, i] : incorrect number of dimensions ----------------Contact Details:----...

..." in >>>> the body of a message to majordomo at vger.kernel.org >>>> More majordomo info at http://vger.kernel.org/majordomo-info.html >>>> >>> >> >> Digging through the code, I think I found a possible cause: >> >> tags->rqs[..] is not initialized with zeroes (via alloc_pages_node in >> blk-mq.c:blk_mq_init_rq_map()). > > Yes, it may cause problem when the request is allocated at the 1st time, > and timeout handler may comes just after the allocation and before its > initialization, then oops triggere...

..." in >>>> the body of a message to majordomo at vger.kernel.org >>>> More majordomo info at http://vger.kernel.org/majordomo-info.html >>>> >>> >> >> Digging through the code, I think I found a possible cause: >> >> tags->rqs[..] is not initialized with zeroes (via alloc_pages_node in >> blk-mq.c:blk_mq_init_rq_map()). > > Yes, it may cause problem when the request is allocated at the 1st time, > and timeout handler may comes just after the allocation and before its > initialization, then oops triggere...

...3 insertions(+), 1 deletion(-) diff --git a/block/blk-mq.c b/block/blk-mq.c index 383ea0c..eed6340 100644 --- a/block/blk-mq.c +++ b/block/blk-mq.c @@ -203,7 +203,6 @@ __blk_mq_alloc_request(struct blk_mq_alloc_data *data, int rw) if (tag != BLK_MQ_TAG_FAIL) { rq = data->hctx->tags->rqs[tag]; - rq->cmd_flags = 0; if (blk_mq_tag_busy(data->hctx)) { rq->cmd_flags = REQ_MQ_INFLIGHT; atomic_inc(&data->hctx->nr_active); @@ -258,6 +257,7 @@ static void __blk_mq_free_request(struct blk_mq_hw_ctx *hctx, if (rq->cmd_flags & REQ_MQ_INFLIGHT) at...

...t; diff --git a/block/blk-mq.c b/block/blk-mq.c > index 383ea0c..eed6340 100644 > --- a/block/blk-mq.c > +++ b/block/blk-mq.c > @@ -203,7 +203,6 @@ __blk_mq_alloc_request(struct blk_mq_alloc_data *data, int rw) > if (tag != BLK_MQ_TAG_FAIL) { > rq = data->hctx->tags->rqs[tag]; > > - rq->cmd_flags = 0; > if (blk_mq_tag_busy(data->hctx)) { > rq->cmd_flags = REQ_MQ_INFLIGHT; > atomic_inc(&data->hctx->nr_active); > @@ -258,6 +257,7 @@ static void __blk_mq_free_request(struct blk_mq_hw_ctx *hctx, > > if (rq->...

...t; diff --git a/block/blk-mq.c b/block/blk-mq.c > index 383ea0c..eed6340 100644 > --- a/block/blk-mq.c > +++ b/block/blk-mq.c > @@ -203,7 +203,6 @@ __blk_mq_alloc_request(struct blk_mq_alloc_data *data, int rw) > if (tag != BLK_MQ_TAG_FAIL) { > rq = data->hctx->tags->rqs[tag]; > > - rq->cmd_flags = 0; > if (blk_mq_tag_busy(data->hctx)) { > rq->cmd_flags = REQ_MQ_INFLIGHT; > atomic_inc(&data->hctx->nr_active); > @@ -258,6 +257,7 @@ static void __blk_mq_free_request(struct blk_mq_hw_ctx *hctx, > > if (rq->...

...000003edde8>] blk_mq_timeout_check+0x6c/0xb8 I looked into the dump, and the full function is (annotated by me to match the source code) r2= tags r3= tag (4e) Dump of assembler code for function blk_mq_tag_to_rq: 0x00000000003ed0f4 <+0>: lg %r1,96(%r2) # r1 has now tags->rqs 0x00000000003ed0fa <+6>: sllg %r2,%r3,3 # r2 has tag*8 0x00000000003ed100 <+12>: lg %r2,0(%r2,%r1) # r2 now has rq (=tags->rqs[tag]) 0x00000000003ed106 <+18>: lg %r1,48(%r2) # r1 now has rq->q 0x00000000003ed10c <+24>: tm...

...000003edde8>] blk_mq_timeout_check+0x6c/0xb8 I looked into the dump, and the full function is (annotated by me to match the source code) r2= tags r3= tag (4e) Dump of assembler code for function blk_mq_tag_to_rq: 0x00000000003ed0f4 <+0>: lg %r1,96(%r2) # r1 has now tags->rqs 0x00000000003ed0fa <+6>: sllg %r2,%r3,3 # r2 has tag*8 0x00000000003ed100 <+12>: lg %r2,0(%r2,%r1) # r2 now has rq (=tags->rqs[tag]) 0x00000000003ed106 <+18>: lg %r1,48(%r2) # r1 now has rq->q 0x00000000003ed10c <+24>: tm...

Hello everybody! I am currently using the quantreg package on R 2.2.1. for my diploma thesis and want to create plots with plot.summary.rqs, which should work like this: Usage: plot.summary.rqs(x, nrow=3, ncol=2, alpha = 0.1, ols = TRUE, ...) Arguments: x: an object produced by rq() fitting nrow: rows in mfrow ncol: columns in mfrow alpha: alpha level of confidence bands ols: if TRUE, plot ols c...

...ked into the dump, and the full function is (annotated by me to match the source code) >> r2= tags >> r3= tag (4e) >> Dump of assembler code for function blk_mq_tag_to_rq: >> 0x00000000003ed0f4 <+0>: lg %r1,96(%r2) # r1 has now tags->rqs >> 0x00000000003ed0fa <+6>: sllg %r2,%r3,3 # r2 has tag*8 >> 0x00000000003ed100 <+12>: lg %r2,0(%r2,%r1) # r2 now has rq (=tags->rqs[tag]) >> 0x00000000003ed106 <+18>: lg %r1,48(%r2)...

...ked into the dump, and the full function is (annotated by me to match the source code) >> r2= tags >> r3= tag (4e) >> Dump of assembler code for function blk_mq_tag_to_rq: >> 0x00000000003ed0f4 <+0>: lg %r1,96(%r2) # r1 has now tags->rqs >> 0x00000000003ed0fa <+6>: sllg %r2,%r3,3 # r2 has tag*8 >> 0x00000000003ed100 <+12>: lg %r2,0(%r2,%r1) # r2 now has rq (=tags->rqs[tag]) >> 0x00000000003ed106 <+18>: lg %r1,48(%r2)...

Hi Folks, I've got a question regarding the 'quantreg' package maintained by Roger Koenker: I tried to produce LaTeX tables using the longtable and dcolumn options as decribed in the manual, but the function latex() doesn't seem to react on _any_ other options than 'digits' and 'transpose'. To reproduce these results the following minimal example may be used:

...> > I looked into the dump, and the full function is (annotated by me to match the source code) > r2= tags > r3= tag (4e) > Dump of assembler code for function blk_mq_tag_to_rq: > 0x00000000003ed0f4 <+0>: lg %r1,96(%r2) # r1 has now tags->rqs > 0x00000000003ed0fa <+6>: sllg %r2,%r3,3 # r2 has tag*8 > 0x00000000003ed100 <+12>: lg %r2,0(%r2,%r1) # r2 now has rq (=tags->rqs[tag]) > 0x00000000003ed106 <+18>: lg %r1,48(%r2)...

When initializing XDP in virtnet_open(), some rq xdp initialization may hit an error causing net device open failed. However, previous rqs have already initialized XDP and enabled NAPI, which is not the expected behavior. Need to roll back the previous rq initialization to avoid leaks in error unwinding of init code. Fixes: 754b8a21a96d ("virtio_net: setup xdp_rxq_info") Signed-off-by: Feng Liu <feliu at nvidia.com> R...

When initializing XDP in virtnet_open(), some rq xdp initialization may hit an error causing net device open failed. However, previous rqs have already initialized XDP and enabled NAPI, which is not the expected behavior. Need to roll back the previous rq initialization to avoid leaks in error unwinding of init code. Also extract helper functions of disable and enable queue pairs. Use newly introduced disable helper function in error...

...p, and the full function is (annotated by me to match the source code) >>> r2= tags >>> r3= tag (4e) >>> Dump of assembler code for function blk_mq_tag_to_rq: >>> 0x00000000003ed0f4 <+0>: lg %r1,96(%r2) # r1 has now tags->rqs >>> 0x00000000003ed0fa <+6>: sllg %r2,%r3,3 # r2 has tag*8 >>> 0x00000000003ed100 <+12>: lg %r2,0(%r2,%r1) # r2 now has rq (=tags->rqs[tag]) >>> 0x00000000003ed106 <+18>: lg %r1,48...