search for: rpmsg_client_sampl

...f (eptdev->rpdev->dst == RPMSG_ADDR_ANY) { + ret = -EPIPE; + WARN(1, "Cannot write first on server, must wait for client!\n"); + goto unlock_eptdev; + } + if (filp->f_flags & O_NONBLOCK) ret = rpmsg_trysend(eptdev->ept, kbuf, len); else diff --git a/samples/rpmsg/rpmsg_client_sample.c b/samples/rpmsg/rpmsg_client_sample.c index f161dfd3e70..5d8ca84dce0 100644 --- a/samples/rpmsg/rpmsg_client_sample.c +++ b/samples/rpmsg/rpmsg_client_sample.c @@ -46,6 +46,9 @@ static int rpmsg_sample_cb(struct rpmsg_device *rpdev, void *data, int len, return 0; } + if (rpdev->dst ==...

...f (eptdev->rpdev->dst == RPMSG_ADDR_ANY) { + ret = -EPIPE; + WARN(1, "Cannot write first on server, must wait for client!\n"); + goto unlock_eptdev; + } + if (filp->f_flags & O_NONBLOCK) ret = rpmsg_trysend(eptdev->ept, kbuf, len); else diff --git a/samples/rpmsg/rpmsg_client_sample.c b/samples/rpmsg/rpmsg_client_sample.c index f161dfd3e70..5d8ca84dce0 100644 --- a/samples/rpmsg/rpmsg_client_sample.c +++ b/samples/rpmsg/rpmsg_client_sample.c @@ -46,6 +46,9 @@ static int rpmsg_sample_cb(struct rpmsg_device *rpdev, void *data, int len, return 0; } + if (rpdev->dst ==...

...) { > + ret = -EPIPE; > + WARN(1, "Cannot write first on server, must wait for client!\n"); > + goto unlock_eptdev; > + } > + > if (filp->f_flags & O_NONBLOCK) > ret = rpmsg_trysend(eptdev->ept, kbuf, len); > else > diff --git a/samples/rpmsg/rpmsg_client_sample.c b/samples/rpmsg/rpmsg_client_sample.c > index f161dfd3e70..5d8ca84dce0 100644 > --- a/samples/rpmsg/rpmsg_client_sample.c > +++ b/samples/rpmsg/rpmsg_client_sample.c > @@ -46,6 +46,9 @@ static int rpmsg_sample_cb(struct rpmsg_device *rpdev, void *data, int len, > return 0; >...

On Wed, May 27, 2020 at 08:05:41PM +0200, Guennadi Liakhovetski wrote: > Linux supports running the RPMsg protocol over the VirtIO transport > protocol, but currently there is only support for VirtIO clients and > no support for a VirtIO server. This patch adds a vhost-based RPMsg > server implementation. This looks really useful, but why is it implemented as an API and not as a real

On Wed, May 27, 2020 at 08:05:41PM +0200, Guennadi Liakhovetski wrote: > Linux supports running the RPMsg protocol over the VirtIO transport > protocol, but currently there is only support for VirtIO clients and > no support for a VirtIO server. This patch adds a vhost-based RPMsg > server implementation. This looks really useful, but why is it implemented as an API and not as a real

...a communication protocol, not an API. An RPMsg implementation has to be able to communicate with other compliant RPMsg implementations, it doesn't have to provide any specific API. Am I missing anything? Thanks Guennadi > [4] https://elixir.bootlin.com/linux/v5.9-rc5/source/samples/rpmsg/rpmsg_client_sample.c > > Regards, > Arnaud > > > > > > So i would be agree with Vincent[2] which proposed to switch on a > > > RPMsg API and creating a vhost rpmsg device. This is also proposed in > > > the "Enhance VHOST to enable SoC-to-SoC communication" R...

...a communication protocol, not an API. An RPMsg implementation has to be able to communicate with other compliant RPMsg implementations, it doesn't have to provide any specific API. Am I missing anything? Thanks Guennadi > [4] https://elixir.bootlin.com/linux/v5.9-rc5/source/samples/rpmsg/rpmsg_client_sample.c > > Regards, > Arnaud > > > > > > So i would be agree with Vincent[2] which proposed to switch on a > > > RPMsg API and creating a vhost rpmsg device. This is also proposed in > > > the "Enhance VHOST to enable SoC-to-SoC communication" R...

...way to answer this, might be to respond to this question: Is the rpmsg sample client[4] can be used on top of your vhost RPMsg implementation? If the response is no, describe it as a RPMsg implementation could lead to confusion... [4] https://elixir.bootlin.com/linux/v5.9-rc5/source/samples/rpmsg/rpmsg_client_sample.c Regards, Arnaud > > > So i would be agree with Vincent[2] which proposed to switch on a > > RPMsg API and creating a vhost rpmsg device. This is also proposed in > > the "Enhance VHOST to enable SoC-to-SoC communication" RFC[3]. > > Do you think that this...

...e or duplications... I'm not the right person to answer, Bjorn and Mathieu are. [5] https://elixir.bootlin.com/linux/v5.8.10/source/Documentation/rpmsg.txt#L66 Thanks, Arnaud > > Thanks > Guennadi > >> [4] https://elixir.bootlin.com/linux/v5.9-rc5/source/samples/rpmsg/rpmsg_client_sample.c >> >> Regards, >> Arnaud >> >>> >>>> So i would be agree with Vincent[2] which proposed to switch on a >>>> RPMsg API and creating a vhost rpmsg device. This is also proposed in >>>> the "Enhance VHOST to enable SoC-to-SoC...

Hi Arnaud, On Tue, Sep 15, 2020 at 02:13:23PM +0200, Arnaud POULIQUEN wrote: > Hi Guennadi, > > On 9/1/20 5:11 PM, Guennadi Liakhovetski wrote: > > Hi, > > > > Next update: > > > > v6: > > - rename include/linux/virtio_rpmsg.h -> include/linux/rpmsg/virtio.h > > > > v5: > > - don't hard-code message layout > > >

Hi Arnaud, On Tue, Sep 15, 2020 at 02:13:23PM +0200, Arnaud POULIQUEN wrote: > Hi Guennadi, > > On 9/1/20 5:11 PM, Guennadi Liakhovetski wrote: > > Hi, > > > > Next update: > > > > v6: > > - rename include/linux/virtio_rpmsg.h -> include/linux/rpmsg/virtio.h > > > > v5: > > - don't hard-code message layout > > >

...t; include/linux}/vhost.h????? |? 132 +- >>>> ? include/linux/virtio.h??????????????????????? |??? 3 + >>>> ? include/linux/virtio_config.h???????????????? |?? 42 + >>>> ? include/linux/vringh.h??????????????????????? |?? 46 + >>>> ? samples/rpmsg/rpmsg_client_sample.c?????????? |?? 32 +- >>>> ? tools/virtio/virtio_test.c??????????????????? |??? 2 +- >>>> ? 39 files changed, 7083 insertions(+), 183 deletions(-) >>>> ? create mode 100644 drivers/ntb/ntb_vhost.c >>>> ? create mode 100644 drivers/ntb/ntb_virtio....

..., Bjorn and Mathieu are. > > [5] https://elixir.bootlin.com/linux/v5.8.10/source/Documentation/rpmsg.txt#L66 > > Thanks, > Arnaud > > > > > > Thanks > > Guennadi > > > >> [4] https://elixir.bootlin.com/linux/v5.9-rc5/source/samples/rpmsg/rpmsg_client_sample.c > >> > >> Regards, > >> Arnaud > >> > >>> > >>>> So i would be agree with Vincent[2] which proposed to switch on a > >>>> RPMsg API and creating a vhost rpmsg device. This is also proposed in > >>>> the...

..., Bjorn and Mathieu are. > > [5] https://elixir.bootlin.com/linux/v5.8.10/source/Documentation/rpmsg.txt#L66 > > Thanks, > Arnaud > > > > > > Thanks > > Guennadi > > > >> [4] https://elixir.bootlin.com/linux/v5.9-rc5/source/samples/rpmsg/rpmsg_client_sample.c > >> > >> Regards, > >> Arnaud > >> > >>> > >>>> So i would be agree with Vincent[2] which proposed to switch on a > >>>> RPMsg API and creating a vhost rpmsg device. This is also proposed in > >>>> the...

...2 +- >>>>>> ?? include/linux/virtio.h??????????????????????? |??? 3 + >>>>>> ?? include/linux/virtio_config.h???????????????? |?? 42 + >>>>>> ?? include/linux/vringh.h??????????????????????? |?? 46 + >>>>>> ?? samples/rpmsg/rpmsg_client_sample.c?????????? |?? 32 +- >>>>>> ?? tools/virtio/virtio_test.c??????????????????? |??? 2 +- >>>>>> ?? 39 files changed, 7083 insertions(+), 183 deletions(-) >>>>>> ?? create mode 100644 drivers/ntb/ntb_vhost.c >>>>>> ?? create...

...; ??? include/linux/virtio.h??????????????????????? |??? 3 + >>>>>>>> ??? include/linux/virtio_config.h???????????????? |?? 42 + >>>>>>>> ??? include/linux/vringh.h??????????????????????? |?? 46 + >>>>>>>> ??? samples/rpmsg/rpmsg_client_sample.c?????????? |?? 32 +- >>>>>>>> ??? tools/virtio/virtio_test.c??????????????????? |??? 2 +- >>>>>>>> ??? 39 files changed, 7083 insertions(+), 183 deletions(-) >>>>>>>> ??? create mode 100644 drivers/ntb/ntb_vhost.c >>...

....h??????????????????????? |??? 3 + >>>>>>>>>> ???? include/linux/virtio_config.h???????????????? |?? 42 + >>>>>>>>>> ???? include/linux/vringh.h??????????????????????? |?? 46 + >>>>>>>>>> ???? samples/rpmsg/rpmsg_client_sample.c?????????? |?? 32 +- >>>>>>>>>> ???? tools/virtio/virtio_test.c??????????????????? |??? 2 +- >>>>>>>>>> ???? 39 files changed, 7083 insertions(+), 183 deletions(-) >>>>>>>>>> ???? create mode 100644 drive...

...| 6 + > {drivers/vhost => include/linux}/vhost.h | 132 +- > include/linux/virtio.h | 3 + > include/linux/virtio_config.h | 42 + > include/linux/vringh.h | 46 + > samples/rpmsg/rpmsg_client_sample.c | 32 +- > tools/virtio/virtio_test.c | 2 +- > 39 files changed, 7083 insertions(+), 183 deletions(-) > create mode 100644 drivers/ntb/ntb_vhost.c > create mode 100644 drivers/ntb/ntb_virtio.c > create mode 100644 drivers/ntb/ntb_virtio.h >...

...| 6 + > {drivers/vhost => include/linux}/vhost.h | 132 +- > include/linux/virtio.h | 3 + > include/linux/virtio_config.h | 42 + > include/linux/vringh.h | 46 + > samples/rpmsg/rpmsg_client_sample.c | 32 +- > tools/virtio/virtio_test.c | 2 +- > 39 files changed, 7083 insertions(+), 183 deletions(-) > create mode 100644 drivers/ntb/ntb_vhost.c > create mode 100644 drivers/ntb/ntb_virtio.c > create mode 100644 drivers/ntb/ntb_virtio.h >...