search for: rpc_cflag

Since glibc-2.26 removed the /usr/include/rpc/rpc.h, it caused problem even though probing for libtirpc has taken place and worked properly. The problem is that RPC_CFLAGS (usually `-I/usr/include/tirpc` on Linux) was not used in places where it was needed. So the build failed with messages like the following: In file included from guestfs_protocol.c:6:0: guestfs_protocol.h:9:10: fatal error: rpc/rpc.h: No such file or directory #include <rpc/rpc.h>...

...functions must be located in one of -lportablexdr, -lrpc, -lxdr, -lnsl or no library at all (ie. -lc), and the user must set LDFLAGS if needed. (2) We no longer add these paths automatically to $(CFLAGS)/$(LIBS). Any part of libguestfs which needs <rpc/*.h> or the xdr_* functions must use $(RPC_CFLAGS)/$(RPC_LIBS) explicitly. (3) Previously Mac OS X had a workaround for the broken 64 bit support in the supplied rpcgen. This workaround "activates" all the time if you use tirpc, so breaking Linux after the above changes. tirpc is supported on OS X, so I think it's just better to...

v1 -> v2: - No functional changes to the patch, just fixes a few bugs. Rich.

v1 was here: https://www.redhat.com/archives/libguestfs/2018-May/msg00042.html v2: - Split into two patches dealing with the different issues. - git format & attribution. I only tested this on Linux but at least it doesn't break things there. Rich.

Hello, I have attached a patch that allowed the build to complete successfully on macOS. I haven't tried building the daemon under macOS, but I patched two files there in a similar manner to some of the other files for consistency (just the include order for rpc headers). Thanks, Adam Robinson Virtualization and Cloud Infrastructure Senior Information and Technology Services University of

...c8584 100644 --- a/daemon/Makefile.am +++ b/daemon/Makefile.am @@ -85,7 +85,6 @@ guestfsd_SOURCES = \ acl.c \ actions.h \ available.c \ - augeas.c \ base64.c \ blkdiscard.c \ blkid.c \ @@ -256,7 +255,6 @@ guestfsd_CPPFLAGS = \ guestfsd_CFLAGS = \ $(WARN_CFLAGS) $(WERROR_CFLAGS) \ $(RPC_CFLAGS) \ - $(AUGEAS_CFLAGS) \ $(HIVEX_CFLAGS) \ $(SD_JOURNAL_CFLAGS) \ $(JANSSON_CFLAGS) \ diff --git a/daemon/augeas.c b/daemon/augeas.c deleted file mode 100644 index d0c6f19a2..000000000 --- a/daemon/augeas.c +++ /dev/null @@ -1,91 +0,0 @@ -/* libguestfs - the guestfsd daemon - * Copyright (C)...

...c8584 100644 --- a/daemon/Makefile.am +++ b/daemon/Makefile.am @@ -85,7 +85,6 @@ guestfsd_SOURCES = \ acl.c \ actions.h \ available.c \ - augeas.c \ base64.c \ blkdiscard.c \ blkid.c \ @@ -256,7 +255,6 @@ guestfsd_CPPFLAGS = \ guestfsd_CFLAGS = \ $(WARN_CFLAGS) $(WERROR_CFLAGS) \ $(RPC_CFLAGS) \ - $(AUGEAS_CFLAGS) \ $(HIVEX_CFLAGS) \ $(SD_JOURNAL_CFLAGS) \ $(JANSSON_CFLAGS) \ diff --git a/daemon/augeas.c b/daemon/augeas.c deleted file mode 100644 index d0c6f19a2..000000000 --- a/daemon/augeas.c +++ /dev/null @@ -1,91 +0,0 @@ -/* libguestfs - the guestfsd daemon - * Copyright (C)...

.../common/errnostring \ -I$(top_builddir)/common/errnostring \ -I$(top_srcdir)/common/protocol \ - -I$(top_builddir)/common/protocol + -I$(top_builddir)/common/protocol \ + -I$(top_srcdir)/common/utils \ + -I$(top_builddir)/common/utils guestfsd_CFLAGS = \ $(WARN_CFLAGS) $(WERROR_CFLAGS) \ $(RPC_CFLAGS) \ diff --git a/daemon/augeas.c b/daemon/augeas.c index 5adc959a5..bd54c4849 100644 --- a/daemon/augeas.c +++ b/daemon/augeas.c @@ -436,7 +436,7 @@ do_aug_ls (const char *path) if (matches == NULL) return NULL; /* do_aug_match has already sent the error */ - sort_strings (matches, coun...

This reimplements the augeas APIs using ocaml-augeas (dropping all the C code). The behaviour seems unchanged, although I may have not tested all the various corner cases. Changes from v2: - dropped patch #1, as it was applied already (was a real bugfix) - rebased on master Pino Toscano (3): Revert "Revert "daemon: implement OptString for OCaml APIs"" daemon: move augeas

This reimplements the augeas APIs using ocaml-augeas (dropping all the C code). The behaviour seems unchanged, although I may have not tested all the various corner cases. Pino Toscano (4): daemon: fix/enhance error reporting of Augeas exceptions Revert "Revert "daemon: implement OptString for OCaml APIs"" daemon: move augeas APIs to OCaml daemon: drop usage of C

This synchronizes the embedded ocaml-augeas copy, and reimplements the augeas APIs using it (dropping all the C code). The behaviour seems unchanged, although I may have not tested all the various corner cases. Pino Toscano (5): common/mlaugeas: Synchronize with latest ocaml-augeas daemon: fix/enhance error reporting of Augeas exceptions Revert "Revert "daemon: implement

This turned out to be rather more involved than I thought. We have lots of utility functions, spread all over the repository, with not a lot of structure. This moves many of them under common/ and structures them so there are clear dependencies. This doesn't complete the job by any means. Other items I had on my to-do list for this change were: - Split up mllib/common_utils into: -

This is a combination of: https://www.redhat.com/archives/libguestfs/2017-June/msg00046.html [PATCH 00/12] Refactor utility functions. plus: https://www.redhat.com/archives/libguestfs/2017-June/msg00023.html [PATCH v3 00/19] Allow APIs to be implemented in OCaml. with the second patches rebased on top of the utility refactoring, and some other adjustments and extensions. This passes

This is just the utilities part of the patch series from: https://www.redhat.com/archives/libguestfs/2017-June/msg00103.html I believe this addresses everything raised in comments on that patch series. Rich.

v5: https://www.redhat.com/archives/libguestfs/2017-June/msg00065.html Since v5, this now implements inspection almost completely for Linux and Windows guests. Rich.

v7 was: https://www.redhat.com/archives/libguestfs/2017-June/msg00169.html https://www.redhat.com/archives/libguestfs/2017-June/msg00184.html I believe this addresses all comments received so far. Also it now passes a test where I compared about 100 disk images processed with old and new virt-inspector binaries. The output is identical in all cases except one which is caused by a bug in blkid