search for: row_common

...> benchmarks mentioned in this thread (among others) would certainly be interesting. Thanks! I only have the one rough data point based on PR32037, but caching does good things for compile-time on that example. Trunk r298514 compiled release on macOS running on Haswell 4GHz: $ time ./opt -O2 row_common.bc -S -o /dev/null user 0m0.302s user 0m0.300s user 0m0.296s user 0m0.299s user 0m0.296s With your patch applied: user 0m0.264s user 0m0.269s user 0m0.269s user 0m0.268s user 0m0.268s So the time for all of -O2 has dropped to 89.6% of the baseline (improvement of 1...

...ong others) would certainly be interesting. >> >> Thanks! I only have the one rough data point based on PR32037, but caching does good things for compile-time on that example. >> >> Trunk r298514 compiled release on macOS running on Haswell 4GHz: >> $ time ./opt -O2 row_common.bc -S -o /dev/null >> >> user 0m0.302s >> user 0m0.300s >> user 0m0.296s >> user 0m0.299s >> user 0m0.296s >> >> With your patch applied: >> >> user 0m0.264s >> user 0m0.269s >> user 0m0.269s >>...

> On Mar 17, 2017, at 6:12 PM, David Majnemer via llvm-dev <llvm-dev at lists.llvm.org> wrote: > > Honestly, I'm not a huge fan of this change as-is. The set of transforms that were added behind ExpensiveChecks seems awfully strange and many would not lead the reader to believe that they are expensive at all (the SimplifyDemandedInstructionBits and foldICmpUsingKnownBits calls