search for: rounddown

Displaying 20 results from an estimated 67 matches for "rounddown".

Did you mean: round_down
2018 Apr 04
2
nouveau TRAP_M2MF still there on G98
...NVS 160M]. Besides – I'm a geographer not a programmer > ;-) And I'm, it seems, servant of a particular cat, all else being secondary. :p > Still your report makes to question the original commit I was fixing > (mmu: swap out round for ALIGN). Could you test if going back to > rounddown fixes problem on your side? > > --- a/drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmm.c > +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmm.c > @@ -1354,7 +1354,7 @@ nvkm_vmm_get_locked(struct nvkm_vmm *vmm, bool > getref, bool mapref, bool sparse, > > tail = this...
2016 May 24
2
[PATCH RFC kernel] balloon: speed up inflating/deflating process
...re(vb->vdev, > > > VIRTIO_BALLOON_F_PAGE_BITMAP)) { > > > > + u32 page_shift = PAGE_SHIFT; > > > > + unsigned long start_pfn, end_pfn, flags = 0, bmap_len; > > > > + struct scatterlist sg[5]; > > > > + > > > > + start_pfn = rounddown(vb->start_pfn, BITS_PER_LONG); > > > > + end_pfn = roundup(vb->end_pfn, BITS_PER_LONG); > > > > + bmap_len = (end_pfn - start_pfn) / BITS_PER_LONG * > > > sizeof(long); > > > > + > > > > + sg_init_table(sg, 5); > > > > +...
2016 May 24
2
[PATCH RFC kernel] balloon: speed up inflating/deflating process
...re(vb->vdev, > > > VIRTIO_BALLOON_F_PAGE_BITMAP)) { > > > > + u32 page_shift = PAGE_SHIFT; > > > > + unsigned long start_pfn, end_pfn, flags = 0, bmap_len; > > > > + struct scatterlist sg[5]; > > > > + > > > > + start_pfn = rounddown(vb->start_pfn, BITS_PER_LONG); > > > > + end_pfn = roundup(vb->end_pfn, BITS_PER_LONG); > > > > + bmap_len = (end_pfn - start_pfn) / BITS_PER_LONG * > > > sizeof(long); > > > > + > > > > + sg_init_table(sg, 5); > > > > +...
2016 May 24
3
[PATCH RFC kernel] balloon: speed up inflating/deflating process
...we limit the page bitmap size? Is it no good to send a large page bitmap? or to save the memory used for page bitmap? Or some other reason? > > > > > + unsigned long start_pfn, end_pfn, flags = 0, bmap_len; > > + struct scatterlist sg[5]; > > + > > + start_pfn = rounddown(vb->start_pfn, BITS_PER_LONG); > > + end_pfn = roundup(vb->end_pfn, BITS_PER_LONG); > > + bmap_len = (end_pfn - start_pfn) / BITS_PER_LONG * > sizeof(long); > > + > > + sg_init_table(sg, 5); > > + sg_set_buf(&sg[0], &flags, sizeof(flags)); > &gt...
2016 May 24
3
[PATCH RFC kernel] balloon: speed up inflating/deflating process
...we limit the page bitmap size? Is it no good to send a large page bitmap? or to save the memory used for page bitmap? Or some other reason? > > > > > + unsigned long start_pfn, end_pfn, flags = 0, bmap_len; > > + struct scatterlist sg[5]; > > + > > + start_pfn = rounddown(vb->start_pfn, BITS_PER_LONG); > > + end_pfn = roundup(vb->end_pfn, BITS_PER_LONG); > > + bmap_len = (end_pfn - start_pfn) / BITS_PER_LONG * > sizeof(long); > > + > > + sg_init_table(sg, 5); > > + sg_set_buf(&sg[0], &flags, sizeof(flags)); > &gt...
2018 Apr 04
0
nouveau TRAP_M2MF still there on G98
...atch fixed issue on my system and thus I have no means to test anything more. My card is G98M [Quadro NVS 160M]. Besides – I'm a geographer not a programmer ;-) Still your report makes to question the original commit I was fixing (mmu: swap out round for ALIGN). Could you test if going back to rounddown fixes problem on your side? --- a/drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmm.c +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmm.c @@ -1354,7 +1354,7 @@ nvkm_vmm_get_locked(struct nvkm_vmm *vmm, bool getref, bool mapref, bool sparse, tail = this->addr + this->size;...
2018 Apr 04
0
nouveau TRAP_M2MF still there on G98
...a geographer not a programmer >> ;-) > > And I'm, it seems, servant of a particular cat, all else being secondary. :p > >> Still your report makes to question the original commit I was fixing >> (mmu: swap out round for ALIGN). Could you test if going back to >> rounddown fixes problem on your side? >> >> --- a/drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmm.c >> +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmm.c >> @@ -1354,7 +1354,7 @@ nvkm_vmm_get_locked(struct nvkm_vmm *vmm, bool >> getref, bool mapref, bool sparse, >> >>...
2018 Apr 03
2
nouveau TRAP_M2MF still there on G98
Hi! In commit da5e45e619b3f101420c38b3006a9ae4f3ad19b0: > drm/nouveau/mmu: ALIGN_DOWN correct variable > > Commit 7110c89bb8852ff8b0f88ce05b332b3fe22bd11e ("mmu: swap out round > for ALIGN") replaced two calls to round/rounddown with ALIGN/ALIGN_DOWN, > but erroneously applied ALIGN_DOWN to a different variable (addr) and left > intended variable (tail) not rounded/ALIGNed. > > As a result screen corruption, X lockups are observable. An example of kernel > log of affected system with NV98 card where it...
2016 May 24
0
[PATCH RFC kernel] balloon: speed up inflating/deflating process
...> VIRTIO_BALLOON_F_PAGE_BITMAP)) { > > > > > + u32 page_shift = PAGE_SHIFT; > > > > > + unsigned long start_pfn, end_pfn, flags = 0, bmap_len; > > > > > + struct scatterlist sg[5]; > > > > > + > > > > > + start_pfn = rounddown(vb->start_pfn, BITS_PER_LONG); > > > > > + end_pfn = roundup(vb->end_pfn, BITS_PER_LONG); > > > > > + bmap_len = (end_pfn - start_pfn) / BITS_PER_LONG * > > > > sizeof(long); > > > > > + > > > > > + sg_init_table(sg, 5...
2016 Jul 27
2
[PATCH v2 repost 4/7] virtio-balloon: speed up inflate/deflate process
...t; -static unsigned fill_balloon(struct virtio_balloon *vb, size_t num) > +static void set_page_bitmap(struct virtio_balloon *vb, > + struct list_head *pages, struct virtqueue *vq) > +{ > + unsigned long pfn; > + struct page *page; > + bool found; > + > + vb->min_pfn = rounddown(vb->min_pfn, BITS_PER_LONG); > + vb->max_pfn = roundup(vb->max_pfn, BITS_PER_LONG); > + for (pfn = vb->min_pfn; pfn < vb->max_pfn; > + pfn += vb->pfn_limit) { > + vb->start_pfn = pfn + vb->pfn_limit; > + vb->end_pfn = pfn; > + memset(vb->page_...
2016 Jul 27
2
[PATCH v2 repost 4/7] virtio-balloon: speed up inflate/deflate process
...t; -static unsigned fill_balloon(struct virtio_balloon *vb, size_t num) > +static void set_page_bitmap(struct virtio_balloon *vb, > + struct list_head *pages, struct virtqueue *vq) > +{ > + unsigned long pfn; > + struct page *page; > + bool found; > + > + vb->min_pfn = rounddown(vb->min_pfn, BITS_PER_LONG); > + vb->max_pfn = roundup(vb->max_pfn, BITS_PER_LONG); > + for (pfn = vb->min_pfn; pfn < vb->max_pfn; > + pfn += vb->pfn_limit) { > + vb->start_pfn = pfn + vb->pfn_limit; > + vb->end_pfn = pfn; > + memset(vb->page_...
2016 May 20
6
[PATCH RFC kernel] balloon: speed up inflating/deflating process
...ed int len; - sg_init_one(&sg, vb->pfns, sizeof(vb->pfns[0]) * vb->num_pfns); + if (virtio_has_feature(vb->vdev, VIRTIO_BALLOON_F_PAGE_BITMAP)) { + u32 page_shift = PAGE_SHIFT; + unsigned long start_pfn, end_pfn, flags = 0, bmap_len; + struct scatterlist sg[5]; + + start_pfn = rounddown(vb->start_pfn, BITS_PER_LONG); + end_pfn = roundup(vb->end_pfn, BITS_PER_LONG); + bmap_len = (end_pfn - start_pfn) / BITS_PER_LONG * sizeof(long); + + sg_init_table(sg, 5); + sg_set_buf(&sg[0], &flags, sizeof(flags)); + sg_set_buf(&sg[1], &start_pfn, sizeof(start_pfn)); +...
2016 May 20
6
[PATCH RFC kernel] balloon: speed up inflating/deflating process
...ed int len; - sg_init_one(&sg, vb->pfns, sizeof(vb->pfns[0]) * vb->num_pfns); + if (virtio_has_feature(vb->vdev, VIRTIO_BALLOON_F_PAGE_BITMAP)) { + u32 page_shift = PAGE_SHIFT; + unsigned long start_pfn, end_pfn, flags = 0, bmap_len; + struct scatterlist sg[5]; + + start_pfn = rounddown(vb->start_pfn, BITS_PER_LONG); + end_pfn = roundup(vb->end_pfn, BITS_PER_LONG); + bmap_len = (end_pfn - start_pfn) / BITS_PER_LONG * sizeof(long); + + sg_init_table(sg, 5); + sg_set_buf(&sg[0], &flags, sizeof(flags)); + sg_set_buf(&sg[1], &start_pfn, sizeof(start_pfn)); +...
2016 Jul 27
0
[PATCH v2 repost 4/7] virtio-balloon: speed up inflate/deflate process
...page_to_balloon_pfn(page) + i); } -static unsigned fill_balloon(struct virtio_balloon *vb, size_t num) +static void set_page_bitmap(struct virtio_balloon *vb, + struct list_head *pages, struct virtqueue *vq) +{ + unsigned long pfn; + struct page *page; + bool found; + + vb->min_pfn = rounddown(vb->min_pfn, BITS_PER_LONG); + vb->max_pfn = roundup(vb->max_pfn, BITS_PER_LONG); + for (pfn = vb->min_pfn; pfn < vb->max_pfn; + pfn += vb->pfn_limit) { + vb->start_pfn = pfn + vb->pfn_limit; + vb->end_pfn = pfn; + memset(vb->page_bitmap, 0, vb->bmap_len); +...
2018 Mar 03
0
[PATCH] mmu: ALIGN_DOWN correct variable
Commit 7110c89bb8852ff8b0f88ce05b332b3fe22bd11e ("mmu: swap out round for ALIGN") replaced two calls to round/rounddown with ALIGN/ALIGN_DOWN, but erroneously applied ALIGN_DOWN to a different variable (addr) and left intended variable (tail) not rounded/ALIGNed. As a result screen corruption, X lockups are observable. An example of kernel log of affected system with NV98 card where it was bisected: nouveau 0000:0...
2016 May 24
0
[PATCH RFC kernel] balloon: speed up inflating/deflating process
...fail, second this is pinned memory that is wasted - it's unused most of the time while guest is running. > > > > > > > > + unsigned long start_pfn, end_pfn, flags = 0, bmap_len; > > > + struct scatterlist sg[5]; > > > + > > > + start_pfn = rounddown(vb->start_pfn, BITS_PER_LONG); > > > + end_pfn = roundup(vb->end_pfn, BITS_PER_LONG); > > > + bmap_len = (end_pfn - start_pfn) / BITS_PER_LONG * > > sizeof(long); > > > + > > > + sg_init_table(sg, 5); > > > + sg_set_buf(&sg[0], &f...
2016 May 25
1
[PATCH RFC kernel] balloon: speed up inflating/deflating process
...d - it's unused most of the time while guest is running. Make sense. > > > > > > > > > > > > + unsigned long start_pfn, end_pfn, flags = 0, bmap_len; > > > > + struct scatterlist sg[5]; > > > > + > > > > + start_pfn = rounddown(vb->start_pfn, BITS_PER_LONG); > > > > + end_pfn = roundup(vb->end_pfn, BITS_PER_LONG); > > > > + bmap_len = (end_pfn - start_pfn) / BITS_PER_LONG * > > > sizeof(long); > > > > + > > > > + sg_init_table(sg, 5); > > > > +...
2016 May 25
1
[PATCH RFC kernel] balloon: speed up inflating/deflating process
...d - it's unused most of the time while guest is running. Make sense. > > > > > > > > > > > > + unsigned long start_pfn, end_pfn, flags = 0, bmap_len; > > > > + struct scatterlist sg[5]; > > > > + > > > > + start_pfn = rounddown(vb->start_pfn, BITS_PER_LONG); > > > > + end_pfn = roundup(vb->end_pfn, BITS_PER_LONG); > > > > + bmap_len = (end_pfn - start_pfn) / BITS_PER_LONG * > > > sizeof(long); > > > > + > > > > + sg_init_table(sg, 5); > > > > +...
2016 May 20
0
[PATCH RFC kernel] balloon: speed up inflating/deflating process
...mp;sg, vb->pfns, sizeof(vb->pfns[0]) * vb->num_pfns); > + if (virtio_has_feature(vb->vdev, VIRTIO_BALLOON_F_PAGE_BITMAP)) { > + u32 page_shift = PAGE_SHIFT; > + unsigned long start_pfn, end_pfn, flags = 0, bmap_len; > + struct scatterlist sg[5]; > + > + start_pfn = rounddown(vb->start_pfn, BITS_PER_LONG); > + end_pfn = roundup(vb->end_pfn, BITS_PER_LONG); > + bmap_len = (end_pfn - start_pfn) / BITS_PER_LONG * sizeof(long); > + > + sg_init_table(sg, 5); > + sg_set_buf(&sg[0], &flags, sizeof(flags)); > + sg_set_buf(&sg[1], &st...
2016 Jul 27
1
[PATCH v2 repost 4/7] virtio-balloon: speed up inflate/deflate process
...t; -static unsigned fill_balloon(struct virtio_balloon *vb, size_t num) > +static void set_page_bitmap(struct virtio_balloon *vb, > + struct list_head *pages, struct virtqueue *vq) > +{ > + unsigned long pfn; > + struct page *page; > + bool found; > + > + vb->min_pfn = rounddown(vb->min_pfn, BITS_PER_LONG); > + vb->max_pfn = roundup(vb->max_pfn, BITS_PER_LONG); > + for (pfn = vb->min_pfn; pfn < vb->max_pfn; > + pfn += vb->pfn_limit) { > + vb->start_pfn = pfn + vb->pfn_limit; > + vb->end_pfn = pfn; > + memset(vb->page_...