search for: rndis_filter_device_add

netif_carrier_off() was called earlier in this function, and there is no other thread access this device yet. The status checking code is not necessary here. Signed-off-by: Haiyang Zhang <haiyangz at microsoft.com> Signed-off-by: K. Y. Srinivasan <kys at microsoft.com> Signed-off-by: Abhishek Kane <v-abkane at microsoft.com> Signed-off-by: Hank Janssen <hjanssen at

netif_carrier_off() was called earlier in this function, and there is no other thread access this device yet. The status checking code is not necessary here. Signed-off-by: Haiyang Zhang <haiyangz at microsoft.com> Signed-off-by: K. Y. Srinivasan <kys at microsoft.com> Signed-off-by: Abhishek Kane <v-abkane at microsoft.com> Signed-off-by: Hank Janssen <hjanssen at

Address Greg's VmBus audit comments: 1) Leverage driver_data field in struct hv_vmbus_device_id to simplify driver code. 2) Make the util driver conform to the Linux Driver Model. 3) Get rid of the ext field in struct hv_device by using the driver specific data functionality. 4) Other general cleanup. Regards, K. Y

Address Greg's VmBus audit comments: 1) Leverage driver_data field in struct hv_vmbus_device_id to simplify driver code. 2) Make the util driver conform to the Linux Driver Model. 3) Get rid of the ext field in struct hv_device by using the driver specific data functionality. 4) Other general cleanup. Regards, K. Y

hyperv_net: - set min/max_mtu, per Haiyang, after rndis_filter_device_add virtio_net: - set min/max_mtu - remove virtnet_change_mtu vmxnet3: - set min/max_mtu xen-netback: - min_mtu = 0, max_mtu = 65517 xen-netfront: - min_mtu = 0, max_mtu = 65535 unisys/visor: - clean up defines a little to not clash with network core or add redundat definitions CC: netdev at vg...

hyperv_net: - set min/max_mtu, per Haiyang, after rndis_filter_device_add virtio_net: - set min/max_mtu - remove virtnet_change_mtu vmxnet3: - set min/max_mtu xen-netback: - min_mtu = 0, max_mtu = 65517 xen-netfront: - min_mtu = 0, max_mtu = 65535 unisys/visor: - clean up defines a little to not clash with network core or add redundat definitions CC: netdev at vg...

...t; + if (nvdev->nvsp_version >= NVSP_PROTOCOL_VERSION_2) > + net->max_mtu = NETVSC_MTU - ETH_HLEN; > + else > + net->max_mtu = ETH_DATA_LEN; > + > netvsc_init_settings(net); > > net_device_ctx = netdev_priv(net); nvdev->nvsp_version is not set until after rndis_filter_device_add() is successfully completed. You need to move this part to the place just before this line: ret = register_netdev(net); Thanks, - Haiyang

...if (chn_index >= nvscdev->num_chn) return; - set_per_channel_state(new_sc, nvscdev->sub_cb_buf + (chn_index - 1) * - NETVSC_PACKET_SIZE); - nvscdev->mrc[chn_index].buf = vzalloc(NETVSC_RECVSLOT_MAX * sizeof(struct recv_comp_data)); @@ -1099,14 +1096,6 @@ int rndis_filter_device_add(struct hv_device *dev, if (net_device->num_chn == 1) goto out; - net_device->sub_cb_buf = vzalloc((net_device->num_chn - 1) * - NETVSC_PACKET_SIZE); - if (!net_device->sub_cb_buf) { - net_device->num_chn = 1; - dev_info(&dev->device, "No memory for subchanne...

hyperv_net: - set min/max_mtu virtio_net: - set min/max_mtu - remove virtnet_change_mtu vmxnet3: - set min/max_mtu CC: netdev at vger.kernel.org CC: virtualization at lists.linux-foundation.org CC: "K. Y. Srinivasan" <kys at microsoft.com> CC: Haiyang Zhang <haiyangz at microsoft.com> CC: "Michael S. Tsirkin" <mst at redhat.com> CC: Shrikrishna Khare

hyperv_net: - set min/max_mtu virtio_net: - set min/max_mtu - remove virtnet_change_mtu vmxnet3: - set min/max_mtu CC: netdev at vger.kernel.org CC: virtualization at lists.linux-foundation.org CC: "K. Y. Srinivasan" <kys at microsoft.com> CC: Haiyang Zhang <haiyangz at microsoft.com> CC: "Michael S. Tsirkin" <mst at redhat.com> CC: Shrikrishna Khare

...return; > > - set_per_channel_state(new_sc, nvscdev->sub_cb_buf + (chn_index > - 1) * > - NETVSC_PACKET_SIZE); > - > nvscdev->mrc[chn_index].buf = vzalloc(NETVSC_RECVSLOT_MAX * > sizeof(struct recv_comp_data)); > > @@ -1099,14 +1096,6 @@ int rndis_filter_device_add(struct hv_device > *dev, > if (net_device->num_chn == 1) > goto out; > > - net_device->sub_cb_buf = vzalloc((net_device->num_chn - 1) * > - NETVSC_PACKET_SIZE); > - if (!net_device->sub_cb_buf) { > - net_device->num_chn = 1; > - dev_info(&d...

...return; > > - set_per_channel_state(new_sc, nvscdev->sub_cb_buf + (chn_index > - 1) * > - NETVSC_PACKET_SIZE); > - > nvscdev->mrc[chn_index].buf = vzalloc(NETVSC_RECVSLOT_MAX * > sizeof(struct recv_comp_data)); > > @@ -1099,14 +1096,6 @@ int rndis_filter_device_add(struct hv_device > *dev, > if (net_device->num_chn == 1) > goto out; > > - net_device->sub_cb_buf = vzalloc((net_device->num_chn - 1) * > - NETVSC_PACKET_SIZE); > - if (!net_device->sub_cb_buf) { > - net_device->num_chn = 1; > - dev_info(&d...

On Thu, Oct 20, 2016 at 01:55:21PM -0400, Jarod Wilson wrote: > hyperv_net: > - set min/max_mtu, per Haiyang, after rndis_filter_device_add > > virtio_net: > - set min/max_mtu > - remove virtnet_change_mtu > vmxnet3: > - set min/max_mtu > > xen-netback: > - min_mtu = 0, max_mtu = 65517 > > xen-netfront: > - min_mtu = 0, max_mtu = 65535 > > unisys/visor: > - clean up defines a little to n...

Fixed a set of bugs in netvsc module, and cleaned up some coding style issues. Haiyang Zhang (10): staging: hv: remove unnecessary includes in netvsc staging: hv: add newline to log messages in netvsc staging: hv: convert dev_<loglevel> to netdev_<loglevel> in netvsc staging: hv: fix a kernel warning in netvsc_linkstatus_callback() staging: hv: re-order the code in

Fixed a set of bugs in netvsc module, and cleaned up some coding style issues. Haiyang Zhang (10): staging: hv: remove unnecessary includes in netvsc staging: hv: add newline to log messages in netvsc staging: hv: convert dev_<loglevel> to netdev_<loglevel> in netvsc staging: hv: fix a kernel warning in netvsc_linkstatus_callback() staging: hv: re-order the code in

Fixed a set of bugs in netvsc module, and cleaned up some coding style issues. Haiyang Zhang (9): staging: hv: remove unnecessary includes in netvsc staging: hv: add newline to log messages in netvsc staging: hv: convert dev_<loglevel> to netdev_<loglevel> in netvsc staging: hv: fix a kernel warning in netvsc_linkstatus_callback() staging: hv: re-order the code in

Fixed a set of bugs in netvsc module, and cleaned up some coding style issues. Haiyang Zhang (9): staging: hv: remove unnecessary includes in netvsc staging: hv: add newline to log messages in netvsc staging: hv: convert dev_<loglevel> to netdev_<loglevel> in netvsc staging: hv: fix a kernel warning in netvsc_linkstatus_callback() staging: hv: re-order the code in

This is a rebase/resend of earlier patches. I skipped the pure cosmetic patches for now. Mostly this is consolidation earlier changes, removing dead code etc. The important part is the change for allowing a vmbus channel to get callback directly in interrupt mode; this is necessary for NAPI support. Stephen Hemminger (14): vmbus: use kernel bitops for traversing interrupt mask vmbus: drop

This is a rebase/resend of earlier patches. I skipped the pure cosmetic patches for now. Mostly this is consolidation earlier changes, removing dead code etc. The important part is the change for allowing a vmbus channel to get callback directly in interrupt mode; this is necessary for NAPI support. Stephen Hemminger (14): vmbus: use kernel bitops for traversing interrupt mask vmbus: drop

Further cleanup of the hv drivers. 1) Implement code for autoloading the vmbus drivers without using PCI or DMI signatures. I have implemented this based on Greg's feedback on my earlier implementation. 2) Cleanup error handling across the board and use standard Linux error codes. 3) General cleanup Regards, K. Y