search for: rms_percentile

I noticed that 32-bit flac (from git) compiled with GCC 4.8.3 or 4.9.0 calculates incorrect ReplayGain values. The most common value it produces is -55.17 dB. It is possible to avoid this bug by compiling src/share/replaygain_analysis/replaygain_analysis.c a) either without -msse2 option b) or with -O2 instead of -O3 c) another solution is to add -mfpmath=sse option along with -msse2. For GCC

lvqcl wrote: > I noticed that 32-bit flac (from git) compiled with GCC 4.8.3 or 4.9.0 > calculates incorrect ReplayGain values. The most common value it produces > is -55.17 dB. It seems that it's a bug in GCC: it cannot correctly calculate the value of 'elems * (1. - RMS_PERCENTILE)' in the line upper = (Int32_t) ceil (elems * (1. - RMS_PERCENTILE)); Since elems * (1. - RMS_PERCENTILE) == elems * (1. - 0.95) == == elems * 0.05 == elems / 20.0 it is possible to replace ceil(...) with (elems / 20 + (elems % 20) ? 1 : 0). Patch attached. -------------- next part...

...lt;string.h> -#include <math.h> - -#include "replaygain_analysis.h" - -typedef unsigned short Uint16_t; -typedef signed short Int16_t; -typedef unsigned int Uint32_t; -typedef signed int Int32_t; - -#define YULE_ORDER 10 -#define BUTTER_ORDER 2 -#define RMS_PERCENTILE 0.95 /* percentile which is louder than the proposed level */ -#define MAX_SAMP_FREQ 48000. /* maximum allowed sample frequency [Hz] */ -#define RMS_WINDOW_TIME 0.050 /* Time slice size [s] */ -#define STEPS_per_dB 100. /* Table entries per dB */ -#def...

The replay gain code has dos line endings in CVS, which causes problems for the Sun compiler, among others. Attached is a patch for the lazy, but it's probably easier to fix locally and commit. -r

Erik de Castro Lopo wrote: >> 3) configure.ac, line 140: 'AM_CONDITIONAL(FLAC__CPU_X86_64, test "x$cpu_x86_64" = xtrue)' >> >> Not sure about this, but other names inside AM_CONDITIONALs begin with FLaC__, >> not FLAC__. A quote from configure.ac: "NOTE that for many of the AM_CONDITIONALs >> we use the prefix FLaC__ instead of FLAC__ since