search for: ring_pack

...we get callbacks when the ring is completely used, even if we've >@@ -71,4 +71,20 @@ > * this is for compatibility with legacy systems. > */ > #define VIRTIO_F_IOMMU_PLATFORM 33 >+ >+/* This feature indicates support for the packed virtqueue layout. */ >+#define VIRTIO_F_RING_PACKED 34 Spec says VIRTIO_F_PACKED_RING not RING_PACKED >+ >+/* >+ * This feature indicates that all buffers are used by the device >+ * in the same order in which they have been made available. >+ */ >+#define VIRTIO_F_IN_ORDER 35 >+ >+/* >+ * This feature indicates that...

...en DMA API isn't used (MST/Jason); > > - Define wrap counter as bool (Jason); > > - Use ALIGN() in vring_init_packed() (Jason); > > - Avoid using pointer to track `next` in detach_buf_packed() (Jason); > > - Add comments for barriers (Jason); > > - Don't enable RING_PACKED on ccw for now (noticed by Jason); > > - Refine the memory barrier in virtqueue_poll(); > > - Add a missing memory barrier in virtqueue_enable_cb_delayed_packed(); > > - Remove the hacks in virtqueue_enable_cb_prepare_packed(); > > > > RFC v4 -> RFC v5: > >...

...gt; > - Define wrap counter as bool (Jason); > > > > - Use ALIGN() in vring_init_packed() (Jason); > > > > - Avoid using pointer to track `next` in detach_buf_packed() (Jason); > > > > - Add comments for barriers (Jason); > > > > - Don't enable RING_PACKED on ccw for now (noticed by Jason); > > > > - Refine the memory barrier in virtqueue_poll(); > > > > - Add a missing memory barrier in virtqueue_enable_cb_delayed_packed(); > > > > - Remove the hacks in virtqueue_enable_cb_prepare_packed(); > > > >...

...structure (MST); > - Calculate AVAIL/USED flags only when wrap counter wraps (MST); > - Define a struct/union to read event structure (MST); > - Define a macro for wrap counter bit in uapi (MST); > - Define the AVAIL/USED bits as shifts instead of values (MST); > - s/_F_/_FLAG_/ in VRING_PACKED_EVENT_* as they are values (MST); > - Drop the notify workaround for QEMU's tx-timer in packed ring (MST); > > v1 -> v2: > - Use READ_ONCE() to read event off_wrap and flags together (Jason); > - Add comments related to ccw (Jason); > > RFC v6 -> v1: > - Avoid...

...Jason); > > > > > > - Use ALIGN() in vring_init_packed() (Jason); > > > > > > - Avoid using pointer to track `next` in detach_buf_packed() (Jason); > > > > > > - Add comments for barriers (Jason); > > > > > > - Don't enable RING_PACKED on ccw for now (noticed by Jason); > > > > > > - Refine the memory barrier in virtqueue_poll(); > > > > > > - Add a missing memory barrier in virtqueue_enable_cb_delayed_packed(); > > > > > > - Remove the hacks in virtqueue_enable_cb_prepare_p...

...structure (MST); > - Calculate AVAIL/USED flags only when wrap counter wraps (MST); > - Define a struct/union to read event structure (MST); > - Define a macro for wrap counter bit in uapi (MST); > - Define the AVAIL/USED bits as shifts instead of values (MST); > - s/_F_/_FLAG_/ in VRING_PACKED_EVENT_* as they are values (MST); > - Drop the notify workaround for QEMU's tx-timer in packed ring (MST); > > v1 -> v2: > - Use READ_ONCE() to read event off_wrap and flags together (Jason); > - Add comments related to ccw (Jason); > > RFC v6 -> v1: > - Avoid...

...(MST/Jason); > > > - Define wrap counter as bool (Jason); > > > - Use ALIGN() in vring_init_packed() (Jason); > > > - Avoid using pointer to track `next` in detach_buf_packed() (Jason); > > > - Add comments for barriers (Jason); > > > - Don't enable RING_PACKED on ccw for now (noticed by Jason); > > > - Refine the memory barrier in virtqueue_poll(); > > > - Add a missing memory barrier in virtqueue_enable_cb_delayed_packed(); > > > - Remove the hacks in virtqueue_enable_cb_prepare_packed(); > > > > > > RFC v...

...> - Define wrap counter as bool (Jason); >>>>> - Use ALIGN() in vring_init_packed() (Jason); >>>>> - Avoid using pointer to track `next` in detach_buf_packed() (Jason); >>>>> - Add comments for barriers (Jason); >>>>> - Don't enable RING_PACKED on ccw for now (noticed by Jason); >>>>> - Refine the memory barrier in virtqueue_poll(); >>>>> - Add a missing memory barrier in virtqueue_enable_cb_delayed_packed(); >>>>> - Remove the hacks in virtqueue_enable_cb_prepare_packed(); >>>>&g...

...t; - Calculate AVAIL/USED flags only when wrap counter wraps (MST); > > - Define a struct/union to read event structure (MST); > > - Define a macro for wrap counter bit in uapi (MST); > > - Define the AVAIL/USED bits as shifts instead of values (MST); > > - s/_F_/_FLAG_/ in VRING_PACKED_EVENT_* as they are values (MST); > > - Drop the notify workaround for QEMU's tx-timer in packed ring (MST); > > > > v1 -> v2: > > - Use READ_ONCE() to read event off_wrap and flags together (Jason); > > - Add comments related to ccw (Jason); > > >...

...t; > > > > - Use ALIGN() in vring_init_packed() (Jason); > > > > > > > - Avoid using pointer to track `next` in detach_buf_packed() (Jason); > > > > > > > - Add comments for barriers (Jason); > > > > > > > - Don't enable RING_PACKED on ccw for now (noticed by Jason); > > > > > > > - Refine the memory barrier in virtqueue_poll(); > > > > > > > - Add a missing memory barrier in virtqueue_enable_cb_delayed_packed(); > > > > > > > - Remove the hacks in virtqueue_enab...

...t; > - Use ALIGN() in vring_init_packed() (Jason); > > > > > > > > - Avoid using pointer to track `next` in detach_buf_packed() (Jason); > > > > > > > > - Add comments for barriers (Jason); > > > > > > > > - Don't enable RING_PACKED on ccw for now (noticed by Jason); > > > > > > > > - Refine the memory barrier in virtqueue_poll(); > > > > > > > > - Add a missing memory barrier in virtqueue_enable_cb_delayed_packed(); > > > > > > > > - Remove the hacks in...

...elated info in a separate structure (MST); - Calculate AVAIL/USED flags only when wrap counter wraps (MST); - Define a struct/union to read event structure (MST); - Define a macro for wrap counter bit in uapi (MST); - Define the AVAIL/USED bits as shifts instead of values (MST); - s/_F_/_FLAG_/ in VRING_PACKED_EVENT_* as they are values (MST); - Drop the notify workaround for QEMU's tx-timer in packed ring (MST); v1 -> v2: - Use READ_ONCE() to read event off_wrap and flags together (Jason); - Add comments related to ccw (Jason); RFC v6 -> v1: - Avoid extra virtio_wmb() in virtqueue_enable_c...

...elated info in a separate structure (MST); - Calculate AVAIL/USED flags only when wrap counter wraps (MST); - Define a struct/union to read event structure (MST); - Define a macro for wrap counter bit in uapi (MST); - Define the AVAIL/USED bits as shifts instead of values (MST); - s/_F_/_FLAG_/ in VRING_PACKED_EVENT_* as they are values (MST); - Drop the notify workaround for QEMU's tx-timer in packed ring (MST); v1 -> v2: - Use READ_ONCE() to read event off_wrap and flags together (Jason); - Add comments related to ccw (Jason); RFC v6 -> v1: - Avoid extra virtio_wmb() in virtqueue_enable_c...

...5 -> RFC v6: - Avoid tracking addr/len/flags when DMA API isn't used (MST/Jason); - Define wrap counter as bool (Jason); - Use ALIGN() in vring_init_packed() (Jason); - Avoid using pointer to track `next` in detach_buf_packed() (Jason); - Add comments for barriers (Jason); - Don't enable RING_PACKED on ccw for now (noticed by Jason); - Refine the memory barrier in virtqueue_poll(); - Add a missing memory barrier in virtqueue_enable_cb_delayed_packed(); - Remove the hacks in virtqueue_enable_cb_prepare_packed(); RFC v4 -> RFC v5: - Save DMA addr, etc in desc state (Jason); - Track used wr...

...5 -> RFC v6: - Avoid tracking addr/len/flags when DMA API isn't used (MST/Jason); - Define wrap counter as bool (Jason); - Use ALIGN() in vring_init_packed() (Jason); - Avoid using pointer to track `next` in detach_buf_packed() (Jason); - Add comments for barriers (Jason); - Don't enable RING_PACKED on ccw for now (noticed by Jason); - Refine the memory barrier in virtqueue_poll(); - Add a missing memory barrier in virtqueue_enable_cb_delayed_packed(); - Remove the hacks in virtqueue_enable_cb_prepare_packed(); RFC v4 -> RFC v5: - Save DMA addr, etc in desc state (Jason); - Track used wr...

...5 -> RFC v6: - Avoid tracking addr/len/flags when DMA API isn't used (MST/Jason); - Define wrap counter as bool (Jason); - Use ALIGN() in vring_init_packed() (Jason); - Avoid using pointer to track `next` in detach_buf_packed() (Jason); - Add comments for barriers (Jason); - Don't enable RING_PACKED on ccw for now (noticed by Jason); - Refine the memory barrier in virtqueue_poll(); - Add a missing memory barrier in virtqueue_enable_cb_delayed_packed(); - Remove the hacks in virtqueue_enable_cb_prepare_packed(); RFC v4 -> RFC v5: - Save DMA addr, etc in desc state (Jason); - Track used wr...

...5 -> RFC v6: - Avoid tracking addr/len/flags when DMA API isn't used (MST/Jason); - Define wrap counter as bool (Jason); - Use ALIGN() in vring_init_packed() (Jason); - Avoid using pointer to track `next` in detach_buf_packed() (Jason); - Add comments for barriers (Jason); - Don't enable RING_PACKED on ccw for now (noticed by Jason); - Refine the memory barrier in virtqueue_poll(); - Add a missing memory barrier in virtqueue_enable_cb_delayed_packed(); - Remove the hacks in virtqueue_enable_cb_prepare_packed(); RFC v4 -> RFC v5: - Save DMA addr, etc in desc state (Jason); - Track used wr...

Hello everyone, This RFC implements a subset of packed ring which is described at https://github.com/oasis-tcs/virtio-docs/blob/master/virtio-v1.1-packed-wd08.pdf The code was tested with DPDK vhost (testpmd/vhost-PMD) implemented by Jens at http://dpdk.org/ml/archives/dev/2018-January/089417.html Minor changes are needed for the vhost code, e.g. to kick the guest. It's not a complete