search for: rhbz563450

...xposed by the test case in RHBZ#563450) - the result of list-devices now reflects the order images were added (RHBZ#563450) Add two small regression tests for the fixes described above. --- src/drives.c | 7 +----- tests/regressions/Makefile.am | 2 ++ tests/regressions/rhbz563450.sh | 54 ++++++++++++++++++++++++++++++++++++++++ tests/regressions/rhbz563450b.sh | 43 ++++++++++++++++++++++++++++++++ 4 files changed, 100 insertions(+), 6 deletions(-) create mode 100755 tests/regressions/rhbz563450.sh create mode 100755 tests/regressions/rhbz563450b.sh diff --git a/src/dr...

On Wednesday 18 December 2013 20:44:33 Richard W.M. Jones wrote: > On Fri, Dec 13, 2013 at 04:32:49PM +0100, Pino Toscano wrote: > > diff --git a/tests/regressions/rhbz563450.sh > > b/tests/regressions/rhbz563450.sh new file mode 100755 > > index 0000000..6fa6f2b > > --- /dev/null > > +++ b/tests/regressions/rhbz563450.sh > > @@ -0,0 +1,54 @@ > > +#!/bin/bash - > > +# libguestfs > > +# Copyright (C) 2013 Red Hat Inc. >...

...57f50 and removed in be025369ad622867ecf08d5c9170e8e59d2d6294; now they should work with any backend, as the device names are normalised and not change the guestfish output depending on the used backend. Thanks Richard for the hints. --- tests/regressions/Makefile.am | 2 ++ tests/regressions/rhbz563450.sh | 59 ++++++++++++++++++++++++++++++++++++++++ tests/regressions/rhbz563450b.sh | 48 ++++++++++++++++++++++++++++++++ 3 files changed, 109 insertions(+) create mode 100755 tests/regressions/rhbz563450.sh create mode 100755 tests/regressions/rhbz563450b.sh diff --git a/tests/regressions/Make...

...add_drive_ro (instead of add_drive), with its documentation reflecting that. Add two small regression tests for the fixes described above. --- generator/actions.ml | 6 ++--- src/drives.c | 13 +--------- tests/regressions/Makefile.am | 2 ++ tests/regressions/rhbz563450.sh | 54 ++++++++++++++++++++++++++++++++++++++++ tests/regressions/rhbz563450b.sh | 43 ++++++++++++++++++++++++++++++++ 5 files changed, 103 insertions(+), 15 deletions(-) create mode 100755 tests/regressions/rhbz563450.sh create mode 100755 tests/regressions/rhbz563450b.sh diff --git a/gener...

...| 2 +- fish/test-mount-local.sh | 2 +- make-fs/test-virt-make-fs.sh | 2 +- src/api-support/update-from-tarballs.sh | 2 +- sysprep/test-virt-sysprep-script.sh | 2 +- tests/qemu/qemu-snapshot-isolation.sh | 2 +- tests/regressions/rhbz563450.sh | 2 +- 11 files changed, 11 insertions(+), 11 deletions(-) diff --git a/align/test-virt-alignment-scan-guests.sh b/align/test-virt-alignment-scan-guests.sh index 99e2585..50b9260 100755 --- a/align/test-virt-alignment-scan-guests.sh +++ b/align/test-virt-alignment-scan-guests.sh @@ -3...

...e > > added > > > > (RHBZ#563450) > > > > Add two small regression tests for the fixes described above. > > --- > > > > src/drives.c | 7 +----- > > tests/regressions/Makefile.am | 2 ++ > > tests/regressions/rhbz563450.sh | 54 > > ++++++++++++++++++++++++++++++++++++++++ > > tests/regressions/rhbz563450b.sh | 43 > > ++++++++++++++++++++++++++++++++ 4 files changed, 100 > > insertions(+), 6 deletions(-) > > create mode 100755 tests/regressions/rhbz563450.sh > > create mod...

On Fri, Dec 13, 2013 at 04:32:49PM +0100, Pino Toscano wrote: > diff --git a/tests/regressions/rhbz563450.sh b/tests/regressions/rhbz563450.sh > new file mode 100755 > index 0000000..6fa6f2b > --- /dev/null > +++ b/tests/regressions/rhbz563450.sh > @@ -0,0 +1,54 @@ > +#!/bin/bash - > +# libguestfs > +# Copyright (C) 2013 Red Hat Inc. > +# > +# This program is free software...

--- test-data/phony-guests/Makefile.am | 3 +-- test-data/phony-guests/make-archlinux-img.sh | 4 ++-- test-data/phony-guests/make-coreos-img.sh | 10 ++++---- test-data/phony-guests/make-debian-img.sh | 10 ++++---- test-data/phony-guests/make-fedora-img.pl | 34 ++++++++++++++-------------- test-data/phony-guests/make-ubuntu-img.sh | 14 ++++++------

...> - the result of list-devices now reflects the order images were added > (RHBZ#563450) > > Add two small regression tests for the fixes described above. > --- > src/drives.c | 7 +----- > tests/regressions/Makefile.am | 2 ++ > tests/regressions/rhbz563450.sh | 54 ++++++++++++++++++++++++++++++++++++++++ > tests/regressions/rhbz563450b.sh | 43 ++++++++++++++++++++++++++++++++ > 4 files changed, 100 insertions(+), 6 deletions(-) > create mode 100755 tests/regressions/rhbz563450.sh > create mode 100755 tests/regressions/rhbz563450b.sh...

...cat.sh | 2 +- tests/ntfs/test-ntfsclone.sh | 2 +- tests/regressions/rhbz1011907-1165785.sh | 4 ++-- tests/regressions/rhbz1054761.sh | 2 +- tests/regressions/rhbz1174551.sh | 2 +- tests/regressions/rhbz1285847.sh | 2 +- tests/regressions/rhbz563450.sh | 4 ++-- tests/regressions/rhbz580246.sh | 2 +- tests/regressions/rhbz690819.sh | 2 +- tests/regressions/rhbz789960.sh | 2 +- tests/regressions/rhbz811649.sh | 2 +- tests/regressions/rhbz975797.sh | 6 +++--- tests/tsk/test-downloa...

...| 2 +- tests/ntfs/test-ntfsclone.sh | 2 +- tests/regressions/rhbz1011907-1165785.sh | 4 ++-- tests/regressions/rhbz1054761.sh | 2 +- tests/regressions/rhbz1174551.sh | 2 +- tests/regressions/rhbz1285847.sh | 2 +- tests/regressions/rhbz563450.sh | 4 ++-- tests/regressions/rhbz580246.sh | 2 +- tests/regressions/rhbz690819.sh | 2 +- tests/regressions/rhbz789960.sh | 2 +- tests/regressions/rhbz811649.sh | 2 +- tests/regressions/rhbz975797.sh | 6 +++--- tests/tsk/test-d...

...| 2 +- tests/fuzz/Makefile.am | 2 +- tests/guests/guest-aux/debian-packages | 1 - tests/mount-local/Makefile.am | 2 +- tests/parallel/Makefile.am | 2 +- tests/qemu/qemu-snapshot-isolation.sh | 2 +- tests/regressions/rhbz563450.sh | 2 +- tests/relative-paths/Makefile.am | 2 +- tools/virt-win-reg | 2 +- v2v/Makefile.am | 2 +- v2v/convert_linux.ml | 6 +- v2v/input_libvirt.ml | 4 +- v2v/lib_ovf.ml...

Previously I posted a work-in-progress preview of this patch series: https://www.redhat.com/archives/libguestfs/2017-February/msg00224.html This is the finished version that updates all of the shell-script based tests. It passes 'make check', 'make check-direct' and 'make check-slow'. Rich.

This converts more of the tests (basically everything under tests/) to use the test harness, revealing some problems which have subsequently been fixed. Rich.

These are my thoughts on adding a test harness to run tests instead of using automake. The aim of this exercise is to allow us to run the full test suite on an installed copy of libguestfs. Another aim is to allow us to work around all the limitations and problems of automake. The first patch makes an observation that since the ./run script sets up $PATH to contain all the directories

Since v4: - More tests have been converted. - Testing local guests fixed. - Drop no-exec-stack test.

For v6: This is mainly just a rebase, but I have also added tests in the ocaml/ language bindings directory, and for all the OCaml-written virt tools. Rich.

v7: The only changes since v6 are those suggested by Pino in the review of v5.

I should probably start by saying this patch series isn't ready for review yet. This patch series adds a test harness to libguestfs. It allows us to run the tests outside the ordinary 'make check' path in the build tree. In particular, you can use this to run tests when libguestfs has been installed. 'make check' and the other 'make check-*' rules still work. The

This is a more complete patch to add the test harness. The only parts missing now are the language bindings (except OCaml). The language bindings need a bit more thought. At the moment most language binding tests are done through some sort of shell script like perl/run-perl-tests which either runs each test itself or uses some language-specific machinary to run each test. The problem with that