search for: rhbz557655

Use %d to parse them as int (since the variables for them as int) instead of %u, even if they both need to be at least > 0. --smp was already checked to be >= 1 while --memsize not, so check that the specified memory size is not < 128 (which is semi-arbitrary, but enough as a minimum threshold). --- rescue/rescue.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-)

...nife.html Sine we can't run the fuse tests easily in a chroot (since we might be unable to load the module) I'm using the attached patch to skip the tests if /dev/fuse doesn't exist. This probably isn't clean enough to go upstream though. The other patch adjusts the test output of rhbz557655. xstrtol seems to be behaving differently here. I didn't investigate why yet. As a last point: is there a simple way to disable the appliance build altogether? I'd like to ship the Debian package without it so we stay out of the security update trouble and provide them via http. Cheers an...

These are my thoughts on adding a test harness to run tests instead of using automake. The aim of this exercise is to allow us to run the full test suite on an installed copy of libguestfs. Another aim is to allow us to work around all the limitations and problems of automake. The first patch makes an observation that since the ./run script sets up $PATH to contain all the directories

...sh create mode 100755 tests/regressions/rhbz563450b.sh diff --git a/tests/regressions/Makefile.am b/tests/regressions/Makefile.am index 5b0d1c3..741f45f 100644 --- a/tests/regressions/Makefile.am +++ b/tests/regressions/Makefile.am @@ -21,6 +21,8 @@ TESTS = \ rhbz501893 \ rhbz503169c13.sh \ rhbz557655.sh \ + rhbz563450.sh \ + rhbz563450b.sh \ rhbz576879.sh \ rhbz578407.sh \ rhbz580246.sh \ diff --git a/tests/regressions/rhbz563450.sh b/tests/regressions/rhbz563450.sh new file mode 100755 index 0000000..96fca8c --- /dev/null +++ b/tests/regressions/rhbz563450.sh @@ -0,0 +1,59 @@ +#!/bin/bas...

...ding on whether we are hotplugging or not, this function diff --git a/tests/regressions/Makefile.am b/tests/regressions/Makefile.am index 5b0d1c3..741f45f 100644 --- a/tests/regressions/Makefile.am +++ b/tests/regressions/Makefile.am @@ -21,6 +21,8 @@ TESTS = \ rhbz501893 \ rhbz503169c13.sh \ rhbz557655.sh \ + rhbz563450.sh \ + rhbz563450b.sh \ rhbz576879.sh \ rhbz578407.sh \ rhbz580246.sh \ diff --git a/tests/regressions/rhbz563450.sh b/tests/regressions/rhbz563450.sh new file mode 100755 index 0000000..6fa6f2b --- /dev/null +++ b/tests/regressions/rhbz563450.sh @@ -0,0 +1,54 @@ +#!/bin/bas...

On Wednesday 18 December 2013 20:44:33 Richard W.M. Jones wrote: > On Fri, Dec 13, 2013 at 04:32:49PM +0100, Pino Toscano wrote: > > diff --git a/tests/regressions/rhbz563450.sh > > b/tests/regressions/rhbz563450.sh new file mode 100755 > > index 0000000..6fa6f2b > > --- /dev/null > > +++ b/tests/regressions/rhbz563450.sh > > @@ -0,0 +1,54 @@ > >

Previously I posted a work-in-progress preview of this patch series: https://www.redhat.com/archives/libguestfs/2017-February/msg00224.html This is the finished version that updates all of the shell-script based tests. It passes 'make check', 'make check-direct' and 'make check-slow'. Rich.

On Saturday 14 December 2013 22:50:28 Richard W.M. Jones wrote: > On Fri, Dec 13, 2013 at 04:32:49PM +0100, Pino Toscano wrote: > > The current add_cdrom way basically appends a new raw "-cdrom /path" > > parameter to the qemu invocation (even when using libvirt as > > backend), hence such images are seen as "CD-ROM drives" inside the > > appliance.

...ding on whether we are hotplugging or not, this function diff --git a/tests/regressions/Makefile.am b/tests/regressions/Makefile.am index 5b0d1c3..741f45f 100644 --- a/tests/regressions/Makefile.am +++ b/tests/regressions/Makefile.am @@ -21,6 +21,8 @@ TESTS = \ rhbz501893 \ rhbz503169c13.sh \ rhbz557655.sh \ + rhbz563450.sh \ + rhbz563450b.sh \ rhbz576879.sh \ rhbz578407.sh \ rhbz580246.sh \ diff --git a/tests/regressions/rhbz563450.sh b/tests/regressions/rhbz563450.sh new file mode 100755 index 0000000..6fa6f2b --- /dev/null +++ b/tests/regressions/rhbz563450.sh @@ -0,0 +1,54 @@ +#!/bin/bas...

This converts more of the tests (basically everything under tests/) to use the test harness, revealing some problems which have subsequently been fixed. Rich.

Since v4: - More tests have been converted. - Testing local guests fixed. - Drop no-exec-stack test.

For v6: This is mainly just a rebase, but I have also added tests in the ocaml/ language bindings directory, and for all the OCaml-written virt tools. Rich.

v7: The only changes since v6 are those suggested by Pino in the review of v5.

I should probably start by saying this patch series isn't ready for review yet. This patch series adds a test harness to libguestfs. It allows us to run the tests outside the ordinary 'make check' path in the build tree. In particular, you can use this to run tests when libguestfs has been installed. 'make check' and the other 'make check-*' rules still work. The

This is a more complete patch to add the test harness. The only parts missing now are the language bindings (except OCaml). The language bindings need a bit more thought. At the moment most language binding tests are done through some sort of shell script like perl/run-perl-tests which either runs each test itself or uses some language-specific machinary to run each test. The problem with that

Since v2: - Add perl tests. - Reworked and fixed the tests for virt-builder. - Some further minor bug fixes.

Since v3: - A large number of fixes, especially for running the tests on installed libguestfs. - Fixed EXTRA_DIST rules throughout. - Extra patch 17/17 which is a tidy-up of the generated XML listing guests. Rich.

...crw-rw-rw- 1 0 0 5, 0 Dec 7 11:48 /sysroot/../dev/tty crw-rw-rw- 1 0 0 1, 9 Dec 7 11:48 /sysroot/../dev/urandom crw-rw-rw- 1 0 0 1, 5 Dec 7 11:48 /sysroot/../dev/zero PASS: rhbz503169c10.sh libguestfs: error: command: /ignore-this-error: No such file or directory PASS: rhbz503169c13.sh PASS: rhbz557655.sh PASS: rhbz578407.sh 2+0 records in 2+0 records out 2097152 bytes (2.1 MB) copied, 0.00389549 s, 538 MB/s PASS: rhbz580246.sh libguestfs: error: /home/rjones/d/libguestfs/regressions/test3.img: No such file or directory PASS: test-add-domain.sh libguestfs: error: /dev/full: write: No space left o...

...crw-rw-rw- 1 0 0 5, 0 Dec 24 21:18 /sysroot/../dev/tty crw-rw-rw- 1 0 0 1, 9 Dec 24 21:18 /sysroot/../dev/urandom crw-rw-rw- 1 0 0 1, 5 Dec 24 21:18 /sysroot/../dev/zero PASS: rhbz503169c10.sh libguestfs: error: command: /ignore-this-error: No such file or directory PASS: rhbz503169c13.sh PASS: rhbz557655.sh PASS: rhbz578407.sh 2+0 records in 2+0 records out 2097152 bytes (2.1 MB) copied, 0.00413156 s, 508 MB/s PASS: rhbz580246.sh libguestfs: error: /home/rjones/d/libguestfs/regressions/test3.img: No such file or directory PASS: test-add-domain.sh libguestfs: error: /dev/full: write: No space left o...

...crw-rw-rw- 1 0 0 5, 0 Jan 7 21:18 /sysroot/../dev/tty crw-rw-rw- 1 0 0 1, 9 Jan 7 21:18 /sysroot/../dev/urandom crw-rw-rw- 1 0 0 1, 5 Jan 7 21:18 /sysroot/../dev/zero PASS: rhbz503169c10.sh libguestfs: error: command: /ignore-this-error: No such file or directory PASS: rhbz503169c13.sh PASS: rhbz557655.sh PASS: rhbz578407.sh 2+0 records in 2+0 records out 2097152 bytes (2.1 MB) copied, 0.00405111 s, 518 MB/s PASS: rhbz580246.sh libguestfs: error: /home/rjones/d/libguestfs/regressions/test3.img: No such file or directory PASS: test-add-domain.sh libguestfs: error: /dev/full: write: No space left o...