search for: reverts

...g] On Behalf Of Don Hinton via llvm-dev Sent: Tuesday, March 26, 2019 4:57 AM To: Xing GUO Cc: LLVM Development List Subject: Re: [llvm-dev] How to revert a change properly Hi Xing: There's too much activity to automatically revert anything, so you need to commit a new change that effectively reverts the original patch -- keeping in mind that someone else might have changed some of the same files, and/or lines, in the interim. Here's how I do it. Update your local master, and extract the change using svn diff or git diff to a patch file. Then use patch to apply it locally, using the '...

...k community members have the >>>>> right, and perhaps responsibility, to revert the change that caused it. >>>>> Our team maintains bots that build chrome with trunk versions of clang, >>>>> and we identify many regressions this way and end up doing many reverts >>>>> as a result. I think it's important to continue this practice so that >>>>> we don't let multiple regressions pile up. >>>> My team also has internal bots and we see breakages way more often than >>>> we'd like. We are a bit r...

Hi folks, Several days ago, I made a bad change in llvm, and I reverted it using following command ``` $ svn merge -r <bad change revision>:<previous revision> ``` However, this command seemed not working properly. I would like to know, what's the right way to revert a bad change. I notice that there are some reverting change with proper message, e.g. "Revert: [some tag]

...e enough, then I think community members have the > >> right, and perhaps responsibility, to revert the change that caused it. > >> Our team maintains bots that build chrome with trunk versions of clang, > >> and we identify many regressions this way and end up doing many reverts > >> as a result. I think it's important to continue this practice so that > >> we don't let multiple regressions pile up. > > > > My team also has internal bots and we see breakages way more often than > > we'd like. We are a bit reluctant to just g...

Hi all, Over the past year or so, all of us have broken the buildbots on many occasions. Usually we get notified on IRC, or via an buildbot email notification sent to everyone on the blamelist. If I happen to be on IRC I'll see the notification, but if not, the next best thing is an email that was automatically sent to me (along with everyone else on the blamelist) from the buildbot with

...rd case is when a patch is not doing the right thing or e.g. forgets certain cases. Usually what we do is leave a comment on the Phab ticket, and when the author responds fast and works on a fix we can live with the regression for a few days (but it looks like we could be a bit more aggressive with reverts if we wanted to). The straightforward cases are 1) and 3), where the former is not worth a revert (but it would be good to be explicit about this), and 3) is definitely worth a revert. 2) is the tricky one, because it has a lot of grey areas. I guess the reason why we are not very aggressive with...

...he > regression is severe enough, then I think community members have the > right, and perhaps responsibility, to revert the change that caused it. > Our team maintains bots that build chrome with trunk versions of clang, > and we identify many regressions this way and end up doing many reverts > as a result. I think it's important to continue this practice so that > we don't let multiple regressions pile up. My team also has internal bots and we see breakages way more often than we'd like. We are a bit reluctant to just go revert something, though, and typically try t...

I am trying to revert a commit, and the instructions here don't work as the revert support was removed from the git-llvm script last week when the migration happened. The instructions on the website still reference it however: https://llvm.org/docs/GettingStarted.html#reverting-a-change-when-using-git I am going to do it manually, but a script would be helpful for automating the commit

Can you explain how to revert for someone who is a 2 on a git scale of 0 to 10? At 9/22/2020 03:51 PM, Arthur Eubanks wrote: >Yes, push whatever is needed to fix the build if the fix is fairly simple (else revert and get an LGTM with the fix). > >Next time I'd recommend creating and pushing a revert first if you can't quickly figure out the issue.

This series reverts the in-kernel workarounds for inlining issues. The commit description of 77b0bf55bc67 mentioned "We also hope that GCC will eventually get fixed,..." Now, GCC provides a solution. https://gcc.gnu.org/onlinedocs/gcc/Extended-Asm.html explains the new "asm inline" syntax. The...

This series reverts the in-kernel workarounds for inlining issues. The commit description of 77b0bf55bc67 mentioned "We also hope that GCC will eventually get fixed,..." Now, GCC provides a solution. https://gcc.gnu.org/onlinedocs/gcc/Extended-Asm.html explains the new "asm inline" syntax. The...

...ginal author". > I think this generally sounds right, and matches what we currently expect in practice. To this we might add that it is then the responsibility of the developer requesting the revert to ensure that the review happens promptly. Do we have a formal policy for other kinds of reverts? We also generally revert if someone claims to have bisected a miscompile to a particular commit, and this is true even if a test case is not immediately available (although we do need some kind of reproducer before too long). -Hal > > > -- Sean Silva > -- Hal Finkel Assistant C...

Hi there, I''m running several VMs within Xen, and now I''m trying to create/revert snapshots of my VMs. Along with Xen and blktap2, another utility, vhd-util is also delivered, and according to its description, i guess I can use it to create/revert VM snapshots. To create a snapshot is actually easy, I just call |vhd-util snapshot -n aSnapShot.vhd -p theVMtoBackup.vhd | But

Recently there's been some friction over reversions (I can remember two cases in recent memory). In both issues the general feel I got is that as a community we should honor "revert for more design review" requests unconditionally. What do you guys think of adding something like this to DeveloperPolicy.rst as an item at the end of the numbered list in

Hi, I''m just trying out the possibilities of script.aculo.us / prototype having two problems... I have a draggable element with revert:false-property and two dropzones. (The draggables are in a <td> and the dropzones are <div>s if that is important.) 1. I want the draggable element to snap back to its original position when it gets dropped anywhere out of a dropzone. 2.

On 2019/9/5 ??9:59, Jason Gunthorpe wrote: > On Thu, Sep 05, 2019 at 08:27:34PM +0800, Jason Wang wrote: >> Hi: >> >> Per request from Michael and Jason, the metadata accelreation is >> reverted in this version and rework in next version. >> >> Please review. >> >> Thanks >> >> Jason Wang (2): >> Revert "vhost: access vq

On 2019/9/5 ??9:59, Jason Gunthorpe wrote: > On Thu, Sep 05, 2019 at 08:27:34PM +0800, Jason Wang wrote: >> Hi: >> >> Per request from Michael and Jason, the metadata accelreation is >> reverted in this version and rework in next version. >> >> Please review. >> >> Thanks >> >> Jason Wang (2): >> Revert "vhost: access vq

I am running Ubuntu Dapper Drake with Wine 9.9 - I tried to load Photoshop 4 with the following results: :~$ wine "/media/cdrom/photoshp/disk1/setup.exe" libGL warning: 3D driver returned no fbconfigs. libGL error: InitDriver failed libGL error: reverting to (slow) indirect rendering libGL warning: 3D driver returned no fbconfigs. libGL error: InitDriver failed libGL error: reverting to

* Masahiro Yamada <yamada.masahiro at socionext.com> wrote: > This series reverts the in-kernel workarounds for inlining issues. > > The commit description of 77b0bf55bc67 mentioned > "We also hope that GCC will eventually get fixed,..." > > Now, GCC provides a solution. > > https://gcc.gnu.org/onlinedocs/gcc/Extended-Asm.html > explains the...

...afael J . Wysocki; Alex Hung; Ben > Skeggs; Dave Airlie > Subject: Re: [Nouveau] [PATCH 1/7] Revert "ACPI / OSI: Add OEM _OSI string to > enable dGPU direct output" > > On Thu, 15 Aug 2019 at 07:31, Karol Herbst <kherbst at redhat.com> wrote: > > > > This reverts commit 28586a51eea666d5531bcaef2f68e4abbd87242c. > > > > The original commit message didn't even make sense. AMD _does_ support it and > > it works with Nouveau as well. > > > > Also what was the issue being solved here? No references to any bugs and not > >...