search for: reverting

...I made a bad change in llvm, and I reverted it using following command ``` $ svn merge -r <bad change revision>:<previous revision> ``` However, this command seemed not working properly. I would like to know, what's the right way to revert a bad change. I notice that there are some reverting change with proper message, e.g. "Revert: [some tag] commit message". Shall I type this message manually? Or is there some useful tool that I could use? Best Regards, Xing _______________________________________________ LLVM Developers mailing list llvm-dev at lists.llvm.org<mailto:l...

...ly sends notifications, but perhaps not everyone agrees with >> this definition. > I would argue that "internal vs external" is the wrong division here. > It does come up that internal bots or weird local configurations find > significant problems in practice sometimes, and reverting to green can > be completely reasonable for these cases. Obviously some discretion is > necessary, but reverting more or less any change that causes issues > severe enough to legitimately block you or seriously hamper your ability > to notice further issues is fair game in my eyes. >...

...I made a bad change in llvm, and I reverted it using following command ``` $ svn merge -r <bad change revision>:<previous revision> ``` However, this command seemed not working properly. I would like to know, what's the right way to revert a bad change. I notice that there are some reverting change with proper message, e.g. "Revert: [some tag] commit message". Shall I type this message manually? Or is there some useful tool that I could use? Best Regards, Xing -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/...

This is kind of what I was getting at with my original email, so thank you for wording it better than I did. If we can agree that "contact the author first for internal bots" is better than "revert automatically, even for internal bots" (which may not be the case, I don't want to speak for others), then the problem becomes one of defining what an "internal bot"

Hi all, Over the past year or so, all of us have broken the buildbots on many occasions. Usually we get notified on IRC, or via an buildbot email notification sent to everyone on the blamelist. If I happen to be on IRC I'll see the notification, but if not, the next best thing is an email that was automatically sent to me (along with everyone else on the blamelist) from the buildbot with

I think we could/should be a little bit more precise here: > ... any regressions whether they affect buildbots or not, the > patch author should be responsible for fixing the issue. especially if we say that the bar for a revert is low. That is, the "any regression" needs a bit more clarifications. Assuming we are talking about performance regressions (not language conformance or

Reid said: > I don't think whether a buildbot sends email should have anything to do > with whether we revert to green or not. Very often, developers commit > patches that cause regressions not caught by our buildbots. If the > regression is severe enough, then I think community members have the > right, and perhaps responsibility, to revert the change that caused it. > Our

I am trying to revert a commit, and the instructions here don't work as the revert support was removed from the git-llvm script last week when the migration happened. The instructions on the website still reference it however: https://llvm.org/docs/GettingStarted.html#reverting-a-change-when-using-git I am going to do it manually, but a script would be helpful for automating the commit message etc. Am I missing where the support for this now lives? Thanks, Teresa -- Teresa Johnson | Software Engineer | tejohnson at google.com |

Can you explain how to revert for someone who is a 2 on a git scale of 0 to 10? At 9/22/2020 03:51 PM, Arthur Eubanks wrote: >Yes, push whatever is needed to fix the build if the fix is fairly simple (else revert and get an LGTM with the fix). > >Next time I'd recommend creating and pushing a revert first if you can't quickly figure out the issue.

This series reverts the in-kernel workarounds for inlining issues. The commit description of 77b0bf55bc67 mentioned "We also hope that GCC will eventually get fixed,..." Now, GCC provides a solution. https://gcc.gnu.org/onlinedocs/gcc/Extended-Asm.html explains the new "asm inline" syntax. The performance issue will be eventually solved. [About Code cleanups] I know Nadam

This series reverts the in-kernel workarounds for inlining issues. The commit description of 77b0bf55bc67 mentioned "We also hope that GCC will eventually get fixed,..." Now, GCC provides a solution. https://gcc.gnu.org/onlinedocs/gcc/Extended-Asm.html explains the new "asm inline" syntax. The performance issue will be eventually solved. [About Code cleanups] I know Nadam

----- Original Message ----- > From: "Sean Silva" <chisophugis at gmail.com> > To: "llvm-dev" <llvm-dev at lists.llvm.org> > Cc: "Chris Lattner" <clattner at apple.com>, "Rafael Ávila de Espíndola" <rafael.espindola at gmail.com>, "Michael Spencer" > <bigcheesegs at gmail.com>, "Chandler Carruth"

...VMs. Along with Xen and blktap2, another utility, vhd-util is also delivered, and according to its description, i guess I can use it to create/revert VM snapshots. To create a snapshot is actually easy, I just call |vhd-util snapshot -n aSnapShot.vhd -p theVMtoBackup.vhd | But when it comes to reverting a snapshot, things get really annoying The "revert" command requires a mandatory argument "journal", like this: |vhd-util revert -n aSnapShot.vhd -j someThingCalledJournalOfWhichIHaveCompletelyNoIdea | And vhd-util expects some info from the journal, which means it''s...

Recently there's been some friction over reversions (I can remember two cases in recent memory). In both issues the general feel I got is that as a community we should honor "revert for more design review" requests unconditionally. What do you guys think of adding something like this to DeveloperPolicy.rst as an item at the end of the numbered list in

Hi, I''m just trying out the possibilities of script.aculo.us / prototype having two problems... I have a draggable element with revert:false-property and two dropzones. (The draggables are in a <td> and the dropzones are <div>s if that is important.) 1. I want the draggable element to snap back to its original position when it gets dropped anywhere out of a dropzone. 2.

On 2019/9/5 ??9:59, Jason Gunthorpe wrote: > On Thu, Sep 05, 2019 at 08:27:34PM +0800, Jason Wang wrote: >> Hi: >> >> Per request from Michael and Jason, the metadata accelreation is >> reverted in this version and rework in next version. >> >> Please review. >> >> Thanks >> >> Jason Wang (2): >> Revert "vhost: access vq

On 2019/9/5 ??9:59, Jason Gunthorpe wrote: > On Thu, Sep 05, 2019 at 08:27:34PM +0800, Jason Wang wrote: >> Hi: >> >> Per request from Michael and Jason, the metadata accelreation is >> reverted in this version and rework in next version. >> >> Please review. >> >> Thanks >> >> Jason Wang (2): >> Revert "vhost: access vq

I am running Ubuntu Dapper Drake with Wine 9.9 - I tried to load Photoshop 4 with the following results: :~$ wine "/media/cdrom/photoshp/disk1/setup.exe" libGL warning: 3D driver returned no fbconfigs. libGL error: InitDriver failed libGL error: reverting to (slow) indirect rendering libGL warning: 3D driver returned no fbconfigs. libGL error: InitDriver failed libGL error: reverting to (slow) indirect rendering libGL warning: 3D driver returned no fbconfigs. libGL error: InitDriver failed libGL error: reverting to (slow) indirect rendering libGL wa...

* Masahiro Yamada <yamada.masahiro at socionext.com> wrote: > This series reverts the in-kernel workarounds for inlining issues. > > The commit description of 77b0bf55bc67 mentioned > "We also hope that GCC will eventually get fixed,..." > > Now, GCC provides a solution. > > https://gcc.gnu.org/onlinedocs/gcc/Extended-Asm.html > explains the new

...reverts should be merged via Rafael's tree as the original > patches went in via there, and we should get them in asap. > > Acked-by: Dave Airlie <airlied at redhat.com> > Dave. There are definitely going to be regressions on machines in the field with the in tree drivers by reverting this. I think we should have an answer for all of those before this revert is accepted. Regarding systems with Intel+NVIDIA, we'll have to work with partners to collect some information on the impact of reverting this. When this is used on a system with Intel+AMD the ASL configures AMD GPU t...