search for: revert

The "Revert [tag] message" is the default message generated by the 'git revert' command. Of course you would have to be using a git clone of LLVM instead of an SVN checkout in order to run 'git revert'. This command is the equivalent of 'svn merge –r' run from the top-level direc...

+1 to Justin's comment The only standard for revert should be: it's broken, and here's a reproducer.  Nothing else should matter. ... says the person w/a ton of internal regression testing which regularly finds crashes upstream, and is terrified of the implied effort of having to engage each author of a broken patch individually while b...

Hi folks, Several days ago, I made a bad change in llvm, and I reverted it using following command ``` $ svn merge -r <bad change revision>:<previous revision> ``` However, this command seemed not working properly. I would like to know, what's the right way to revert a bad change. I notice that there are some reverting change with proper message, e.g....

This is kind of what I was getting at with my original email, so thank you for wording it better than I did. If we can agree that "contact the author first for internal bots" is better than "revert automatically, even for internal bots" (which may not be the case, I don't want to speak for others), then the problem becomes one of defining what an "internal bot" is. In my opinion, an internal bot it is one that does does not satisfy both conditions: a) on the public waterfa...

...not, the next best thing is an email that was automatically sent to me (along with everyone else on the blamelist) from the buildbot with information about the failure. And then finally, I'll occasionally get a response to my commit message telling me that it's broken, and the patch may be reverted with information in the commit message explaining which bot was broken and providing a link to it. However, we have some buildbots on the public waterfall which are specifically configured not to send emails to people. In some cases it's because the bots are experimental, but there are a ha...

I think we could/should be a little bit more precise here: > ... any regressions whether they affect buildbots or not, the > patch author should be responsible for fixing the issue. especially if we say that the bar for a revert is low. That is, the "any regression" needs a bit more clarifications. Assuming we are talking about performance regressions (not language conformance or correctness): 1) We sometimes see regressions where code generation is (almost) the same, but the code layout is different. Some micro...

Reid said: > I don't think whether a buildbot sends email should have anything to do > with whether we revert to green or not. Very often, developers commit > patches that cause regressions not caught by our buildbots. If the > regression is severe enough, then I think community members have the > right, and perhaps responsibility, to revert the change that caused it. > Our team maintains bots...

I am trying to revert a commit, and the instructions here don't work as the revert support was removed from the git-llvm script last week when the migration happened. The instructions on the website still reference it however: https://llvm.org/docs/GettingStarted.html#reverting-a-change-when-using-git I am going to...

Can you explain how to revert for someone who is a 2 on a git scale of 0 to 10? At 9/22/2020 03:51 PM, Arthur Eubanks wrote: >Yes, push whatever is needed to fix the build if the fix is fairly simple (else revert and get an LGTM with the fix). > >Next time I'd recommend creating and pushing a revert first if you c...

This series reverts the in-kernel workarounds for inlining issues. The commit description of 77b0bf55bc67 mentioned "We also hope that GCC will eventually get fixed,..." Now, GCC provides a solution. https://gcc.gnu.org/onlinedocs/gcc/Extended-Asm.html explains the new "asm inline" syntax. The...

This series reverts the in-kernel workarounds for inlining issues. The commit description of 77b0bf55bc67 mentioned "We also hope that GCC will eventually get fixed,..." Now, GCC provides a solution. https://gcc.gnu.org/onlinedocs/gcc/Extended-Asm.html explains the new "asm inline" syntax. The...

...Blaikie" > <dblaikie at gmail.com>, "Daniel Berlin" <dberlin at dberlin.org>, "Easwaran Raman" <eraman at google.com>, "Hal Finkel" > <hfinkel at anl.gov> > Sent: Tuesday, March 8, 2016 11:03:09 PM > Subject: Re: Formalize "revert for more design review" policy. > > > +Hal, who somehow slipped through the cracks. > Thanks :-) > > On Tue, Mar 8, 2016 at 9:00 PM, Sean Silva < chisophugis at gmail.com > > wrote: > > > > Recently there's been some friction over reversions...

Hi there, I''m running several VMs within Xen, and now I''m trying to create/revert snapshots of my VMs. Along with Xen and blktap2, another utility, vhd-util is also delivered, and according to its description, i guess I can use it to create/revert VM snapshots. To create a snapshot is actually easy, I just call |vhd-util snapshot -n aSnapShot.vhd -p theVMtoBackup.vhd | But w...

Recently there's been some friction over reversions (I can remember two cases in recent memory). In both issues the general feel I got is that as a community we should honor "revert for more design review" requests unconditionally. What do you guys think of adding something like this to DeveloperPolicy.rst as an item at the end of the numbered list in http://llvm.org/docs/DeveloperPolicy.html#code-reviews ? #. Sometimes patches get committed that need more discussion....

Hi, I''m just trying out the possibilities of script.aculo.us / prototype having two problems... I have a draggable element with revert:false-property and two dropzones. (The draggables are in a <td> and the dropzones are <div>s if that is important.) 1. I want the draggable element to snap back to its original position when it gets dropped anywhere out of a dropzone. 2. If the draggable element gets dropped on a d...

On 2019/9/5 ??9:59, Jason Gunthorpe wrote: > On Thu, Sep 05, 2019 at 08:27:34PM +0800, Jason Wang wrote: >> Hi: >> >> Per request from Michael and Jason, the metadata accelreation is >> reverted in this version and rework in next version. >> >> Please review. >> >> Thanks >> >> Jason Wang (2): >> Revert "vhost: access vq metadata through kernel virtual address" >> vhost: re-introducing metadata acceleration through kernel vi...

On 2019/9/5 ??9:59, Jason Gunthorpe wrote: > On Thu, Sep 05, 2019 at 08:27:34PM +0800, Jason Wang wrote: >> Hi: >> >> Per request from Michael and Jason, the metadata accelreation is >> reverted in this version and rework in next version. >> >> Please review. >> >> Thanks >> >> Jason Wang (2): >> Revert "vhost: access vq metadata through kernel virtual address" >> vhost: re-introducing metadata acceleration through kernel vi...

I am running Ubuntu Dapper Drake with Wine 9.9 - I tried to load Photoshop 4 with the following results: :~$ wine "/media/cdrom/photoshp/disk1/setup.exe" libGL warning: 3D driver returned no fbconfigs. libGL error: InitDriver failed libGL error: reverting to (slow) indirect rendering libGL warning: 3D driver returned no fbconfigs. libGL error: InitDriver failed libGL error: reverting to (slow) indirect rendering libGL warning: 3D driver returned no fbconfigs. libGL error: InitDriver failed libGL error: reverting to (slow) indirect rendering libGL...

* Masahiro Yamada <yamada.masahiro at socionext.com> wrote: > This series reverts the in-kernel workarounds for inlining issues. > > The commit description of 77b0bf55bc67 mentioned > "We also hope that GCC will eventually get fixed,..." > > Now, GCC provides a solution. > > https://gcc.gnu.org/onlinedocs/gcc/Extended-Asm.html > explains the...

...kernel.org <linux-acpi-owner at vger.kernel.org> On > Behalf Of Dave Airlie > Sent: Wednesday, August 14, 2019 5:48 PM > To: Karol Herbst > Cc: LKML; Linux ACPI; dri-devel; nouveau; Rafael J . Wysocki; Alex Hung; Ben > Skeggs; Dave Airlie > Subject: Re: [Nouveau] [PATCH 1/7] Revert "ACPI / OSI: Add OEM _OSI string to > enable dGPU direct output" > > On Thu, 15 Aug 2019 at 07:31, Karol Herbst <kherbst at redhat.com> wrote: > > > > This reverts commit 28586a51eea666d5531bcaef2f68e4abbd87242c. > > > > The original commit message...