Displaying 3 results from an estimated 3 matches for "return_with_success".
2008 May 08
1
Patch to not modify files in place unless "--inplace" option specified
...%s due to changed attributes\n", fname);
+ goto recreate_symlink;
+ }
if (itemizing)
itemize(fname, file, ndx, 0, &sx, 0, 0, NULL);
#if defined SUPPORT_HARD_LINKS && defined CAN_HARDLINK_SYMLINK
@@ -1538,7 +1547,9 @@
if (remove_source_files == 1)
goto return_with_success;
goto cleanup;
- }
+ } else
+ iflags = ITEM_REPORT_CHANGE;
+ recreate_symlink:
/* Not the right symlink (or not a symlink), so
* delete it. */
if (delete_item(fname, sx.st.st_mode, del_opts | DEL_FOR_SYMLINK) != 0)
@@ -1572,18 +1583,20 @@
set_file_attrs(fname, file, NU...
2008 Oct 09
1
DO NOT REPLY [Bug 5820] New: rsync does not replace symlink atomically
...ch is also available on
http://sysoev.ru/tmp/rsync.symlink.patch
--- generator.c 2008-08-31 20:51:29.000000000 +0400
+++ generator.c 2008-10-08 23:10:17.000000000 +0400
@@ -1556,9 +1556,40 @@
if (remove_source_files == 1)
goto return_with_success;
goto cleanup;
+ } else {
+ char fnametmp[MAXPATHLEN];
+
+ /* Replace the symlink atomically. */
+ if (!get_tmpname(fnametmp, fname))
+...
2006 Oct 21
1
Rsync 2.6.9pre2 tries to read ACLs of nonexistent files
...if a basis file is found, even though the destination
file does not exist:
if (statret != 0 && basis_dir[0] != NULL) {
int j = try_dests_reg(file, fname, ndx, fnamecmpbuf, &sx,
itemizing, maybe_ATTRS_REPORT, code);
if (j == -2) {
if (remove_source_files == 1)
goto return_with_success;
goto cleanup;
}
if (j >= 0) {
fnamecmp = fnamecmpbuf;
fnamecmp_type = j;
statret = 0;
}
}
real_ret = statret;
real_sx = sx;
A few lines later, rsync checks for a fuzzy basis file; if it finds
one, it sets statret = 0, and that change does /not/ propagate to
real_ret. Thu...