search for: retry_open_count

...+ +# The minimum time for the test should be 2+4+8+16 = 30 seconds. +start_t=`stat -c '%Z' retry-reopen-fail-start` +end_t=`date +'%s'` +if [ $((end_t - start_t)) -lt 30 ]; then + echo "$0: test ran too quickly" + exit 1 +fi + +# Check the handle was opened 5 times. +retry_open_count=`cat retry-reopen-fail-open-count` +if [ $retry_open_count -ne 5 ]; then + echo "$0: retry-reopen-fail-open-count ($retry_open_count) != 5" + exit 1 +fi diff --git a/tests/test-retry.sh b/tests/test-retry.sh new file mode 100755 index 0000000..47d6e23 --- /dev/null +++ b/tests/test-...

...echo "$0: test ran too quickly" > + exit 1 > +fi Slows down 'make check'; is there any way we can scale it to be slightly faster, such as using a smaller retry interval than just 1 second as our starting point? > + > +# Check the handle was opened 5 times. > +retry_open_count=`cat retry-reopen-fail-open-count` Another potential 'read' spot. > +if [ $retry_open_count -ne 5 ]; then > + echo "$0: retry-reopen-fail-open-count ($retry_open_count) != 5" > + exit 1 > +fi > diff --git a/tests/test-retry.sh b/tests/test-retry.sh > new...

v2 was here: https://www.redhat.com/archives/libguestfs/2019-September/msg00221.html I think this is more like "the one". It handles reopen failing correctly, and there is a second test for that. I also ran my sshd tests locally and it worked in all scenarios I could think up (except of course sshd not being available at the start, but we want that to fail). Rich.

v1 was here: https://www.redhat.com/archives/libguestfs/2019-September/msg00199.html v2: - Adds a fairly simple yet comprehensive test using sh plugin. - Rebase and retest. Patch 1 is a misc patch not really related to the series. Rich.