search for: result_path

...Inline comments: > Index: include/llvm/Support/FileSystem.h > =================================================================== > --- include/llvm/Support/FileSystem.h (revision 157010) > +++ include/llvm/Support/FileSystem.h (working copy) > @@ -426,12 +454,35 @@ > /// @param result_path Set to the opened file's absolute path. > /// @param makeAbsolute If true and @model is not an absolute path, a temp > /// directory will be prepended. > +/// @param private_file If true file will have permissions set to only > +/// be accessible by the current user....

I now have an implementation of FileOutputBuffer (OutputBuffer was already taken). The patch supports the functionality listed below and I've tested that it works for lld. -------------- next part -------------- A non-text attachment was scrubbed... Name: FileOutputBuffer.patch Type: application/octet-stream Size: 25308 bytes Desc: not available URL:

This is a proposed patch to enhance FileSystem.h to add functionality (getting and setting permission bits and mapping an unmapping files). This implementation follows the N3365 proposal regarding permission bits. This functionality is needed for my next patch which will implement llvm/include/Support/FileOutputBuffer.h which is needed by lld. -------------- next part -------------- A

On Fri, May 18, 2012 at 3:07 PM, Michael Spencer <bigcheesegs at gmail.com> wrote: > >> +  error_code ec = sys::fs::status(filePathTwine, stat); > > stat is undefined if ec isn't success. ec will be success even in the case of > file_not_found. Actually I was wrong. The Windows and UNIX implementation disagree on this point. I'm going to change it to match