search for: resp_data

...on this one. Why are you walking over orders, *then* zones. I *think* you're doing it because you can efficiently fill the bitmaps at a given order for all zones, then move to a new bitmap. But, it would be interesting to document this. > + pos = 0; > + ret = get_unused_pages(vb->resp_data, > + vb->resp_buf_size / sizeof(unsigned long), > + order, &pos); FWIW, get_unsued_pages() is a pretty bad name. "get" usually implies bumping reference counts or consuming something. You're just "recording" or "marking" them. > + if (ret...

...on this one. Why are you walking over orders, *then* zones. I *think* you're doing it because you can efficiently fill the bitmaps at a given order for all zones, then move to a new bitmap. But, it would be interesting to document this. > + pos = 0; > + ret = get_unused_pages(vb->resp_data, > + vb->resp_buf_size / sizeof(unsigned long), > + order, &pos); FWIW, get_unsued_pages() is a pretty bad name. "get" usually implies bumping reference counts or consuming something. You're just "recording" or "marking" them. > + if (ret...

...unction to allow flexibility inside. My first idea has been e.g. auto_io <- function( var_string, factors ) { # e.g. var_string sent as "test_file.txt" factors sent as "x1 + x2 + x3" # input data_name <- get( var_string ) # term_list <- get( factors ) resp_data <- read.table( data_name, header = TRUE ) # fit temp_model <- lm( y ~ factors, data = resp_data ) etc... Neither the read.table() nor the lm() are working because in each case the string is not converted or understood properly. I'm sure this is possible (and in fact probab...

...t >> would be interesting to document this. > > Yes, use the order is somewhat strange, but it's helpful to keep the API simple. > Do you think it's acceptable? Yeah, it's fine. Just comment it, please. >>> + if (ret == -ENOSPC) { >>> + void *new_resp_data; >>> + >>> + new_resp_data = kmalloc(2 * vb->resp_buf_size, >>> + GFP_KERNEL); >>> + if (new_resp_data) { >>> + kfree(vb->resp_data); >>> + vb->resp_data = new_resp_data; >>> + vb->resp_buf_size *= 2; >&...

...t >> would be interesting to document this. > > Yes, use the order is somewhat strange, but it's helpful to keep the API simple. > Do you think it's acceptable? Yeah, it's fine. Just comment it, please. >>> + if (ret == -ENOSPC) { >>> + void *new_resp_data; >>> + >>> + new_resp_data = kmalloc(2 * vb->resp_buf_size, >>> + GFP_KERNEL); >>> + if (new_resp_data) { >>> + kfree(vb->resp_data); >>> + vb->resp_data = new_resp_data; >>> + vb->resp_buf_size *= 2; >&...

...unt *balloon_mnt; #endif > > > > > > +#define BALLOON_CHUNK_BASE_SHIFT 12 #define > > > +BALLOON_CHUNK_SIZE_SHIFT 12 struct balloon_page_chunk { > > > + __le64 base; > > > + __le64 size; > > > +}; > > > + > > > +typedef __le64 resp_data_t; > > > struct virtio_balloon { > > > struct virtio_device *vdev; > > > struct virtqueue *inflate_vq, *deflate_vq, *stats_vq; @@ -67,6 > > > +79,31 @@ struct virtio_balloon { > > > > > > /* Number of balloon pages we've told the Host...

...unt *balloon_mnt; #endif > > > > > > +#define BALLOON_CHUNK_BASE_SHIFT 12 #define > > > +BALLOON_CHUNK_SIZE_SHIFT 12 struct balloon_page_chunk { > > > + __le64 base; > > > + __le64 size; > > > +}; > > > + > > > +typedef __le64 resp_data_t; > > > struct virtio_balloon { > > > struct virtio_device *vdev; > > > struct virtqueue *inflate_vq, *deflate_vq, *stats_vq; @@ -67,6 > > > +79,31 @@ struct virtio_balloon { > > > > > > /* Number of balloon pages we've told the Host...

...given order for all zones, then move to a new bitmap. But, it > would be interesting to document this. > Yes, use the order is somewhat strange, but it's helpful to keep the API simple. Do you think it's acceptable? > > + pos = 0; > > + ret = get_unused_pages(vb->resp_data, > > + vb->resp_buf_size / sizeof(unsigned long), > > + order, &pos); > > FWIW, get_unsued_pages() is a pretty bad name. "get" usually implies > bumping reference counts or consuming something. You're just "recording" > or "markin...

...ff_lastname = WVAL(resp_param, 6); } if (ff_searchcount == 0) @@ -1496,6 +1730,18 @@ break; } + if (ff_lastname > 0 && info_level == 1) + { + mask_len = *(resp_data + ff_lastname); + memcpy(mask, resp_data + ff_lastname + 1, + mask_len); + mask[mask_len] = 0; + } else + { + mask_len = 0; + mask[0] = 0; +...

...C(oom_pages, "pages to free on OOM"); static struct > vfsmount *balloon_mnt; #endif > > +#define BALLOON_CHUNK_BASE_SHIFT 12 > +#define BALLOON_CHUNK_SIZE_SHIFT 12 > +struct balloon_page_chunk { > + __le64 base; > + __le64 size; > +}; > + > +typedef __le64 resp_data_t; > struct virtio_balloon { > struct virtio_device *vdev; > struct virtqueue *inflate_vq, *deflate_vq, *stats_vq; @@ -67,6 +79,31 > @@ struct virtio_balloon { > > /* Number of balloon pages we've told the Host we're not using. */ > unsigned int num_pages; &gt...

...C(oom_pages, "pages to free on OOM"); static struct > vfsmount *balloon_mnt; #endif > > +#define BALLOON_CHUNK_BASE_SHIFT 12 > +#define BALLOON_CHUNK_SIZE_SHIFT 12 > +struct balloon_page_chunk { > + __le64 base; > + __le64 size; > +}; > + > +typedef __le64 resp_data_t; > struct virtio_balloon { > struct virtio_device *vdev; > struct virtqueue *inflate_vq, *deflate_vq, *stats_vq; @@ -67,6 +79,31 > @@ struct virtio_balloon { > > /* Number of balloon pages we've told the Host we're not using. */ > unsigned int num_pages; &gt...

...vq; @@ -67,6 +81,20 @@ struct virtio_balloon { /* Number of balloon pages we've told the Host we're not using. */ unsigned int num_pages; + /* Pointer to the response header. */ + struct virtio_balloon_resp_hdr resp_hdr; + /* Pointer to the start address of response data. */ + __le64 *resp_data; + /* Size of response data buffer. */ + unsigned int resp_buf_size; + /* Pointer offset of the response data. */ + unsigned int resp_pos; + /* Bitmap used to save the pfns info */ + unsigned long *page_bitmap[PAGE_BMAP_COUNT_MAX]; + /* Number of split page bitmaps */ + unsigned int nr_page_bmap; +...

This patch set contains two parts of changes to the virtio-balloon. One is the change for speeding up the inflating & deflating process, the main idea of this optimization is to use bitmap to send the page information to host instead of the PFNs, to reduce the overhead of virtio data transmission, address translation and madvise(). This can help to improve the performance by about 85%.

This patch set contains two parts of changes to the virtio-balloon. One is the change for speeding up the inflating & deflating process, the main idea of this optimization is to use bitmap to send the page information to host instead of the PFNs, to reduce the overhead of virtio data transmission, address translation and madvise(). This can help to improve the performance by about 85%.

Take over this work from Liang. This patch series implements two optimizations: 1) transfer pages in chuncks between the guest and host; 1) transfer the guest unused pages to the host so that they can be skipped to migrate in live migration. Please check patch 0003 for more details about optimization 1). For an idle guest with 8GB RAM, optimization 2) can help shorten the total live migration

Take over this work from Liang. This patch series implements two optimizations: 1) transfer pages in chuncks between the guest and host; 1) transfer the guest unused pages to the host so that they can be skipped to migrate in live migration. Please check patch 0003 for more details about optimization 1). For an idle guest with 8GB RAM, optimization 2) can help shorten the total live migration

...o_balloon { > > /* Number of balloon pages we've told the Host we're not using. */ > unsigned int num_pages; > + /* Pointer to the response header. */ > + struct virtio_balloon_resp_hdr resp_hdr; > + /* Pointer to the start address of response data. */ > + __le64 *resp_data; > + /* Size of response data buffer. */ > + unsigned int resp_buf_size; > + /* Pointer offset of the response data. */ > + unsigned int resp_pos; > + /* Bitmap used to save the pfns info */ > + unsigned long *page_bitmap[PAGE_BMAP_COUNT_MAX]; > + /* Number of split page bitmap...

...o_balloon { > > /* Number of balloon pages we've told the Host we're not using. */ > unsigned int num_pages; > + /* Pointer to the response header. */ > + struct virtio_balloon_resp_hdr resp_hdr; > + /* Pointer to the start address of response data. */ > + __le64 *resp_data; > + /* Size of response data buffer. */ > + unsigned int resp_buf_size; > + /* Pointer offset of the response data. */ > + unsigned int resp_pos; > + /* Bitmap used to save the pfns info */ > + unsigned long *page_bitmap[PAGE_BMAP_COUNT_MAX]; > + /* Number of split page bitmap...

...ue *inflate_vq, *deflate_vq, *stats_vq, *req_vq; /* The balloon servicing is delegated to a freezable workqueue. */ struct work_struct update_balloon_stats_work; @@ -75,6 +75,8 @@ struct virtio_balloon { void *resp_hdr; /* Pointer to the start address of response data. */ unsigned long *resp_data; + /* Size of response data buffer. */ + unsigned long resp_buf_size; /* Pointer offset of the response data. */ unsigned long resp_pos; /* Bitmap and bitmap count used to tell the host the pages */ @@ -83,6 +85,8 @@ struct virtio_balloon { unsigned int nr_page_bmap; /* Used to record the...

...2 files changed, 157 insertions(+), 5 deletions(-) diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c index 3f4a161..bcf2baa 100644 --- a/drivers/virtio/virtio_balloon.c +++ b/drivers/virtio/virtio_balloon.c @@ -64,7 +64,7 @@ struct balloon_page_chunk { typedef __le64 resp_data_t; struct virtio_balloon { struct virtio_device *vdev; - struct virtqueue *inflate_vq, *deflate_vq, *stats_vq; + struct virtqueue *inflate_vq, *deflate_vq, *stats_vq, *host_req_vq; /* The balloon servicing is delegated to a freezable workqueue. */ struct work_struct update_balloon_stats_wo...