search for: resolvebitreference

...OpInit::Fold(...). However as I'm looking at the code, while adding this argument to Fold for TGParser use is not an issue as it has a RecordKeeper instance, the other Record classes have a problem because they lack this type of instance. See for example the implementation of Record.cpp:OpInit::resolveBitReference(...). These methods (such as resolveBitReference(...) and resolveReferences(...) need a context containing a RecordKeeper for their evaluation. A cursory glance for the uses of Record::setName(...) seems to imply that adding a RecordKeeper& argument would not be an issue. I'll keep on look...

On Dec 12, 2010, at 10:54 AM, Garrison Venn wrote: > > Hey Chris, > > The following patch removes all global references to a RecordKeeper instance for the tblgen > utility. This effort was motivated by the FIXME remark, in TableGen.cpp. Although a few files > were touched, the main change was to Record.h. > > The patch takes the simple approach of adding a RecordKeeper

....). However as I'm looking at the code, while adding this argument to Fold > for TGParser use is not an issue as it has a RecordKeeper instance, the other Record > classes have a problem because they lack this type of instance. See for example the > implementation of Record.cpp:OpInit::resolveBitReference(...). These methods (such as > resolveBitReference(...) and resolveReferences(...) need a context containing a RecordKeeper > for their evaluation. A cursory glance for the uses of Record::setName(...) seems to imply that adding a > RecordKeeper& argument would not be an issue. I'...

Hey Chris, The following patch removes all global references to a RecordKeeper instance for the tblgen utility. This effort was motivated by the FIXME remark, in TableGen.cpp. Although a few files were touched, the main change was to Record.h. The patch takes the simple approach of adding a RecordKeeper reference to TGParser, and any needed emitter helper classes. In addition, since some of