search for: resolve_windows_path

In the current Perl library we have a function called resolve_windows_path which handles the useful [for Windows guests] case where we need to resolve the true, case-sensitive path behind a case-insensitive Windows path. For example, a Windows path like "C:\Windows\System32" can be presented to Linux by NTFS 3g in a variety of ways, eg: /WINDOWS/system32 /...

...sed Perl module includes. --- cat/virt-cat.pl | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/cat/virt-cat.pl b/cat/virt-cat.pl index 8db5348..748dbb8 100755 --- a/cat/virt-cat.pl +++ b/cat/virt-cat.pl @@ -25,9 +25,6 @@ use Sys::Guestfs::Lib qw(open_guest get_partitions resolve_windows_path inspect_operating_systems mount_operating_system); use Pod::Usage; use Getopt::Long; -use Data::Dumper; -use File::Temp qw/tempdir/; -use XML::Writer; use Locale::TextDomain 'libguestfs'; =encoding utf8 -- 1.6.2.5

.../disk/source/@file')); - die "$images[0] seems to have no disk devices\n" unless @disks; + die __x("{imagename} seems to have no disk devices\n", + imagename => $images[0]) + unless @disks; @images = map { $_->getData } @disks; } @@ -258,7 +271,7 @@ sub resolve_windows_path my $path = shift; if (substr ($path, 0, 1) ne "/") { - warn "resolve_windows_path: path must start with a / character"; + warn __"resolve_windows_path: path must start with a / character"; return undef; } @@ -740,7 +753,7 @@ sub _load_windows_regis...

...13 deletions(-) diff --git a/perl/lib/Sys/Guestfs/Lib.pm b/perl/lib/Sys/Guestfs/Lib.pm index 1f84bc6..dfa79af 100644 --- a/perl/lib/Sys/Guestfs/Lib.pm +++ b/perl/lib/Sys/Guestfs/Lib.pm @@ -66,7 +66,8 @@ use vars qw(@EXPORT_OK @ISA); @ISA = qw(Exporter); @EXPORT_OK = qw(open_guest get_partitions resolve_windows_path inspect_all_partitions inspect_partition - inspect_operating_systems mount_operating_system inspect_in_detail); + inspect_operating_systems mount_operating_system inspect_in_detail + inspect_linux_kernel); =head2 open_guest @@ -1551,10 +1552,19 @@ sub _check_for_kernels...

...Note that before libguestfs 1.19.35 * you had to download the file and parse it using hivex(3). Since diff --git a/perl/lib/Sys/Guestfs/Lib.pm b/perl/lib/Sys/Guestfs/Lib.pm index 33e8acb..5dde409 100644 --- a/perl/lib/Sys/Guestfs/Lib.pm +++ b/perl/lib/Sys/Guestfs/Lib.pm @@ -356,6 +356,9 @@ sub resolve_windows_path my $r; eval { $r = $g->case_sensitive_path ($path); }; + + $r = undef if defined $r && ! $g->exists ($r); + return $r; } diff --git a/src/inspect-apps.c b/src/inspect-apps.c index e9f020a..f65c70a 100644 --- a/src/inspect-apps.c +++ b/src/inspect-apps.c @@ -418,...

Proposed patches to fix https://bugzilla.redhat.com/show_bug.cgi?id=858126

...} else { + $g->add_drive_ro ($_); + } } return wantarray ? ($g, $conn, $dom, @images) : $g @@ -239,7 +239,7 @@ sub _is_pv { my $t = shift; foreach (@_) { - return 1 if $_ eq $t; + return 1 if $_ eq $t; } 0; } @@ -271,8 +271,8 @@ sub resolve_windows_path my $path = shift; if (substr ($path, 0, 1) ne "/") { - warn __"resolve_windows_path: path must start with a / character"; - return undef; + warn __"resolve_windows_path: path must start with a / character"; + return undef; } my @elem...

As described here previously: https://www.redhat.com/archives/libguestfs/2010-March/msg00129.html Here is the three part patch to reimplement virt-win-reg to support exporting and merging Windows Registry entries in the 'regedit' format. Tested by me on a local Windows VM. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones virt-top is 'top'