search for: rerr_signal

...OS: All Status: NEW Severity: trivial Priority: P5 Component: core Assignee: wayned at samba.org Reporter: delan at azabani.com QA Contact: rsync-qa at samba.org If rsync receives a signal that would cause it to exit with RERR_SIGNAL, I think that it should kill() itself with that signal instead of calling exit(RERR_SIGNAL). With the current behaviour, for example, if rsync is invoked from a shell script and the user sends ^C, the shell script will not terminate unless it has additional machinery to check the exit status of ev...

...t by the server. +dit(bf(RERR_STARTCLIENT 5)) Error starting client-server protocol + dit(bf(RERR_SOCKETIO 10)) Error in socket IO dit(bf(RERR_FILEIO 11)) Error in file IO dit(bf(RERR_STREAMIO 12)) Error in rsync protocol data stream @@ -1126,6 +1128,7 @@ dit(bf(RERR_SIGNAL 20)) Received SIGUSR1 or SIGINT dit(bf(RERR_WAITCHILD 21)) Some error returned by waitpid() dit(bf(RERR_MALLOC 22)) Error allocating core memory buffers +dit(bf(RERR_PARTIAL 23)) Partial transfer dit(bf(RERR_TIMEOUT 30)) Timeout in data send/receive e...

...#define RERR_IPC 14 /* error in IPC code */ + #define RERR_PRESCRIPT 17 /* error running pre-transfer script */ + #define RERR_POSTSCRIPT 18 /* error running post-transfer script */ + #define RERR_SCRIPT 19 /* system error running transfer script */ + #define RERR_SIGNAL 20 /* status returned when sent SIGUSR1, SIGINT */ #define RERR_WAITCHILD 21 /* some error returned by waitpid() */ #define RERR_MALLOC 22 /* error allocating core memory buffers */ Common subdirectories: rsync-2.5.6.orig/lib and rsync-2.5.6/lib diff --exclude='*.o...

rsync had been working fine for months. Now, I get this error in my rsyncd log. 2001/08/15 07:18:59 [433] transfer interrupted (code 20) at rsync.c(229) ++++++ rsyncd.conf ++++++++ motd file = /etc/rsync.motd log file = /var/log/rsyncd.log pid file = /var/run/rsyncd.pid lock file = /var/run/rsync.lock max connections = 5 [all] comment = sync all path = / read only = yes

...m to return these values: * diff -ur rsync-2.6.6/log.c rsync/log.c --- rsync-2.6.6/log.c Fri Jun 10 02:27:22 2005 +++ rsync/log.c Sat Jan 28 04:37:10 2006 @@ -66,6 +66,7 @@ { RERR_MESSAGEIO , "errors with program diagnostics" }, { RERR_IPC , "error in IPC code" }, { RERR_SIGNAL , "received SIGUSR1 or SIGINT" }, + { RERR_CRASH , "*** WE HAVE CRASHED :-( ***" }, { RERR_WAITCHILD , "some error returned by waitpid()" }, { RERR_MALLOC , "error allocating core memory buffers" }, { RERR_PARTIAL , "some files could...

...flush(); io_set_error_fd(-1); ! write(cleanup_pipe[1], ".", 1); ! if (waitpid(pid, &status, 0) != pid) { ! rprintf(FERROR,"cleanup in do_recv failed\n"); ! exit_cleanup(RERR_SOCKETIO); ! } return status; } *************** *** 867,878 **** exit_cleanup(RERR_SIGNAL); } - static RETSIGTYPE sigusr2_handler(int UNUSED(val)) { - extern int log_got_error; - if (log_got_error) _exit(RERR_PARTIAL); - _exit(0); - } - static RETSIGTYPE sigchld_handler(int UNUSED(val)) { #ifdef WNOHANG int cnt, status; --- 885,890 ---- *************** *** 964,970 ****...

...@@ -34,6 +34,7 @@ #define RERR_STREAMIO 12 /* error in rsync protocol data stream */ #define RERR_MESSAGEIO 13 /* errors with program diagnostics */ #define RERR_IPC 14 /* error in IPC code */ +#define RERR_FNAMECONV 15 /* error in filename conversion */ #define RERR_SIGNAL 20 /* status returned when sent SIGUSR1, SIGINT */ #define RERR_WAITCHILD 21 /* some error returned by waitpid() */ diff -rupNP rsync-2.6.2/flist.c rsync-2.6.2-fnameconv.clean/flist.c --- rsync-2.6.2/flist.c 2004-04-29 22:37:15.000000000 +0300 +++ rsync-2.6.2-fnameconv.clean/flist.c...

> Just curious: what about the rsync+ patch? Thanks for the reminder. I've just committed Jos's rsync+ patch onto the "branch_mbp_rsyncplus_merge" branch. If it works OK and nobody screams I will move it across onto the main tree tomorrow or Wednesday. I see the patch doesn't add documentation about the new options to the man page, so we should fix that in the future.