search for: requireanalysispass

...ysisPass for PSI before each >>> non-module pass that needs it. PSI can be technically >>> invalidated but unlikely. If it does, we insert another >>> RequiredAnalysisPass[6]. >>> >>> - Conditionally insert RequireAnalysisPass for BFI, if >>> PGO, right before each loop pass that needs it. This >>> doesn't seem avoidable because BFI can be invalidated >>> whenever the CFG changes. We detect PGO based on the >>> command line flags and/...

...rofile summary in the IR is written in the pass pipeline [5]. This would avoid the need to insert RequiredAnalysisPass for PSI before each non-module pass that needs it. PSI can be technically invalidated but unlikely. If it does, we insert another RequiredAnalysisPass [6]. - Conditionally insert RequireAnalysisPass for BFI, if PGO, right before each loop pass that needs it. This doesn't seem avoidable because BFI can be invalidated whenever the CFG changes. We detect PGO based on the command line flags and/or whether the module has the profile summary info (we may need to pass the module to more functions...

...ritten in the > pass pipeline [5]. This would avoid the need to insert RequiredAnalysisPass > for PSI before each non-module pass that needs it. PSI can be technically > invalidated but unlikely. If it does, we insert another RequiredAnalysisPass > [6]. > > - Conditionally insert RequireAnalysisPass for BFI, if PGO, right before > each loop pass that needs it. This doesn't seem avoidable because BFI can > be invalidated whenever the CFG changes. We detect PGO based on the command > line flags and/or whether the module has the profile summary info (we may > need to pass the modu...

Overall seems fine to me. On 3/11/19 8:12 PM, Hiroshi Yamauchi wrote: > Here's a revised approach based on the discussion: > > - Cache PSI right after the profile summary in the IR is written in > the pass pipeline. This would avoid the need to insert > RequireAnalysisPass for PSI before each non-module pass that needs it. > PSI can be technically invalidated but unlikely as PSI is immutable. > If it does, we can insert another RequireAnalysisPass. ProfileSummaryInfo::invalidate always return false, so it does not need any extra handling (as soon as it finds...

...ass pipeline [5]. This would avoid the need to insert RequiredAnalysisPass >> for PSI before each non-module pass that needs it. PSI can be technically >> invalidated but unlikely. If it does, we insert another RequiredAnalysisPass >> [6]. >> >> - Conditionally insert RequireAnalysisPass for BFI, if PGO, right before >> each loop pass that needs it. This doesn't seem avoidable because BFI can >> be invalidated whenever the CFG changes. We detect PGO based on the command >> line flags and/or whether the module has the profile summary info (we >> may need...

...n-module pass that needs it. PSI can be >>>>> technically invalidated but unlikely. If it >>>>> does, we insert another RequiredAnalysisPass[6]. >>>>> >>>>> - Conditionally insert RequireAnalysisPass for >>>>> BFI, if PGO, right before each loop pass that >>>>> needs it. This doesn't seem avoidable because >>>>> BFI can be invalidated whenever the CFG >>>>>...

On 8/7/19 6:20 PM, Hiroshi Yamauchi wrote: > I basically run "clang > -fexperimental-new-pass-manager -print-after-all ..." > > It's conceivable that something is different in our setup or in clang > (from opt)... I'll see if I can reproduce it outside our setup. Does it depend on machine architecture? I generally use x86... regards,   Fedor. > > Thanks.