Displaying 2 results from an estimated 2 matches for "requests_inflight".
2012 May 14
1
[PATCH, v2] qemu/xendisk: properly update stats in ioreq_release()
While for the "normal" case (called from blk_send_response_all())
decrementing requests_finished is correct, doing so in the parse error
case is wrong; requests_inflight needs to be decremented instead.
Change in v2: Adjust coding style.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
--- a/hw/xen_disk.c
+++ b/hw/xen_disk.c
@@ -154,7 +154,7 @@ static void ioreq_finish(struct ioreq *i
blkdev->requests_finished++;
}
-static void ioreq_release(struc...
2012 May 14
0
Re: [Qemu-devel] [PATCH, v2] qemu/xendisk: properly update stats in ioreq_release()
Am 14.05.2012 12:30, schrieb Jan Beulich:
> While for the "normal" case (called from blk_send_response_all())
> decrementing requests_finished is correct, doing so in the parse error
> case is wrong; requests_inflight needs to be decremented instead.
>
> Change in v2: Adjust coding style.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
I think it would be nicer if a struct ioreq had an explicit state so
that you don''t have to pass the right state when releasing it. But
anyway, th...