search for: replaygain_synthesi

flac.exe crashes if I try to decode multichannel flac file with RG tags using the following command line: flac.exe -d --apply-replaygain-which-is-not-lossless test_6ch.flac The code in replaygain_synthesis project uses FLAC_SHARE__MAX_SUPPORTED_CHANNELS which is equal to 2. The fix just changes 2 to FLAC__MAX_CHANNELS. -------------- next part -------------- A non-text attachment was scrubbed... Name: rg_crash.patch Type: application/octet-stream Size: 517 bytes Desc: not available Url : http://list...

The file src/share/replaygain_synthesis/include/private/fast_float_math_hack.h redefines 'tanh' as 'tanhf'. This file is intended for Intel Compiler only, but it includes outdated mathf.h and doesn't work with current versions of ICC. The fixes are trivial though, and I compiled 2 versions of flac.exe: with this ...

I've not benchmarked to know if their is any real benefit, but changing the include in fast_float_math_hack.h to <mathimf.h> is all that is required to use the latest ICC. John On 17/05/2014 10:26, lvqcl wrote: > The file > src/share/replaygain_synthesis/include/private/fast_float_math_hack.h > redefines 'tanh' as 'tanhf'. This file is intended for Intel Compiler only, > but it includes outdated mathf.h and doesn't work with current versions > of ICC. > > The fixes are trivial though, and I compiled 2 versions of...

...lain ./configure as well as with --enable-static > CC grabbag/cuesheet.lo > grabbag/cuesheet.c: In function 'grabbag__cuesheet_emit': > grabbag/cuesheet.c:645:47: warning: declaration of 'index' shadows a > global declaration [-Wshadow] > [...] > CC > replaygain_synthesis/replaygain_synthesis_libreplaygain_synthesis_la-replaygain_synthesis.lo > replaygain_synthesis/replaygain_synthesis.c: In function > 'FLAC__replaygain_synthesis__init_dither_context': > replaygain_synthesis/replaygain_synthesis.c:212:6: warning: > declaration of 'index...

a) replaces float literal by double (there's no point to multiply double variable 'sample' by float const) b) replaces ifdef __ICL --> if 0 (even intel compiler doesn't have mathf.h) -------------- next part -------------- A non-text attachment was scrubbed... Name: rg_synth.patch Type: application/octet-stream Size: 1157 bytes Desc: not available Url :

...++ test/test_seeking.sh | 2 ++ test/test_streams.sh | 2 ++ 8 files changed, 17 insertions(+), 0 deletions(-) diff --git a/test/test_bins.sh b/test/test_bins.sh index 55a0b8a..9b1fa0f 100755 --- a/test/test_bins.sh +++ b/test/test_bins.sh @@ -37,6 +37,8 @@ LD_LIBRARY_PATH=../src/share/replaygain_synthesis/.libs:$LD_LIBRARY_PATH LD_LIBRARY_PATH=../src/share/utf8/.libs:$LD_LIBRARY_PATH LD_LIBRARY_PATH=../obj/$BUILD/lib:$LD_LIBRARY_PATH export LD_LIBRARY_PATH +export MALLOC_CHECK_=3 +export MALLOC_PERTURB_==$(($RANDOM % 255 + 1)) PATH=../src/flac:$PATH PATH=../obj/$BUILD/bin:$PATH BINS_PATH=../....

...-Winline -arch i386 -arch i386 -o flac analyze.o decode.o encode.o foreign_metadata.o main.o local_string_utils.o utils.o vorbiscomment.o ../../src/share/grabbag/.libs/libgrabbag.a ../../src/share/getopt/libgetopt.a ../../src/share/replaygain_analysis/.libs/libreplaygain_analysis.a ../../src/share/replaygain_synthesis/.libs/libreplaygain_synthesis.a ../../src/share/utf8/.libs/libutf8.a ../../src/libFLAC/.libs/libFLAC.a -L/Users/glennm/libOGG-i386/lib /Users/glennm/libOGG-i386/lib/libogg.dylib -liconv -lm i686-apple-darwin10-gcc-4.2.1: /Users/glennm/libOGG-i386/lib/libogg.dylib: No such file or directory Could...

...on/Makefile.am | 2 - src/libFLAC/Makefile.am | 3 + src/plugin_common/Makefile.am | 2 - src/share/getopt/Makefile.am | 2 - src/share/grabbag/Makefile.am | 2 - src/share/replaygain_analysis/Makefile.am | 2 - src/share/replaygain_synthesis/Makefile.am | 2 - src/share/utf8/Makefile.am | 2 - 18 files changed, 8 insertions(+), 195 deletions(-) diff --git a/Makefile.am b/Makefile.am index 0a65206..45a0260 100644 --- a/Makefile.am +++ b/Makefile.am @@ -28,8 +28,6 @@ # distclean: remove everything except what goes...

...---------------------------- src/libFLAC/Makefile.am | 3 + src/plugin_common/Makefile.am | 2 - src/share/getopt/Makefile.am | 2 - src/share/grabbag/Makefile.am | 2 - src/share/replaygain_analysis/Makefile.am | 2 - src/share/replaygain_synthesis/Makefile.am | 2 - src/share/utf8/Makefile.am | 2 - 19 files changed, 25 insertions(+), 389 deletions(-) delete mode 100644 m4/endian.m4 -- 1.8.0.1.525.gaaf5ad5

...ze.o decode.o encode.o foreign_metadata.o main.o >> local_string_utils.o utils.o vorbiscomment.o >> ../../src/share/grabbag/.libs/libgrabbag.a >> ../../src/share/getopt/libgetopt.a >> ../../src/share/replaygain_analysis/.libs/libreplaygain_analysis.a >> ../../src/share/replaygain_synthesis/.libs/libreplaygain_synthesis.a >> ../../src/share/utf8/.libs/libutf8.a ../../src/libFLAC/.libs/libFLAC.a >> -L/Users/glennm/libOGG-i386/lib >> /Users/glennm/libOGG-i386/lib/libogg.dylib -liconv -lm >> i686-apple-darwin10-gcc-4.2.1: >> /Users/glennm/libOGG-i386/lib/li...

...| 2 +- src/plugin_common/Makefile.am | 2 +- src/plugin_xmms/Makefile.am | 3 +-- src/share/getopt/Makefile.am | 2 +- src/share/grabbag/Makefile.am | 2 +- src/share/replaygain_analysis/Makefile.am | 2 +- src/share/replaygain_synthesis/Makefile.am | 2 +- src/share/utf8/Makefile.am | 2 +- src/test_grabbag/cuesheet/Makefile.am | 1 + src/test_grabbag/picture/Makefile.am | 2 +- src/test_libFLAC++/Makefile.am | 2 +- src/test_libFLAC/Makefile.am | 2 +- src/te...

Hi all, The latest pre-release is here: http://downloads.xiph.org/releases/flac/beta/flac-1.3.0pre3.tar.xz but there will probably need to be at least one more. I've tested this on x86_64-linux powerpc-linux i386-openbsd5.2 i386-freebsd9 The majority of changes since the last pre-release is the addition of Janne Hyv?rinen's utf8 I/O functionality. Janne's

Erik de Castro Lopo wrote: > lvqcl wrote: > > > Some projects/makefiles add both 'include' and 'include/share' > > to the list of additional include directories. > > I think that is suboptimal. > > > For example, src/share/utf8/utf8.c includes 'include/share/alloc.h' > > as "share/alloc.h" but

Dear FLAC devs, I would like to get some of our patches merged into master. Most of them deal with adhering to GNU conventions, respectively not overriding flags/variables that are up to the user to set. For instance, honoring $(htmldir) is important, as we have installation paths for the documentation that differ from what is currently coded in the various Makefile.am's. Regards David

...inet_ntoa(from.sin_addr), g_ntohs(from.sin_port)); diff --git a/src/share/Makefile.am b/src/share/Makefile.am index 82d0fc96..8e3984a1 100644 --- a/src/share/Makefile.am +++ b/src/share/Makefile.am @@ -92,9 +92,3 @@ replaygain_analysis_libreplaygain_analysis_la_SOURCES = replaygain_analysis/repl replaygain_synthesis_libreplaygain_synthesis_la_CFLAGS = -I $(top_srcdir)/src/share/replaygain_synthesis/include replaygain_synthesis_libreplaygain_synthesis_la_SOURCES = replaygain_synthesis/replaygain_synthesis.c - -debug: - $(MAKE) all CFLAGS="@DEBUG@" - -profile: - $(MAKE) all CFLAGS="@PROFILE@&quo...

...E *grabbag__file_get_binary_stdin() return stdin; } -FILE *grabbag__file_get_binary_stdout() +FILE *grabbag__file_get_binary_stdout(void) { /* if something breaks here it is probably due to the presence or * absence of an underscore before the identifiers 'setmode', --- src/share/replaygain_synthesis/replaygain_synthesis.c-dist 2005-05-25 16:07:23.000000000 +0200 +++ src/share/replaygain_synthesis/replaygain_synthesis.c 2005-05-25 16:07:27.000000000 +0200 @@ -86,7 +86,7 @@ * XORed values of both generators. */ -static unsigned int random_int_() +static unsigned int random_int_(void) {...

...inet_ntoa(from.sin_addr), g_ntohs(from.sin_port)); diff --git a/src/share/Makefile.am b/src/share/Makefile.am index 82d0fc96..8e3984a1 100644 --- a/src/share/Makefile.am +++ b/src/share/Makefile.am @@ -92,9 +92,3 @@ replaygain_analysis_libreplaygain_analysis_la_SOURCES = replaygain_analysis/repl replaygain_synthesis_libreplaygain_synthesis_la_CFLAGS = -I $(top_srcdir)/src/share/replaygain_synthesis/include replaygain_synthesis_libreplaygain_synthesis_la_SOURCES = replaygain_synthesis/replaygain_synthesis.c - -debug: - $(MAKE) all CFLAGS="@DEBUG@" - -profile: - $(MAKE) all CFLAGS="@PROFILE@&quo...

...libutf8.la \ + $(top_builddir)/src/share/replaygain_analysis/libreplaygain_analysis.la \ $(top_builddir)/src/share/grabbag/libgrabbag.la \ $(top_builddir)/src/share/getopt/libgetopt.a \ - $(top_builddir)/src/share/replaygain_analysis/libreplaygain_analysis.la \ $(top_builddir)/src/share/replaygain_synthesis/libreplaygain_synthesis.la \ $(top_builddir)/src/libFLAC/libFLAC.la \ @OGG_LIBS@ \ diff --git a/src/flac/Makefile.lite b/src/flac/Makefile.lite index 5d7a01e..0e5329f 100644 --- a/src/flac/Makefile.lite +++ b/src/flac/Makefile.lite @@ -24,12 +24,12 @@ libdir = $(topdir)/obj/$(BUILD)/li...

...tf8.la \ + $(top_builddir)/src/share/replaygain_analysis/libreplaygain_analysis.la \ $(top_builddir)/src/share/grabbag/libgrabbag.la \ $(top_builddir)/src/share/getopt/libgetopt.a \ - $(top_builddir)/src/share/replaygain_analysis/libreplaygain_analysis.la \ $(top_builddir)/src/share/replaygain_synthesis/libreplaygain_synthesis.la \ $(top_builddir)/src/libFLAC/libFLAC.la \ @OGG_LIBS@ \ diff --git a/src/flac/Makefile.lite b/src/flac/Makefile.lite index 5d7a01e..0e5329f 100644 --- a/src/flac/Makefile.lite +++ b/src/flac/Makefile.lite @@ -24,12 +24,12 @@ libdir = $(topdir)/obj/$(BUILD)/li...

Hi Erik, I've found a middleground for the problem of setting default CFLAGS. I've gone back to setting them if {C,CXX,CPP,LD}FLAGS are unset at the onset of the configure script (i.e., the user hasn't specified anything) and then proceed to set them to the defaults as before. This has been suggested before: https://lists.gnu.org/archive/html/autoconf/2006-04/msg00022.html In