search for: replaygain_analysis

...ts/makefiles add both 'include' and 'include/share' to the list of additional include directories. For example, src/share/utf8/utf8.c includes 'include/share/alloc.h' as "share/alloc.h" but 'include/share/utf8.h' as just "utf8.h". Also src/share/replaygain_analysis/replaygain_analysis.c includes "replaygain_analysis.h", not "share/replaygain_analysis.h". Does it make sense? or is it better to explicitely add "share/" prefix and remove 'include/share' from the list of include directories?

...dditional include directories. > > I think that is suboptimal. > > > For example, src/share/utf8/utf8.c includes 'include/share/alloc.h' > > as "share/alloc.h" but 'include/share/utf8.h' as just "utf8.h". > > > > Also src/share/replaygain_analysis/replaygain_analysis.c includes > > "replaygain_analysis.h", not "share/replaygain_analysis.h". > > > > Does it make sense? or is it better to explicitely add "share/" prefix > > and remove 'include/share' from the list of include direct...

...de/share' > to the list of additional include directories. I think that is suboptimal. > For example, src/share/utf8/utf8.c includes 'include/share/alloc.h' > as "share/alloc.h" but 'include/share/utf8.h' as just "utf8.h". > > Also src/share/replaygain_analysis/replaygain_analysis.c includes > "replaygain_analysis.h", not "share/replaygain_analysis.h". > > Does it make sense? or is it better to explicitely add "share/" prefix > and remove 'include/share' from the list of include directories? Thanks for p...

another small bug: in src\share\replaygain_analysis\replaygain_analysis.c there are two assignments to sampleWindow: sampleWindow = (int) ceil ((double)samplefreq * (double)RMS_WINDOW_TIME / 1000.0); sampleWindow = (replaygainfilter->rate * RMS_WINDOW_TIME + 1000-1) / 1000; -------------- next part -------------- A non-text a...

...gt; The replay gain code has dos line endings in CVS, which causes problems > for the Sun compiler, among others. Attached is a patch for the lazy, > but it's probably easier to fix locally and commit. Now with actual patch... -r -------------- next part -------------- Index: src/share/replaygain_analysis/replaygain_analysis.c =================================================================== RCS file: /cvsroot/flac/flac/src/share/replaygain_analysis/replaygain_analysis.c,v retrieving revision 1.1 diff -u -r1.1 replaygain_analysis.c --- src/share/replaygain_analysis/replaygain_analysis.c 17 Dec 200...

The replay gain code has dos line endings in CVS, which causes problems for the Sun compiler, among others. Attached is a patch for the lazy, but it's probably easier to fix locally and commit. -r

I noticed that 32-bit flac (from git) compiled with GCC 4.8.3 or 4.9.0 calculates incorrect ReplayGain values. The most common value it produces is -55.17 dB. It is possible to avoid this bug by compiling src/share/replaygain_analysis/replaygain_analysis.c a) either without -msse2 option b) or with -O2 instead of -O3 c) another solution is to add -mfpmath=sse option along with -msse2. For GCC 4.9.0 it's enough to add __attribute__ ((__target__ ("arch=i686"))) or __attribute__ ((__target__ ("fpmath=sse")...

.../libOGG-i386/include -O3 -funroll-loops -finline-functions -Wall -W -Winline -arch i386 -arch i386 -o flac analyze.o decode.o encode.o foreign_metadata.o main.o local_string_utils.o utils.o vorbiscomment.o ../../src/share/grabbag/.libs/libgrabbag.a ../../src/share/getopt/libgetopt.a ../../src/share/replaygain_analysis/.libs/libreplaygain_analysis.a ../../src/share/replaygain_synthesis/.libs/libreplaygain_synthesis.a ../../src/share/utf8/.libs/libutf8.a ../../src/libFLAC/.libs/libFLAC.a -L/Users/glennm/libOGG-i386/lib /Users/glennm/libOGG-i386/lib/libogg.dylib -liconv -lm i686-apple-darwin10-gcc-4.2.1: /Users/gle...

...44,10 @@ utils.h \ vorbiscomment.h +if OS_IS_WINDOWS +win_utf8_lib = $(top_builddir)/src/share/win_utf8_io/libwin_utf8_io.la +endif + flac_LDADD = \ $(top_builddir)/src/share/utf8/libutf8.la \ $(top_builddir)/src/share/grabbag/libgrabbag.la \ @@ -51,6 +55,7 @@ $(top_builddir)/src/share/replaygain_analysis/libreplaygain_analysis.la \ $(top_builddir)/src/share/replaygain_synthesis/libreplaygain_synthesis.la \ $(top_builddir)/src/libFLAC/libFLAC.la \ + $(win_utf8_lib) \ @LIBICONV@ \ -lm --- flac-1.3.0/src/metaflac/Makefile.am.orig 2013-05-26 09:30:33.936201600 +0000 +++ flac-1.3.0/src/metafla...

...ils.h \ vorbiscomment.h +if OS_IS_WINDOWS +win_utf8_lib = $(top_builddir)/src/share/win_utf8_io/libwin_utf8_io.la +endif flac_LDADD = \ $(top_builddir)/src/share/utf8/libutf8.la \ $(top_builddir)/src/share/grabbag/libgrabbag.la \ @@ -51,7 +54,7 @@ flac_LDADD = \ $(top_builddir)/src/share/replaygain_analysis/libreplaygain_analysis.la \ $(top_builddir)/src/share/replaygain_synthesis/libreplaygain_synthesis.la \ $(top_builddir)/src/libFLAC/libFLAC.la \ - @LIBICONV@ \ + $(win_utf8_lib) @LIBICONV@ \ -lm CLEANFILES = flac.exe diff --git a/src/metaflac/Makefile.am b/src/metaflac/Makefile.am index d6...

Josh: > fixed, thanks! Thanks. However, I think there is a better patch to fix these problems. I reworked this patch not long ago to do better testing for what inline to use in configure, and also a better way to calculate the size of the #defines in replaygain_analysis.c. This was submitted to the SourceForge bug tracker as bug 1701960. See here, and note attached patch. http://sourceforge.net/tracker/index.php?func=detail&group_id=13478&atid=313478&aid=1701960 I'd recommend backing out my previous patch and applying the above one instead. I&...

The following patch changes export.h so that the dllimport/dllexport attributes work with mingw/mingw-w64 and others: - changes _declspec keyword to __declspec: the former may not be defined by some toolchains. - changes the _MSC_VER condition to universally _WIN32: MSVC, as well as GCC supports this. Attached patch: declspec.diff Regards. -- O.S. -------------- next part --------------

...Makefile.am | 2 - include/test_libs_common/Makefile.am | 2 - src/libFLAC/Makefile.am | 3 + src/plugin_common/Makefile.am | 2 - src/share/getopt/Makefile.am | 2 - src/share/grabbag/Makefile.am | 2 - src/share/replaygain_analysis/Makefile.am | 2 - src/share/replaygain_synthesis/Makefile.am | 2 - src/share/utf8/Makefile.am | 2 - 18 files changed, 8 insertions(+), 195 deletions(-) diff --git a/Makefile.am b/Makefile.am index 0a65206..45a0260 100644 --- a/Makefile.am +++ b/Makefile.am @@ -28,8 +28,6...

...config.mk did not contain -DHAVE_INTTYPES_H, which under the full build process (I assume) is added by autoconf. 4. The compiler complained when lround() in lpc.c was static, so it is no longer static. 5. Additional scattered linking directives (and reordering) (particularly FLAC, grabbag, and replaygain_analysis) were necessary to build some of the components. 6. The Makefile.lite build system benefited from some cleanup, particularly by rigorously defining all entries, factoring redundancy, and establishing dependencies. (Some typos were fixed too.) 7. Shared objects on Windows use .dll, not .so. (Adde...

...config.mk did not contain -DHAVE_INTTYPES_H, which under the full build process (I assume) is added by autoconf. 4. The compiler complained when lround() in lpc.c was static, so it is no longer static. 5. Additional scattered linking directives (and reordering) (particularly FLAC, grabbag, and replaygain_analysis) were necessary to build some of the components. 6. The Makefile.lite build system benefited from some cleanup, particularly by rigorously defining all entries, factoring redundancy, and establishing dependencies. (Some typos were fixed too.) 7. Shared objects on Windows use .dll, not .so. (Adde...

Hi, I'm trying to build current git on i386, but it fails with the following error: make[3]: Entering directory '/tmp/flac/src/share' CC grabbag/replaygain.lo In file included from grabbag/replaygain.c:38:0: ../../include/share/replaygain_analysis.h:45:15: error: conflicting types for 'float_t' typedef float float_t; /* Type used for filtering */ ^ In file included from /usr/include/math.h:45:0, from grabbag/replaygain.c:25: /usr/include/bits/mathdef.h:35:21: note: previous declaration of ...

...m4/endian.m4 | 177 ----------------------------- src/libFLAC/Makefile.am | 3 + src/plugin_common/Makefile.am | 2 - src/share/getopt/Makefile.am | 2 - src/share/grabbag/Makefile.am | 2 - src/share/replaygain_analysis/Makefile.am | 2 - src/share/replaygain_synthesis/Makefile.am | 2 - src/share/utf8/Makefile.am | 2 - 19 files changed, 25 insertions(+), 389 deletions(-) delete mode 100644 m4/endian.m4 -- 1.8.0.1.525.gaaf5ad5

..._LIBS@ \ - -lm + $(top_builddir)/src/libFLAC/libFLAC.la example_c_decode_file_SOURCES = main.c diff --git a/src/flac/Makefile.am b/src/flac/Makefile.am index 6f0145b..ceae6a5 100644 --- a/src/flac/Makefile.am +++ b/src/flac/Makefile.am @@ -50,7 +50,6 @@ flac_LDADD = \ $(top_builddir)/src/share/replaygain_analysis/libreplaygain_analysis.la \ $(top_builddir)/src/share/replaygain_synthesis/libreplaygain_synthesis.la \ $(top_builddir)/src/libFLAC/libFLAC.la \ - @OGG_LIBS@ \ @LIBICONV@ \ -lm diff --git a/src/metaflac/Makefile.am b/src/metaflac/Makefile.am index dc286dc..bd54356 100644 --- a/src/metafla...

...taflac:$PATH PATH=`pwd`/../src/test_streams:$PATH diff --git a/test/test_grabbag.sh b/test/test_grabbag.sh index 5c044b3..8f1c5c9 100755 --- a/test/test_grabbag.sh +++ b/test/test_grabbag.sh @@ -34,6 +34,8 @@ LD_LIBRARY_PATH=../src/share/grabbag/.libs:$LD_LIBRARY_PATH LD_LIBRARY_PATH=../src/share/replaygain_analysis/.libs:$LD_LIBRARY_PATH LD_LIBRARY_PATH=../obj/$BUILD/lib:$LD_LIBRARY_PATH export LD_LIBRARY_PATH +export MALLOC_CHECK_=3 +export MALLOC_PERTURB_=$(($RANDOM % 255 + 1)) PATH=../src/test_grabbag/cuesheet:$PATH PATH=../src/test_grabbag/picture:$PATH PATH=../obj/$BUILD/bin:$PATH diff --git a/test/...

...ine-functions -Wall -W -Winline -arch i386 -arch >> i386 -o flac analyze.o decode.o encode.o foreign_metadata.o main.o >> local_string_utils.o utils.o vorbiscomment.o >> ../../src/share/grabbag/.libs/libgrabbag.a >> ../../src/share/getopt/libgetopt.a >> ../../src/share/replaygain_analysis/.libs/libreplaygain_analysis.a >> ../../src/share/replaygain_synthesis/.libs/libreplaygain_synthesis.a >> ../../src/share/utf8/.libs/libutf8.a ../../src/libFLAC/.libs/libFLAC.a >> -L/Users/glennm/libOGG-i386/lib >> /Users/glennm/libOGG-i386/lib/libogg.dylib -liconv -lm >&...